From: "Liming Gao" <liming.gao@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB
Date: Tue, 4 Feb 2020 06:52:12 +0000 [thread overview]
Message-ID: <f6b5d899d2c04b338000426b77d76b5c@intel.com> (raw)
In-Reply-To: <20200204022058.429348-2-zhiguang.liu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Tuesday, February 4, 2020 10:21 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2415
>
> Avoid using __clang__ to specify CLANGPDB because this macro is also defined
> in CLANG38 and this causes CLANG38 build failure.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> MdePkg/Include/Base.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
> index 321d729c04..53fa6dca04 100644
> --- a/MdePkg/Include/Base.h
> +++ b/MdePkg/Include/Base.h
> @@ -623,7 +623,7 @@ typedef char* VA_LIST;
>
> #elif defined(__GNUC__) || defined(__clang__)
>
> -#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS) && !defined(__clang__)
> +#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS)
> //
> // X64 only. Use MS ABI version of GCC built-in macros for variable argument lists.
> //
> --
> 2.16.2.windows.1
next prev parent reply other threads:[~2020-02-04 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 2:20 [Patch V2 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain Zhiguang Liu
2020-02-04 2:20 ` [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB Zhiguang Liu
2020-02-04 6:52 ` Liming Gao [this message]
2020-02-04 6:52 ` [Patch V2 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6b5d899d2c04b338000426b77d76b5c@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox