From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.2868.1580799148193008768 for ; Mon, 03 Feb 2020 22:52:28 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 22:52:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="263731225" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2020 22:52:24 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 22:52:14 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 4 Feb 2020 14:52:12 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Tue, 4 Feb 2020 14:52:12 +0800 From: "Liming Gao" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB Thread-Topic: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB Thread-Index: AQHV2wHdkgF/FzYU4EC/pfrzc0tKWqgKmTQg Date: Tue, 4 Feb 2020 06:52:12 +0000 Message-ID: References: <20200204022058.429348-1-zhiguang.liu@intel.com> <20200204022058.429348-2-zhiguang.liu@intel.com> In-Reply-To: <20200204022058.429348-2-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Liu, Zhiguang > Sent: Tuesday, February 4, 2020 10:21 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > Subject: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2415 >=20 > Avoid using __clang__ to specify CLANGPDB because this macro is also defi= ned > in CLANG38 and this causes CLANG38 build failure. >=20 > Cc: Michael D Kinney > Cc: Liming Gao >=20 > Signed-off-by: Zhiguang Liu > --- > MdePkg/Include/Base.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > index 321d729c04..53fa6dca04 100644 > --- a/MdePkg/Include/Base.h > +++ b/MdePkg/Include/Base.h > @@ -623,7 +623,7 @@ typedef char* VA_LIST; >=20 > #elif defined(__GNUC__) || defined(__clang__) >=20 > -#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS) && !defined(__cl= ang__) > +#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS) > // > // X64 only. Use MS ABI version of GCC built-in macros for variable argu= ment lists. > // > -- > 2.16.2.windows.1