Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 03/13/2018 10:04 AM, Star Zeng wrote:
> Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
> This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> index 5767ac82da21..c30a3ac7200f 100644
> --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> @@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
>  #define PCD_TYPE_VPD          (0x4U << PCD_TYPE_SHIFT)
>  #define PCD_TYPE_STRING       (0x1U << PCD_TYPE_SHIFT)
>  
> -#define PCD_TYPE_ALL_SET      (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
> +#define PCD_TYPE_ALL_SET      (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
>  
>  #define PCD_DATUM_TYPE_SHIFT  24
>  
> 
Oh forgot to mention, had a bit problems to apply this with git am,
could it be that your MTA changed out the edk2 newline format (windows,
\r\n) with an plain UNIX one (\n)?

Sorry that I forgot to mention this in my other mail.

cheers,
Thomas