From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=212.186.127.180; helo=proxmox-new.maurer-it.com;
 envelope-from=t.lamprecht@proxmox.com; receiver=edk2-devel@lists.01.org 
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 8A6DA21F6A6D3
 for <edk2-devel@lists.01.org>; Tue, 13 Mar 2018 02:15:55 -0700 (PDT)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7A87142738;
 Tue, 13 Mar 2018 10:22:15 +0100 (CET)
To: Star Zeng <star.zeng@intel.com>, edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>
References: <1520931840-99248-1-git-send-email-star.zeng@intel.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <f6b98e81-d5f8-9e59-0107-38e741d40278@proxmox.com>
Date: Tue, 13 Mar 2018 10:22:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1520931840-99248-1-git-send-email-star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Mar 2018 09:15:56 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 03/13/2018 10:04 AM, Star Zeng wrote:
> Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
> This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> index 5767ac82da21..c30a3ac7200f 100644
> --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> @@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
>  #define PCD_TYPE_VPD          (0x4U << PCD_TYPE_SHIFT)
>  #define PCD_TYPE_STRING       (0x1U << PCD_TYPE_SHIFT)
>  
> -#define PCD_TYPE_ALL_SET      (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
> +#define PCD_TYPE_ALL_SET      (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
>  
>  #define PCD_DATUM_TYPE_SHIFT  24
>  
> 
Oh forgot to mention, had a bit problems to apply this with git am,
could it be that your MTA changed out the edk2 newline format (windows,
\r\n) with an plain UNIX one (\n)?

Sorry that I forgot to mention this in my other mail.

cheers,
Thomas