Re: [PATCH] SecurityPkg: Remove superfluous return statement

[Thomas Huth <thuth@redhat.com>]

On 25.01.2017 10:58, Thomas Huth wrote:
> If the code eventually returns "Status" anyway, it does not make
> sense to explicitly return "Status" in case of an error, too.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> index 33f77bd..a95ea2f 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> @@ -1286,10 +1286,6 @@ AhciModeInitialize (
>               EFI_TIMER_PERIOD_SECONDS(16)
>               );
>  
> -  if (EFI_ERROR (Status)) {
> -    return Status;
> -  }
> -
>    return Status;
>  }

Ping?