From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thuth@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 7742181F53
 for <edk2-devel@ml01.01.org>; Thu, 16 Feb 2017 01:44:51 -0800 (PST)
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
 (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 0A1EE7E9E0;
 Thu, 16 Feb 2017 09:44:52 +0000 (UTC)
Received: from [10.36.116.247] (ovpn-116-247.ams2.redhat.com [10.36.116.247])
 by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with
 ESMTP id v1G9inu9017759
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Thu, 16 Feb 2017 04:44:51 -0500
To: edk2-devel@ml01.01.org
References: <1485338335-29716-1-git-send-email-thuth@redhat.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <f6c37a16-c57e-9f68-4dab-aa06a6f732d6@redhat.com>
Date: Thu, 16 Feb 2017 10:44:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <1485338335-29716-1-git-send-email-thuth@redhat.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.26]); Thu, 16 Feb 2017 09:44:52 +0000 (UTC)
Subject: Re: [PATCH] SecurityPkg: Remove superfluous return statement
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Feb 2017 09:44:51 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 25.01.2017 10:58, Thomas Huth wrote:
> If the code eventually returns "Status" anyway, it does not make
> sense to explicitly return "Status" in case of an error, too.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> index 33f77bd..a95ea2f 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
> @@ -1286,10 +1286,6 @@ AhciModeInitialize (
>               EFI_TIMER_PERIOD_SECONDS(16)
>               );
>  
> -  if (EFI_ERROR (Status)) {
> -    return Status;
> -  }
> -
>    return Status;
>  }

Ping?