From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F2BDA940FA7 for ; Wed, 6 Sep 2023 02:36:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nXxv7QpXr7Y63yl8fbifTxevqIXw1YwtPrPb+rv6dFE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693967793; v=1; b=dE4U+gQ6PRwTqZh8akdIAAXpTyFQx8XVx5uqPCSappVJvL0C6R/0ZRvUSF4wZOQvPerUgRPX DPZfHs8oS0u7QInTWa7NqGIWtROIu7qI8GpQUUAKk8jtO/JG/mOaJx9oWtjOEkvXe0GUYFlT2Dw e7aEwCAFYv/a/rorTQsDIvU8= X-Received: by 127.0.0.2 with SMTP id hjL6YY7687511xRe0ugEyM0d; Tue, 05 Sep 2023 19:36:33 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.227.1693967792489339974 for ; Tue, 05 Sep 2023 19:36:33 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10824"; a="407952470" X-IronPort-AV: E=Sophos;i="6.02,230,1688454000"; d="scan'208";a="407952470" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2023 19:36:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10824"; a="864981274" X-IronPort-AV: E=Sophos;i="6.02,230,1688454000"; d="scan'208";a="864981274" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Sep 2023 19:36:30 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 5 Sep 2023 19:36:29 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 5 Sep 2023 19:36:28 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 5 Sep 2023 19:36:28 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 5 Sep 2023 19:36:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GChSt/Ve64qrS7BGILCLT6/69xomvjdtqhMGK5Jn0oawk0rF1MjbjgW46S/4vHW5YjBwd8pdYl3DpyRlHFNNKLZXUA7B87sS3a6Bch67DsX7HjV4fNjhHyMGiTGkv4UlfYETclK3pPDlQ5ASvyicHnq1lzTtJbp7TWOg7GAWbp/Ji9UFJIK2VpDjHx4CGkoZXxrQ1XIehq8hZFnBS7vaPbiNHqyzSovgeAquMjcRswCu70eDe6+jTuKbT3SWmqzd/gKHXRswGkQEIM2nnXB+EZz1M0s+nk/rVCF/DbTa19HS0zccmIrWYYwpRkzxuZT0haSy5LWZu+U5XZOwHDgl1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f2f2NrDO2MjqsklyS7+1/7ERarXBiafkltkW+w/HOZk=; b=L8PkmK8HbbtWwPq89jcic7FdU5cfnQG9k4TJCTkbTd9gyk/AFC0Ty59gz2yAOnGlp4LNeJm7M1FcUPSm9O9YLfYQSd2ay14KT0nyOuaXpyH4G8DXaSLNEU3SDZxg3yDWBj+CIemXNOevJEhryD8j8/0ZBJMsOw+mX45J5wT0g4/ZcBQHz7c3PnBbi8nAOSpOuRYvNVByK+D2F2S7IbSLbJrD6xXV4t+85w00TsIZo87Ut5sPpc+JB+0TKkILnCkXKEavrRaaF0pmlvqiU433uuMOsYx+RfhLWLc7pQOqvDh/mmzO/RHgL7xc9g8GsQKg2xO71ghRXfo3xyY0OxMuzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SA3PR11MB8004.namprd11.prod.outlook.com (2603:10b6:806:2f8::19) by LV3PR11MB8577.namprd11.prod.outlook.com (2603:10b6:408:1b8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.34; Wed, 6 Sep 2023 02:36:25 +0000 X-Received: from SA3PR11MB8004.namprd11.prod.outlook.com ([fe80::f6b2:ff1c:388c:942d]) by SA3PR11MB8004.namprd11.prod.outlook.com ([fe80::f6b2:ff1c:388c:942d%4]) with mapi id 15.20.6745.030; Wed, 6 Sep 2023 02:36:25 +0000 Message-ID: Date: Wed, 6 Sep 2023 10:36:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable To: CC: Ard Biesheuvel References: <20230901082117.1618901-1-yin.wang@intel.com> From: "Wang, Yin" In-Reply-To: <20230901082117.1618901-1-yin.wang@intel.com> X-ClientProxiedBy: SG2PR03CA0101.apcprd03.prod.outlook.com (2603:1096:4:7c::29) To SA3PR11MB8004.namprd11.prod.outlook.com (2603:10b6:806:2f8::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA3PR11MB8004:EE_|LV3PR11MB8577:EE_ X-MS-Office365-Filtering-Correlation-Id: 4737560b-f7c1-44c4-7755-08dbae8210d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: LZShhmgz7yTPNkdYR/CYf5yJqRHzO6S4wtqrNmZRSSW99BDjll0ytLfOyTj7Ejs/6kld3LiGu7Dklsv6R7fvLm+KZmo21KMstW+funt+qmys+RN076PLWgvySf/h4N41guJLdKUvMmx0CXV/XWsrkAlqoKfGWGu+JRRIB5diTzDM1/GxoZcwPpPxlNpFVbn9hDQQUY0LMwL8xKoIGVU7ZqtEKZF8iGKGvtkRZadiavODPzsoqZ+D3vSWb4r5o/rg7nEDyOu9Y+0kx6s14DAs9+Zk8Ul542C7Q5h6A5fwlrFrVUcW4ezZ+UfyaFiAVHDChgeeKeeBpQluTgO8mVwBBUAgcfeOyDdw5AlAoJbkafgRxCKyi6TKZFZCvPdqKypeaSQx1zPYV2UbzLdK/sx0E3UYGN06WADqFNucTlYo+EP80hy4QyeOS9c1aeVMdSIta7C9tF0DlcHAD4lSv+XhwGTIchGL0TAZvmNGPbGi69DLoc9DJCMJcN+zacEbIimtNywQdzLZhhWdC+O5SKBrvIWdA2zIDIZHi8DiZppj6cugAA9acx/1VZWeQwhTmh94GWiZPxt8jtusBOYgTp5tp7KuFApYu6Z+jkj3vqLZV4tmIFtIi1a4FvGmsm6KUaVqX0OgVOHIXxPxCefDE++wiA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEx0OFVZNm94UFFpaEYwU3Y1NDFlZDVkemxabXRRRGdhbnp6L2ZQRVJwN0hD?= =?utf-8?B?SXY2eWRmNG4vOTBzT1FxRTRrS3k5WU5CYmpwZmJPQ0lHa1czYXpMYkhtQVIz?= =?utf-8?B?UVVrYlFDbnJoc3U1Q1ZXRW91TUpEN0dSQis5dksreEt3U29DSFJXVGdWMVo3?= =?utf-8?B?K1hHOVlpUnJ5b2tGbGlmZEp6ZERTRE1yVUk4RXE1WWZJSWdPTmU0T1Y3ZTlN?= =?utf-8?B?MEFrMDB6ZU5mY1QvRmZKY1IyYk1WRGFFRTVNV1RySDZ6UTlCNUxSR01iTlpE?= =?utf-8?B?SENmZDBDVTZLcEtkeFJqT1ZlVXR6VzlqYVZrQUJ1SjRZbGVQVEdHLzhZalBS?= =?utf-8?B?ZlRxNTBjYjVtWHl6bFE2emt4YUZGTXd0UmFzQXY5dE0yQjRTQUxmT2pVQlJ3?= =?utf-8?B?SllCVHFOSjNQdXlHc3hTci8vSUpLbXhGcW5PTHRRQVhlRDcvUUpsL29GTmJy?= =?utf-8?B?cTdIaHR3STRvTnU3UVNWRDZ1clgrN3dORWc4d1ZzUnVPNEl5OW11RWdHQk1w?= =?utf-8?B?d0ZOajRuTXo2Wk9KR0VORHVNenBURlFkTVRtYy81ZHArdkRhRmN2UjdFWEgr?= =?utf-8?B?U01oWUtPVnVjNVhxcnRYTUZ1U2NiZTROUUptajNTWVIzREZBVG1aOElXTVBC?= =?utf-8?B?TzRUMHpFdmFMT0tqaXNhcmhLWUlLRDYzdG8rYXN3ZGx6YVF5VW5jam90WmVH?= =?utf-8?B?VnFHY0hYQTIvWm4vZjNWRnVZV2M2djRXYUJBNkoxY0s5T3JYUGlYZmJmczJl?= =?utf-8?B?aisvaVQzWG52bVhNVE45ZFhhNGJwWC9ZV0RXK1p0bnoyd3pZa3dWWldEcVVt?= =?utf-8?B?Z2l4b1IwQ3hvYmtjRmppTVpyd3Q5cm1UdVRybDR4K3BDZjhLQ2tBYnlNem1U?= =?utf-8?B?Q2lOVDdocDlxWUdpVjRGYXBFK0ZpbzdFS29pMG13cHNnaDFINStIZ3RueUFV?= =?utf-8?B?a21hNVJ3RDhEUys1RnQ2cUlMdlRBcktxbkhjTDNyYTVwbVRwaENLU1dRQ1B2?= =?utf-8?B?eG9GRnRzb1VuaGJvM245MVdPdlM0Ky9KTnFheTFWR2o1UXRDN3lCZlBuVVpn?= =?utf-8?B?UkpGcWZvc01iS1hBaGtrbU1EaUhsUnR5bXNRWGwvRmtPRzlTcHN6akVDazlO?= =?utf-8?B?SEV3ZjFPY2hibjkyNC9JbmNwVm9DSXB2OGwraVFRMTZWb2JZc1lwV0h6NVAr?= =?utf-8?B?YzlNYXN0ZFJselpkV2xKTlEvejc4cUlBQ3B2VUpDRUsxTlVRUGlGSlhDOXkv?= =?utf-8?B?WUJQWlpWZ0QvZm1DbTdtUTlKMGdMcVV4cllwMlFKWE53S0ZsNFJGRG5HZkdP?= =?utf-8?B?MkxjVXh6c0xKZUkyRWRQQ1dkK21hSFNGdEM1eGF0b2NUamVsbXdLUmtuL0ow?= =?utf-8?B?SnVRM1NjdUtTZDhYYms4OFNsUmRUTDZWRGJXVUFleTMvQXBIQ3huZEpSOGIx?= =?utf-8?B?SmVaOHF3UDZkT3RaajdFSDdtclUzK3Izek5sUmZ2M3NwZHFYUk5YZEk1Zmcy?= =?utf-8?B?akdRbURHejBhYSs5a3g2V2J6RkN6SGhMcGpEU0FwOG1VdlFHN1BxTUs5NjdC?= =?utf-8?B?KzdnZDVoZ1VaNU5UYXl0bUt3WDYvc0dmUWpEakZHcjFWVzhOcG5QT1lyTEho?= =?utf-8?B?V0ZYS1RQWU4xT3JBd1ZTNGtEQldvOWdrTktMRy9WTC9VVENzRnVuUWdUUUUy?= =?utf-8?B?aTd2M2huZ1QvVk1ETlFLNmVJRXZBMEdqMXFETVoxLzJud3l2cDhIeWU4NlNJ?= =?utf-8?B?QnI3dXBIajQxZDZFTnl5YWdOcUd2U3NmSDcrYjlVTGdrMXBvOEtLUWI2TVFV?= =?utf-8?B?RXBhQ0xSejVzWXNHUE9vTE51WkhYdmtPblBQd0xTdmUwUXdlYmFLT1hPVFdw?= =?utf-8?B?eEtGRjIzYlh3djlmR3YyT0hZWS96U0tSc2sybXFDUWt2Umc4QTJPWGRBWGFw?= =?utf-8?B?b2hEV3BtQjZ4UE5UVjNaV2kveG5mcXZHaE0xTkZiblBPRlBMeFFjY0NmV1JK?= =?utf-8?B?d2NlTVo1Ym9JdTVyZU5ucVVHWU9GRDhVdnN2aTdNQ2tCei9qMVNZZXp0L2ly?= =?utf-8?B?SFlUSmcyZTRQTjg2dENRcE5WejlYd1h3d0JGZHl2a3Z0LzNGU09WSy8reFh2?= =?utf-8?Q?VhMnPItk+mfyH4Ro2df2BLJVV?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4737560b-f7c1-44c4-7755-08dbae8210d8 X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB8004.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2023 02:36:25.7728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fYvynYLFJayKahaXMKvit9SfLIceL2EGyc4aKR/I5zPIDITeySjG5QBnrKVohsAQADPFUpkGXGiM1kFil01VvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8577 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yin.wang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8zSf3IvAGHSpPEIcczEWuuGAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dE4U+gQ6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ard, I have an EDK2 modification, which is located in the=20 OvmfPkg/PlatformDxe/Platform.c file. The modification involves changing=20 a Hii form name. Could you please review this change? Or do you know who=20 I should ask to review it? Thanks Yin On 9/1/2023 4:21 PM, Yin Wang wrote: > The Hii form is named "MainFormState" while the EFI variable is named > "PlatformConfig". > This discrepancy in names causes the following SCT cases to fail on > RiscVVirtQemu: > ExtractConfigConformance > ExtractConfigFunction > ExtractConfig_Func > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Dandan Bi > Cc: Eric Dong > Signed-off-by: Yin Wang > Acked-by: Gerd Hoffmann > Acked-by: Sunil V L > --- > v5: Re-organize commit message > v4: Update commit message about version history > > - aefcc918: Enhance ExtractConfig() to match UEFI specification, > adding check of whether " matches the GUID and name" > - 16acacf2: Fix Hii form name mismatch in ExtractConfig() > - This patch: Add one more fix for Hii form name mismatch > > v3: Gerd comments on v2 that caused issues may related to RISC-V > specific config. To address this separately, the patch was restored to v1= , > and details were added to the commit message. > > v2: Add two more changes which caused other two SCT Hii cases to fail. > > v1: Initial version > --- > OvmfPkg/PlatformDxe/Platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platfor= m.c > index cd3bfd554c..c32439683d 100644 > --- a/OvmfPkg/PlatformDxe/Platform.c > +++ b/OvmfPkg/PlatformDxe/Platform.c > @@ -279,7 +279,7 @@ ExtractConfig ( > // > > ConfigRequestHdr =3D HiiConstructConfigHdr ( > > &gOvmfPlatformConfigGuid, > > - mVariableName, > > + mHiiFormName, > > mImageHandle > > ); > > if (ConfigRequestHdr =3D=3D NULL) { > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108297): https://edk2.groups.io/g/devel/message/108297 Mute This Topic: https://groups.io/mt/101090614/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-