From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 71F72740051 for ; Mon, 25 Sep 2023 09:03:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7lprbPUu7S8L1CK0SzXK/5KWlPRdFJ1BOSVWA1khRGM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:To:From:Subject:Organization:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695632586; v=1; b=IvhCl+fFcTO+Kq72wu2qVbLUasHtaJ5RccvhIiGNb93/wB1Obm49K2h+NDfyGUyjyZ6U9K/Q 6CLtVx9Ona8SBb+3HOnwGNoS97f2jEH6w5KX9FiUqNJhABMDcYEObX0Cxo7/BLl5YAjnjqfuj6l 1BeRmcBAW/O6ogUmjOcvdc2c= X-Received: by 127.0.0.2 with SMTP id s8fDYY7687511xhppYEcoYD4; Mon, 25 Sep 2023 02:03:06 -0700 X-Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mx.groups.io with SMTP id smtpd.web10.56818.1695632585138690597 for ; Mon, 25 Sep 2023 02:03:05 -0700 X-Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-9b0168a9e05so489512666b.3 for ; Mon, 25 Sep 2023 02:03:04 -0700 (PDT) X-Gm-Message-State: H2raqukvRe2kJL40H1W04hgNx7686176AA= X-Google-Smtp-Source: AGHT+IF2eRMxOZQMqouziWUOfHTwyvrUG3pKvpvl9pAriV+xFDX6OKewsWqfX2r8ROOTKFDgjUgETA== X-Received: by 2002:a17:906:3184:b0:9ae:4878:1172 with SMTP id 4-20020a170906318400b009ae48781172mr5061999ejy.7.1695632583137; Mon, 25 Sep 2023 02:03:03 -0700 (PDT) X-Received: from [192.168.200.206] (83.11.3.58.ipv4.supernova.orange.pl. [83.11.3.58]) by smtp.gmail.com with ESMTPSA id kg28-20020a17090776fc00b0099b921de301sm5977537ejc.159.2023.09.25.02.03.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Sep 2023 02:03:02 -0700 (PDT) Message-ID: Date: Mon, 25 Sep 2023 11:03:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: devel From: "Marcin Juszkiewicz" Subject: [edk2-devel] Maybe it is time to update code style? Organization: Linaro Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IvhCl+fF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I feel sick each time I have to edit EDK2 code. All those INF, DEC, DSC, FDF, XYZ files are something I do not even try to understand, just got minimal knowledge what goes where by asking Leif (thanks a lot!) and observing build error messages. I got used to UINTN and other weird variable types. No idea where from they came from (MS Windows?) But what sucks more is those 2 spaces used for indenting code. Took me a while to reming myself when I used such. It was in 90s, when I was Amiga programmer and all I had was 720x480px screen. Last time I looked at calendar it was 2023 year. Maybe it is time to move to 4 spaces? And can someone take a look at config of code obfuscator used for linting? It spits out amount of information showing that noone looked at updating it to current version: $  uncrustify -c ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c Option: at ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg:48: Expected unsigned number , for 'mod_full_brace_if_chain'; got 'false' ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg:79: unknown option 'indent_func_call_edk2_style' Option: at ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg:212: Expected number , for 'indent_bool_paren'; got 'true' Option: at ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg:224: Expected number , for 'indent_comma_paren'; got 'true' ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg:241: option 'indent_sing_line_comments' is deprecated; did you want to use 'indent_single_line_comments_before' instead? ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg:270: unknown option 'align_edk2_style' ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg:426: option 'nl_func_var_def_blk' is deprecated; it has been replaced by 'nl_var_def_blk_end_func_top'. You can also use 'nl_var_def_blk_end' for additional functionality ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg:447: option 'pp_space' is deprecated; it has been replaced by 'pp_space_after'. Output suffix: .uncrustify do_source_file(1524): Parsing: Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c as language C $  uncrustify --version Uncrustify_d-0.76.0_f And yet it is a tool which contributors like me are supposed to use before sending any change upstream. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109037): https://edk2.groups.io/g/devel/message/109037 Mute This Topic: https://groups.io/mt/101570674/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-