From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web10.65069.1680007052758026596 for ; Tue, 28 Mar 2023 05:37:33 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=VpwiweNK; spf=pass (domain: os.amperecomputing.com, ip: 40.107.236.100, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Adib+j5GScazwd4X86o9tlqznIdFDw/AAADo5lT9ebGYXaz4ll/qOW/0BCf6R6SzHfYonnPdIER6YozjcSuQwi/IivlAC5gby6UH7df9UuMaWRmRpJNc7ZkKCORW6suJ1tnAGXyXybkpxpJMyawNQSidFmZtPRDo6dh5fu5bWQR0Tj0pz5u+LFwjn7Q0wxzJ6dKXygI4rmDLxNcRojZGddBxb+V8C8OedWM/mOGfxhaYTqMycW6a3+Kr42csVOnd9t+topkk0QjiBFc0wE1J2m48feIFzcBqqjhWme2RTr6MF6fp2RvBb4r1lrp/e2bcAnxqi48b5zPaAnoY6JZ1Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6wWOUv7cUQZDDqKs/QxbzzC1UWY9h1/oximOrDbCSsQ=; b=VCunCeEEl1WlpUCnRtlvHlH/q5QzR5iQO369pw83H+7eaaDc8Zxj8QNgr+uCPUtNpTxZ5kJ1+kMTuMNvjPbWefxvv2Skhp4Sj8m6u2Hk0aYzCuCcMgek0dexo0xIFeSHN1jPqGLSqL1bEWhNSCArU9TYV0jzEda/izHuJPgSKZT7nJyWWXT7C1Le3T8vNsl9p8hgwEnoSB6r5Awwlfua+/Q2yOA55QoskyPQX2C2ors8PCfktgFy7qfs6BwviNxGoqnAzFwglp2SypaXyw1I87Y25X48+tfVnB+QUHRwc6HNsVEdNAosK/qzLq3POEz61euguHln1X/ed0Zpyajujw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wWOUv7cUQZDDqKs/QxbzzC1UWY9h1/oximOrDbCSsQ=; b=VpwiweNKzQj7Prt4YHHcKM7f4SGKxHVkP6pj8sJF7QkZc7Tdk8NK396r12LNPWrmKH36IJRB2LrgdJXzpgecsOHl4HEAkb6E05NlodtFVt757ajvKIFXiLOUcdOwL8M42HzTiEsybn62U6efio/0Eti7Wcq8RD1DE7MiJJIYFR8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from MWHPR0101MB2942.prod.exchangelabs.com (2603:10b6:301:2e::14) by DM4PR01MB7715.prod.exchangelabs.com (2603:10b6:8:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.18; Tue, 28 Mar 2023 12:37:29 +0000 Received: from MWHPR0101MB2942.prod.exchangelabs.com ([fe80::1d06:a51a:ca3d:c2f6]) by MWHPR0101MB2942.prod.exchangelabs.com ([fe80::1d06:a51a:ca3d:c2f6%4]) with mapi id 15.20.6178.041; Tue, 28 Mar 2023 12:37:29 +0000 Message-ID: Date: Tue, 28 Mar 2023 19:37:19 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package To: devel@edk2.groups.io, abner.chang@amd.com CC: Liming Gao , Isaac Oram , Nate DeSimone , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy , Abdul Lateef Attar References: <20230322024840.1629-1-abner.chang@amd.com> <20230322024840.1629-2-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230322024840.1629-2-abner.chang@amd.com> X-ClientProxiedBy: SI2PR02CA0025.apcprd02.prod.outlook.com (2603:1096:4:195::21) To MWHPR0101MB2942.prod.exchangelabs.com (2603:10b6:301:2e::14) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR0101MB2942:EE_|DM4PR01MB7715:EE_ X-MS-Office365-Filtering-Correlation-Id: 19198e1d-99ce-4999-1037-08db2f893153 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 44RJe3OzS0y9clKADJdZhugmiiwIuvlx6yxHTfWpbvP5u7K+GvSB021AQmOvFg9qJMsX4l5+wKX7nVU+mPE1C/GTJQn53I6Lk1ISmlxZiWgGWhkYWQ0S/NHpQOru4ECHwX9tCJ8GmlXRH4LZK13tCJXXTPaolOs760/7dAD3+NAOzHA1ewlvjJ9t7yKulWzszQ+AkgmuDyYd0uGXoq+V4+rXWPT2g0WnjkrvUCcsm8Xqg55SBmVFJIy/XLf+CQRmnlxGWQj0MS/hx2uj1ZyUsUPhLCoR/aVIQnF6VjKKQRSvENJw3P0rBd0f2Nft38hc2IbwYdh5AQiQhOrbDCqAA6g2WFbQnInE03taaX6qsLAluguf+qMzJOKx3rjGbuQ0qR/4LyAamETzXowtszTeCtBNBaCN6gLqvVSwfaF7BSMjSFTnkFuPHfzIcDBM3C9rohN/pyPQAQX4AwI71wcah74TjWtnrJzboEW38uP3qinfeqeOUyQGcX2VeeQgyADxFZ8VW9Kq7e+5l9+EjQpRGewllIIs5ZJJtxlPhSh9eHGNnDCm7e7+BTDE2TfPqjHvbiHGbbN+TscmrSKDY4tbktyWah8AX1Nylfb2m8daX2x9YSB1JEWlpyVGfpK2icl8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR0101MB2942.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39850400004)(136003)(366004)(346002)(376002)(451199021)(6486002)(4326008)(66476007)(8676002)(66946007)(66556008)(41300700001)(83170400001)(2906002)(31696002)(5660300002)(8936002)(38100700002)(478600001)(316002)(54906003)(6506007)(6512007)(26005)(53546011)(186003)(6666004)(31686004)(2616005)(42882007)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?76FthTrLeMGDx/T7H+IvFtZUPJQt1047NeF1YwnUQSE5K6CV8I0wF1lsxioz?= =?us-ascii?Q?CZn1BwIne4eJu4aKKeluGtm7KG9t40lXCpIE9WaEeDcAEBs+RJLcMc0RlqnH?= =?us-ascii?Q?cVJq1vCDIk59E9dGnGIkfNEJK1n+YC8xwVfSDj4+MgFF1NHUxwpN8N3WniYl?= =?us-ascii?Q?XxVfzIdrmyieMexK2keOH3K/ao0tC+hGoYn34FWQRmrrFVMY673S0mW8XWgR?= =?us-ascii?Q?9hntGiagQXSBO7KS3OT9I62UEMob0WCPxIEfuobUzFKY/Yf4uv1QxuY+ikG6?= =?us-ascii?Q?hU/+lw6ULh5V8FWZ44ZD9vwL4ocRZ/2IUqsOLt7DM4pd0Vjw4NgNKRc+f+Mt?= =?us-ascii?Q?XZ7P5+lXA0tP+m56vixkEP4VLS3hjp+Vo3rNUo1Lo4p5CcAEO6jnimFwQgm5?= =?us-ascii?Q?sTEqrZY6RVp25k+iEh5IRiqr1pl2X3b0gS91coQZkgkjW/QxG6AoAVKzZeyg?= =?us-ascii?Q?W9XPlaQYeCx9o1GekJRtNMqNKO4dSuxZPINcw+akmS+d6PSbrBuQG25C6Rt2?= =?us-ascii?Q?ZCUlHPt1+z6KLRLkiO/EUB1leDFi6EPDRJsNElssBVn/MD+wGie1EWMtPK6o?= =?us-ascii?Q?G1yoesfKbNA9snhKfvefcKDIDSFrkfjB+1mrRuiuGbcROiHvwZSrUuL9fEqQ?= =?us-ascii?Q?nTFdiikwucmZt4YaR1RTHHZuiiN3fkWqBMSDrpufBXkM4Dd38ErVe2FSKe2S?= =?us-ascii?Q?p9juCWVzxvdkm3JHc+i4CfMS3IuFq2f/+DLfAvH0kRxBz6Ez+pm3Tlo7EFEk?= =?us-ascii?Q?z0MQ/gSbAbkf6XyrgDlkTnml7PvRbqFIUtpkcMY3Hp/6+QVs7/rv+X9ArupW?= =?us-ascii?Q?zVXQtzxWKkUyoQWKa4prw4f0AHM23BftDCyFdhoyqSqbGETYt6H3mlZv3EFn?= =?us-ascii?Q?fc0nsuXJjzBxctSVZUOIOIffdtds6loVlIbBRi6kcGTYxq1qunFGMSB7ud+A?= =?us-ascii?Q?SqrltpUIlgPpzNHcSl0clTkC0G1dA1nMdoOXbbYOwCLGHilqMXr62nvNvJnM?= =?us-ascii?Q?/2LcposEA/9HIAbIm1VZEn5261+ac0Hte0sjsJQrA/pNOSvtkfZYu2/NXUdX?= =?us-ascii?Q?WwtiqUyl4BYHjcFr2yIVjx42cZ3IJiluuZotPVKDu8Rnx/oxdbwTdr8vQOW+?= =?us-ascii?Q?coeHddoAbOu9iWg6YEGn+E85sGsgjKnqrjCt24EG4vIUdi3hpH3MlcdwokXl?= =?us-ascii?Q?hsCC8CD0mnW5Q/RQYVoUu1ctRfdDhpdlybYKP7vf8AqY5Ga56dby4C9bVug9?= =?us-ascii?Q?eYOMgn3cAnCOPBtunEL6dHRcrFiID/1zLJmWBW77zNc+KGcarhm8JQ8OXyuO?= =?us-ascii?Q?H217maKXbiPTLeb9I54pwjo2CJ5AvP/nbO/nxHoOmv5xVEteR2xjHWPm7VhG?= =?us-ascii?Q?0giwRzJ4fcSNI48HxFSf2aCq3gj6ut+Y9+yXcYqwESKQYvDfJfLHy2WoGmww?= =?us-ascii?Q?Ab7w0kJR/zKZTuqBdKKylhQwojkE0TwIH/1D3ltVQvljFPmbkqO7qy6yWahC?= =?us-ascii?Q?TRdgis6TLc1q/2ZWANvvnNw+hEmAiGeJHB7KljrPfp6hHCjkshXQdckllvC9?= =?us-ascii?Q?PWDTLcmQvgefDzvyx8yOYUD56DqJdism0vve1K5naDX+6vp4L6I9g9/c1WOw?= =?us-ascii?Q?5TZru2x+cT64uoHVntexf0E=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19198e1d-99ce-4999-1037-08db2f893153 X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB2942.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 12:37:29.0577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4CToxK4tgFLokeSa11fGKhf/aoWhU7VnUBiB5+CG219XGvqBaa7qA2mOWbvFREyChuQxVOf+5nrKdMBY+vRQd5MwR9OSKxPmnEqlWWlHsdHgHx7imFy+KJm+8RNLY30Q X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR01MB7715 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Abner, =C2=A0How can I include this package into flash description? May we lack t= he=20 FDF file? We can refer to AdvanceFeaturePkg, could have PreMemory.fdf and=20 PostMemory.fdf BTW, Please add PCDs to the feature configuration; this will be very=20 useful when other transport drivers are supported. Regards, Tinh On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote: > From: Abner Chang > > Initial commit of ManageabilityPkg > > Signed-off-by: Abner Chang > Cc: Liming Gao > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Abdul Lateef Attar > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Reviewed-by: Abdul Lateef Attar > Reviewed-by: Nickle Wang > --- > .../ManageabilityPkg/ManageabilityPkg.dec | 21 ++++++++++ > .../Include/Dsc/Manageability.dsc | 16 ++++++++ > .../ManageabilityPkg/ManageabilityPkg.dsc | 39 +++++++++++++++++++ > 3 files changed, 76 insertions(+) > create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dec > create mode 100644 Features/ManageabilityPkg/Include/Dsc/Manageability.= dsc > create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dsc > > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/Ma= nageabilityPkg/ManageabilityPkg.dec > new file mode 100644 > index 0000000000..71bd8a0c80 > --- /dev/null > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -0,0 +1,21 @@ > +## @file > +# Manageabilty Package > +# This is the package provides the edk2 drivers and libraries > +# those are related to the platform management. > +# > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + DEC_SPECIFICATION =3D 0x0001001d > + PACKAGE_NAME =3D ManageabilityPkg > + PACKAGE_GUID =3D 36310119-4FB2-4BA3-959D-74C16B849F9E > + PACKAGE_VERSION =3D 1.0 > + > +[Includes] > + Include > + > +[Guids] > + gManageabilityPkgTokenSpaceGuid =3D { 0xBDEFFF48, 0x1C31, 0x49CD, { 0x= A7, 0x6D, 0x92, 0x9E, 0x60, 0xDB, 0xB9, 0xF8 } } > diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc b/Fe= atures/ManageabilityPkg/Include/Dsc/Manageability.dsc > new file mode 100644 > index 0000000000..2cb63c1ca6 > --- /dev/null > +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > @@ -0,0 +1,16 @@ > +## @file > +# Common libraries for Manageabilty Package > +# > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[LibraryClasses.ARM, LibraryClasses.AARCH64] > + # > + # This library provides the instrinsic functions generated by a given = compiler. > + # > + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > + > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/Ma= nageabilityPkg/ManageabilityPkg.dsc > new file mode 100644 > index 0000000000..b3586afa07 > --- /dev/null > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -0,0 +1,39 @@ > +## @file > +# Manageabilty Package > +# This is the package provides edk2 drivers and libraries > +# those are related to the platform management. > +# > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + PLATFORM_NAME =3D ManageabilityPkg > + PLATFORM_GUID =3D 7A98123A-B194-40B6-A863-A52192F6D65= D > + PLATFORM_VERSION =3D 1.0 > + DSC_SPECIFICATION =3D 0x0001001e > + OUTPUT_DIRECTORY =3D Build/ManageabilityPkg > + SUPPORTED_ARCHITECTURES =3D IA32|X64|ARM|AARCH64|RISCV64 > + BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT > + SKUID_IDENTIFIER =3D DEFAULT > + > +[Packages] > + MinPlatformPkg/MinPlatformPkg.dec > + > +[PcdsFeatureFlag] > + # > + # MinPlatform common include currently required PCD > + # > + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE > + > +# > +# Include common libraries > +# > +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc > + > +!include Include/Dsc/Manageability.dsc > +