Re: [edk2-platforms][PATCH V1 02/17] Platform/Sgi: Add CPU container for SGI-575

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Pranav,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar


On 28/04/2021 01:35 PM, Pranav Madhu wrote:
> The SGI-575 platform includes two clusters with four single-thread CPUs.
> Add processor container devices for the two clusters on the SGI-575
> platform and move the existing processor devices into respective
> processor containers.
>
> Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
> ---
>   Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 99 +++++++++++---------
>   1 file changed, 54 insertions(+), 45 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl b/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl
> index fe0b92137bde..7390849e6231 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl
> +++ b/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl
> @@ -12,53 +12,62 @@
>   
>   DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI", EFI_ACPI_ARM_OEM_REVISION) {
>     Scope(_SB) {
> -
> -    Device(CP00) { // A75-0: Cluster 0, Cpu 0
> -      Name(_HID, "ACPI0007")
> -      Name(_UID, 0)
> -      Name(_STA, 0xF)
> -    }
> -
> -    Device(CP01) { // A75-0: Cluster 0, Cpu 1
> -      Name(_HID, "ACPI0007")
> -      Name(_UID, 1)
> -      Name(_STA, 0xF)
> -    }
> -
> -    Device(CP02) { // A75-0: Cluster 0, Cpu 2
> -      Name(_HID, "ACPI0007")
> -      Name(_UID, 2)
> -      Name(_STA, 0xF)
> -    }
> -
> -    Device(CP03) { // A75-0: Cluster 0, Cpu 3
> -      Name(_HID, "ACPI0007")
> -      Name(_UID, 3)
> -      Name(_STA, 0xF)
> -    }
> -
> -    Device(CP04) { // A75-0: Cluster 1, Cpu 0
> -      Name(_HID, "ACPI0007")
> -      Name(_UID, 4)
> -      Name(_STA, 0xF)
> -    }
> -
> -    Device(CP05) { // A75-0: Cluster 1, Cpu 1
> -      Name(_HID, "ACPI0007")
> -      Name(_UID, 5)
> -      Name(_STA, 0xF)
> -    }
> -
> -    Device(CP06) { // A75-0: Cluster 1, Cpu 2
> -      Name(_HID, "ACPI0007")
> -      Name(_UID, 6)
> -      Name(_STA, 0xF)
> +    Device (CLU0) {   // Cluster 0
> +      Name (_HID, "ACPI0010")
> +      Name (_UID, 0)
[SAMI] Please see my comment for the patch in your previous series at 
https://edk2.groups.io/g/devel/message/74863
[/SAMI]
> +
> +      Device (CP00) { // A75-0: Cluster 0, Cpu 0
> +        Name (_HID, "ACPI0007")
> +        Name (_UID, 0)
> +        Name (_STA, 0xF)
> +      }
> +
> +      Device (CP01) { // A75-0: Cluster 0, Cpu 1
> +        Name (_HID, "ACPI0007")
> +        Name (_UID, 1)
> +        Name (_STA, 0xF)
> +      }
> +
> +      Device (CP02) { // A75-0: Cluster 0, Cpu 2
> +        Name (_HID, "ACPI0007")
> +        Name (_UID, 2)
> +        Name (_STA, 0xF)
> +      }
> +
> +      Device (CP03) { // A75-0: Cluster 0, Cpu 3
> +        Name (_HID, "ACPI0007")
> +        Name (_UID, 3)
> +        Name (_STA, 0xF)
> +      }
>       }
>   
> -    Device(CP07) { // A75-0: Cluster 1, Cpu 3
> -      Name(_HID, "ACPI0007")
> -      Name(_UID, 7)
> -      Name(_STA, 0xF)
> +    Device (CLU1) {   // Cluster 1
> +      Name (_HID, "ACPI0010")
> +      Name (_UID, 1)
> +
> +      Device (CP04) { // A75-0: Cluster 1, Cpu 0
> +        Name (_HID, "ACPI0007")
> +        Name (_UID, 4)
> +        Name (_STA, 0xF)
> +      }
> +
> +      Device (CP05) { // A75-0: Cluster 1, Cpu 1
> +        Name (_HID, "ACPI0007")
> +        Name (_UID, 5)
> +        Name (_STA, 0xF)
> +      }
> +
> +      Device (CP06) { // A75-0: Cluster 1, Cpu 2
> +        Name (_HID, "ACPI0007")
> +        Name (_UID, 6)
> +        Name (_STA, 0xF)
> +      }
> +
> +      Device (CP07) { // A75-0: Cluster 1, Cpu 3
> +        Name (_HID, "ACPI0007")
> +        Name (_UID, 7)
> +        Name (_STA, 0xF)
> +      }
>       }
>   
>       // UART PL011