From: Paolo Bonzini <pbonzini@redhat.com>
To: Hao Wu <hao.a.wu@intel.com>, edk2-devel@lists.01.org
Cc: Eric Dong <eric.dong@intel.com>, Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH 5/6] MdeModulePkg/Crc32: Fix possible out of range left shift
Date: Tue, 19 Sep 2017 19:05:42 +0200 [thread overview]
Message-ID: <f6fe03c5-b13a-954c-fd8d-1cfde81e9d58@redhat.com> (raw)
In-Reply-To: <20170919114351.18448-6-hao.a.wu@intel.com>
On 19/09/2017 13:43, Hao Wu wrote:
> NewValue = 0;
> for (Index = 0; Index < 32; Index++) {
> - if ((Value & (1 << Index)) != 0) {
> - NewValue = NewValue | (1 << (31 - Index));
> + if ((Value & (((UINT32)1) << Index)) != 0) {
> + NewValue = NewValue | (((UINT32)1) << (31 - Index));
> }
Why not just "1u" instead of the cast?
Paolo
next prev parent reply other threads:[~2017-09-19 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 11:43 [PATCH 0/6] Resolve undefined behaviours in left shift OPs Hao Wu
2017-09-19 11:43 ` [PATCH 1/6] MdePkg/PrintLib: Fix possible negative value left shift Hao Wu
2017-09-19 11:43 ` [PATCH 2/6] MdeModulePkg/PrintLib: " Hao Wu
2017-09-19 11:43 ` [PATCH 3/6] MdeModulePkg/Tpl: Fix " Hao Wu
2017-09-19 17:02 ` Paolo Bonzini
2017-09-21 2:57 ` Zeng, Star
2017-09-21 3:06 ` Wu, Hao A
2017-09-19 11:43 ` [PATCH 4/6] MdeModulePkg/DxeNetLib: " Hao Wu
2017-09-19 17:04 ` Paolo Bonzini
2017-09-21 5:38 ` Wu, Jiaxin
2017-09-19 11:43 ` [PATCH 5/6] MdeModulePkg/Crc32: Fix possible out of range " Hao Wu
2017-09-19 17:05 ` Paolo Bonzini [this message]
2017-09-21 1:30 ` Wu, Hao A
2017-09-19 11:43 ` [PATCH 6/6] MdeModulePkg/AtaAtapiPassThru: " Hao Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6fe03c5-b13a-954c-fd8d-1cfde81e9d58@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox