From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 86EF221D046C7 for ; Tue, 19 Sep 2017 10:02:41 -0700 (PDT) Received: by mail-wr0-x231.google.com with SMTP id c23so194428wrg.9 for ; Tue, 19 Sep 2017 10:05:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SMtrOYORjyXabax/WfUi9897mDL7XDZHAK5JsU0Yk54=; b=Jgl8YL5HgrDlU5rt3F36eOQxTIBV70ZsP4Np8t6CG+pTqo+G1IXaBNwonISgsVRQ3N K5KT11ER/6OMH3Y8p4X6zEbVE3RCGxFY0+skmVTABMUHcTYFMB4/CTH8zCyjf0z1hUEO NWcia6SMYoO/of5chPJOqQ/5dw4TMbg4t89UY4U6YnobtnIln/jXoSjQxy7CfyQTi7Jr pwWD0amtjimb64DhqWK0+H3Fkz+jnefRtkoUpH1RaDwCLxdHBl3+2q/0hFC1mA9KkX7Q v4qy/tV4+IALmvYTYbv4vNzIy4++8wHgdrr04k7tqZgPKZk1Qt6VeZZOoMwaR4TEBshS YZ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SMtrOYORjyXabax/WfUi9897mDL7XDZHAK5JsU0Yk54=; b=cOwMgIvzgwOG3WvPX8BX4kVGcg6h+J0vEanEUVHNlT/F06nmlOV3lusBs4ypG6yFq1 0OtE22FJqoUnWG+x6oeQzYYipDAOzJtmf5PKLGOnAlm8X8FStdLEmV94bsNWEDTkHtDJ z7/eHeIUHpN5NAd2tyfN/SHLCb+BgEmCgVMazHmW859aQRgXddZbEvHiEsjSAiYydDVY FDalwwsL9pyinbRTBj9w+fhnZHd1bRsTZSPio4mYyB26gD7HQwCgMKeK0NnUHgh3qyvz jSevZoVHTMWi8QR0KZMGxrpqIVb/mKK9WAYp3SiZ33XlIMFDQ+reed/jXbF77S/F8PpU p4bw== X-Gm-Message-State: AHPjjUjIHC/8OOidhbFCP+TI8/kVzV9Nmj8zyr3N4i7foobAYAUC+i1m bG3vgrtH9LV0g2c0RN4quyc= X-Google-Smtp-Source: AOwi7QD1AUeiddz6w9wBUO3MLR0+BbnJLAFA8DRgss2xOEubdMQzPsKJ7b+CSgmfd/w0fDpwTIbTGg== X-Received: by 10.223.154.228 with SMTP id a91mr1946589wrc.246.1505840745076; Tue, 19 Sep 2017 10:05:45 -0700 (PDT) Received: from [192.168.10.165] (dynamic-adsl-78-12-246-117.clienti.tiscali.it. [78.12.246.117]) by smtp.googlemail.com with ESMTPSA id b89sm12649152wrd.42.2017.09.19.10.05.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 10:05:44 -0700 (PDT) Sender: Paolo Bonzini To: Hao Wu , edk2-devel@lists.01.org Cc: Eric Dong , Star Zeng References: <20170919114351.18448-1-hao.a.wu@intel.com> <20170919114351.18448-6-hao.a.wu@intel.com> From: Paolo Bonzini Message-ID: Date: Tue, 19 Sep 2017 19:05:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170919114351.18448-6-hao.a.wu@intel.com> Subject: Re: [PATCH 5/6] MdeModulePkg/Crc32: Fix possible out of range left shift X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 17:02:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 19/09/2017 13:43, Hao Wu wrote: > NewValue = 0; > for (Index = 0; Index < 32; Index++) { > - if ((Value & (1 << Index)) != 0) { > - NewValue = NewValue | (1 << (31 - Index)); > + if ((Value & (((UINT32)1) << Index)) != 0) { > + NewValue = NewValue | (((UINT32)1) << (31 - Index)); > } Why not just "1u" instead of the cast? Paolo