From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mx.groups.io with SMTP id smtpd.web10.7646.1647505601534126164 for ; Thu, 17 Mar 2022 01:26:42 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.187, mailfrom: xiewenyi2@huawei.com) Received: from kwepemi500024.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KK0VB6J5Jzcb8L; Thu, 17 Mar 2022 16:21:38 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by kwepemi500024.china.huawei.com (7.221.188.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 17 Mar 2022 16:26:38 +0800 Received: from [10.174.253.58] (10.174.253.58) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 17 Mar 2022 16:26:37 +0800 Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] ArmPlatformPkg: Fix ECC issues To: Sami Mujawar , "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "ardb+tianocore@kernel.org" CC: "songdongkuang@huawei.com" , nd References: <20220314092253.3518832-1-xiewenyi2@huawei.com> <20220314092253.3518832-2-xiewenyi2@huawei.com> From: "wenyi,xie" Message-ID: Date: Thu, 17 Mar 2022 16:26:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.253.58] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi, Sami Thank you for your reviewing, I have created a PR an here is the link. https://github.com/tianocore/edk2/pull/2619 Regards Wenyi On 2022/3/14 18:13, Sami Mujawar wrote: > Hi Wenyi, >=20 > Thank you for this patch. These changes look good to me. >=20 > Reviewed-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar >=20 > =EF=BB=BFOn 14/03/2022, 09:26, "devel@edk2.groups.io on behalf of wenyi,x= ie via groups.io" wrote: >=20 > Fix header files on #ifdef. >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel >=20 > Signed-off-by: Wenyi Xie > --- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlash.h | = 6 +++--- > ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h | = 6 +++--- > ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h | = 6 +++--- > ArmPlatformPkg/Include/Library/ArmPlatformLib.h | = 4 ++-- > ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h | = 6 +++--- > ArmPlatformPkg/Include/Library/PL011UartClockLib.h | = 4 ++-- > ArmPlatformPkg/Include/Library/PL011UartLib.h | = 4 ++-- > ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h | = 4 ++-- > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClock.h | = 4 ++-- > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.h | = 6 +++--- > ArmPlatformPkg/PrePeiCore/PrePeiCore.h | = 4 ++-- > ArmPlatformPkg/PrePi/PrePi.h | = 6 +++--- > 12 files changed, 30 insertions(+), 30 deletions(-) >=20 > diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlash.h b/ArmPlatf= ormPkg/Drivers/NorFlashDxe/NorFlash.h > index c83032e87d9c..c8b567d0c413 100644 > --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlash.h > +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlash.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef __NOR_FLASH_H__ > -#define __NOR_FLASH_H__ > +#ifndef NOR_FLASH_H_ > +#define NOR_FLASH_H_ >=20 > #include > #include > @@ -419,4 +419,4 @@ NorFlashVirtualNotifyEvent ( > IN VOID *Context > ); >=20 > -#endif /* __NOR_FLASH_H__ */ > +#endif // NOR_FLASH_H_ > diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h b/ArmPla= tformPkg/Drivers/PL061GpioDxe/PL061Gpio.h > index 42d87a16a3dd..3117f0abe2b3 100644 > --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h > +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef __PL061_GPIO_H__ > -#define __PL061_GPIO_H__ > +#ifndef PL061_GPIO_H_ > +#define PL061_GPIO_H_ >=20 > #include >=20 > @@ -39,4 +39,4 @@ > // All bits low except one bit high, native bit length > #define GPIO_PIN_MASK(Pin) (1UL << ((UINTN)(Pin))) >=20 > -#endif // __PL061_GPIO_H__ > +#endif // PL061_GPIO_H_ > diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h = b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h > index 597d6911fa10..f6a332fda247 100644 > --- a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h > +++ b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef __SP805_WATCHDOG_H__ > -#define __SP805_WATCHDOG_H__ > +#ifndef SP805_WATCHDOG_H_ > +#define SP805_WATCHDOG_H_ >=20 > // SP805 Watchdog Registers > #define SP805_WDOG_LOAD_REG ((UINT32)PcdGet32 (PcdSP805Watch= dogBase) + 0x000) > @@ -38,4 +38,4 @@ > #define SP805_WDOG_LOCK_IS_LOCKED 0x00000001 > #define SP805_WDOG_SPECIAL_UNLOCK_CODE 0x1ACCE551 >=20 > -#endif // __SP805_WATCHDOG_H__ > +#endif // SP805_WATCHDOG_H_ > diff --git a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h b/ArmPla= tformPkg/Include/Library/ArmPlatformLib.h > index cd87743eba52..cf056808fedf 100644 > --- a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h > +++ b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef _ARMPLATFORMLIB_H_ > -#define _ARMPLATFORMLIB_H_ > +#ifndef ARMPLATFORMLIB_H_ > +#define ARMPLATFORMLIB_H_ >=20 > // > // The package level header files this module uses > diff --git a/ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h b/A= rmPlatformPkg/Include/Library/NorFlashPlatformLib.h > index 6ef5b70e9948..37c0a69a6d07 100644 > --- a/ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h > +++ b/ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef _NORFLASHPLATFORMLIB_H_ > -#define _NORFLASHPLATFORMLIB_H_ > +#ifndef NORFLASHPLATFORMLIB_H_ > +#define NORFLASHPLATFORMLIB_H_ >=20 > typedef struct { > UINTN DeviceBaseAddress; // Start address of the Device B= ase Address (DBA) > @@ -27,4 +27,4 @@ NorFlashPlatformGetDevices ( > OUT UINT32 *Count > ); >=20 > -#endif /* _NORFLASHPLATFORMLIB_H_ */ > +#endif // NORFLASHPLATFORMLIB_H_ > diff --git a/ArmPlatformPkg/Include/Library/PL011UartClockLib.h b/Arm= PlatformPkg/Include/Library/PL011UartClockLib.h > index 5814d960a663..0e279dda62ce 100644 > --- a/ArmPlatformPkg/Include/Library/PL011UartClockLib.h > +++ b/ArmPlatformPkg/Include/Library/PL011UartClockLib.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef __PL011UARTCLOCKLIB_H__ > -#define __PL011UARTCLOCKLIB_H__ > +#ifndef PL011UARTCLOCKLIB_H_ > +#define PL011UARTCLOCKLIB_H_ >=20 > /** >=20 > diff --git a/ArmPlatformPkg/Include/Library/PL011UartLib.h b/ArmPlatf= ormPkg/Include/Library/PL011UartLib.h > index 964142ef64a3..18638ce9ef7d 100644 > --- a/ArmPlatformPkg/Include/Library/PL011UartLib.h > +++ b/ArmPlatformPkg/Include/Library/PL011UartLib.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef __PL011_UART_LIB_H__ > -#define __PL011_UART_LIB_H__ > +#ifndef PL011_UART_LIB_H_ > +#define PL011_UART_LIB_H_ >=20 > #include >=20 > diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h b/ArmPla= tformPkg/Library/PL011UartLib/PL011Uart.h > index 8433a81aeac4..f5a5fa193df2 100644 > --- a/ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h > +++ b/ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef __PL011_UART_H__ > -#define __PL011_UART_H__ > +#ifndef PL011_UART_H_ > +#define PL011_UART_H_ >=20 > #define PL011_VARIANT_ZTE 1 >=20 > diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTi= meClock.h b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClock= .h > index 00b3fc99ac14..ebcb8a1e9906 100644 > --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClock= .h > +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClock= .h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef __PL031_REAL_TIME_CLOCK_H__ > -#define __PL031_REAL_TIME_CLOCK_H__ > +#ifndef PL031_REAL_TIME_CLOCK_H_ > +#define PL031_REAL_TIME_CLOCK_H_ >=20 > // PL031 Registers > #define PL031_RTC_DR_DATA_REGISTER 0x000 > diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.h b/ArmPlatform= Pkg/Library/PL111Lcd/PL111Lcd.h > index 0d4fe387c54c..d4f9dd82de83 100644 > --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.h > +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.h > @@ -5,8 +5,8 @@ >=20 > **/ >=20 > -#ifndef _PL111LCD_H__ > -#define _PL111LCD_H__ > +#ifndef PL111LCD_H_ > +#define PL111LCD_H_ >=20 > /*******************************************************************= *** > * > @@ -140,4 +140,4 @@ > #define PL111_BIT_MASK_LEE 0x00010000 > #define PL111_BIT_MASK_LED 0x0000007F >=20 > -#endif /* _PL111LCD_H__ */ > +#endif // PL111LCD_H_ > diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h b/ArmPlatformPkg/= PrePeiCore/PrePeiCore.h > index 0345dd7bdd2a..acc145696d28 100644 > --- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h > +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h > @@ -7,8 +7,8 @@ >=20 > **/ >=20 > -#ifndef __PREPEICORE_H_ > -#define __PREPEICORE_H_ > +#ifndef PREPEICORE_H_ > +#define PREPEICORE_H_ >=20 > #include > #include > diff --git a/ArmPlatformPkg/PrePi/PrePi.h b/ArmPlatformPkg/PrePi/PreP= i.h > index 6074a22108d2..b27148cf5d03 100644 > --- a/ArmPlatformPkg/PrePi/PrePi.h > +++ b/ArmPlatformPkg/PrePi/PrePi.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef _PREPI_H_ > -#define _PREPI_H_ > +#ifndef PREPI_H_ > +#define PREPI_H_ >=20 > #include >=20 > @@ -85,4 +85,4 @@ ProcessLibraryConstructorList ( > VOID > ); >=20 > -#endif /* _PREPI_H_ */ > +#endif // PREPI_H_ > --=20 > 2.20.1.windows.1 >=20 >=20 >=20 > =20 >=20 >=20 >=20