From: Laszlo Ersek <lersek@redhat.com>
To: Jiewen Yao <jiewen.yao@intel.com>, edk2-devel@ml01.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Feng Tian <feng.tian@intel.com>, Jeff Fan <jeff.fan@intel.com>,
Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH V2 0/6] Enable SMM page level protection.
Date: Fri, 4 Nov 2016 23:40:01 +0100 [thread overview]
Message-ID: <f72cde96-dcef-f99e-c5d9-4fd7c6d81dcd@redhat.com> (raw)
In-Reply-To: <1478251854-14660-1-git-send-email-jiewen.yao@intel.com>
On 11/04/16 10:30, Jiewen Yao wrote:
> ==== below is V2 description ====
> 1) PiSmmCpu: resolve OVMF multiple processors boot hang issue.
> 2) PiSmmCpu: Add debug info on StartupAp() fails.
> 3) PiSmmCpu: Add ASSERT for AllocatePages().
> 4) PiSmmCpu: Add protection detail in commit message.
> 5) UefiCpuPkg.dsc: Add page table footprint info in commit message.
Jiewen, can you please push this series to a new branch in your repo?
I see a branch called "SmmProtection_V2", but it seems to end with an
incomplete patch (26f482d8b611d0fcb07d3ffbf3f4468fd249767b, subject
"pismmcpu"), so I figured I'd ask explicitly.
Thanks
Laszlo
> ==== below is V1 description ====
> This series patch enables SMM page level protection.
> Features are:
> 1) PiSmmCore reports SMM PE image code/data information
> in EdkiiPiSmmMemoryAttributeTable, if the SMM image is page aligned.
> 2) PiSmmCpu consumes EdkiiPiSmmMemoryAttributeTable
> and set XD for data page and RO for code page.
> 3) PiSmmCpu enables Static Paging for X64 according to
> PcdCpuSmmStaticPageTable. If it is true, 1G paging for above 4G
> is used as long as it is supported.
> 4) PiSmmCpu sets importance data structure to be read only,
> such as Gdt, Idt, SmmEntrypoint, and PageTable itself.
>
> tested platform:
> 1) Intel internal platform (X64).
> 2) EDKII Quark IA32
> 3) EDKII Vlv2 X64
> 4) EDKII OVMF IA32 and IA32X64. (with -smp 8)
>
> Cc: Jeff Fan <jeff.fan@intel.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
>
> Jiewen Yao (6):
> MdeModulePkg/Include: Add PiSmmMemoryAttributesTable.h
> MdeModulePkg/dec: Add gEdkiiPiSmmMemoryAttributesTableGuid.
> MdeModulePkg/PiSmmCore: Add MemoryAttributes support.
> UefiCpuPkg/dec: Add PcdCpuSmmStaticPageTable.
> UefiCpuPkg/PiSmmCpuDxeSmm: Add paging protection.
> QuarkPlatformPkg/dsc: enable Smm paging protection.
>
> MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 66 +
> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 1509 ++++++++++++++++++++
> MdeModulePkg/Core/PiSmmCore/Page.c | 775 +++++++++-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 40 +
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 91 ++
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 2 +
> MdeModulePkg/Core/PiSmmCore/Pool.c | 16 +
> MdeModulePkg/Include/Guid/PiSmmMemoryAttributesTable.h | 51 +
> MdeModulePkg/MdeModulePkg.dec | 3 +
> QuarkPlatformPkg/Quark.dsc | 6 +
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 71 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.S | 67 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.asm | 68 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 70 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.S | 226 +--
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.asm | 36 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.nasm | 36 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 37 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmProfileArch.c | 4 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 127 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 142 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 156 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 5 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 871 +++++++++++
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 39 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h | 15 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 274 +++-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S | 51 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm | 54 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 61 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.S | 250 +---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.asm | 35 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.nasm | 31 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 30 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmProfileArch.c | 7 +-
> UefiCpuPkg/UefiCpuPkg.dec | 8 +
> 36 files changed, 4529 insertions(+), 801 deletions(-)
> create mode 100644 MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> create mode 100644 MdeModulePkg/Include/Guid/PiSmmMemoryAttributesTable.h
> create mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
>
next prev parent reply other threads:[~2016-11-04 22:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 9:30 [PATCH V2 0/6] Enable SMM page level protection Jiewen Yao
2016-11-04 9:30 ` [PATCH V2 1/6] MdeModulePkg/Include: Add PiSmmMemoryAttributesTable.h Jiewen Yao
2016-11-04 9:30 ` [PATCH V2 2/6] MdeModulePkg/dec: Add gEdkiiPiSmmMemoryAttributesTableGuid Jiewen Yao
2016-11-04 9:30 ` [PATCH V2 3/6] MdeModulePkg/PiSmmCore: Add MemoryAttributes support Jiewen Yao
2016-11-04 9:30 ` [PATCH V2 4/6] UefiCpuPkg/dec: Add PcdCpuSmmStaticPageTable Jiewen Yao
2016-11-04 9:30 ` [PATCH V2 5/6] UefiCpuPkg/PiSmmCpuDxeSmm: Add paging protection Jiewen Yao
2016-11-04 9:30 ` [PATCH V2 6/6] QuarkPlatformPkg/dsc: enable Smm " Jiewen Yao
2016-11-04 22:40 ` Laszlo Ersek [this message]
2016-11-04 22:46 ` [PATCH V2 0/6] Enable SMM page level protection Yao, Jiewen
2016-11-04 23:08 ` Laszlo Ersek
2016-11-08 1:22 ` Laszlo Ersek
2016-11-08 12:59 ` Yao, Jiewen
2016-11-08 13:22 ` Laszlo Ersek
2016-11-08 13:41 ` Yao, Jiewen
2016-11-09 6:25 ` Yao, Jiewen
2016-11-09 11:30 ` Paolo Bonzini
2016-11-09 15:01 ` Yao, Jiewen
2016-11-09 15:54 ` Paolo Bonzini
2016-11-09 16:06 ` Paolo Bonzini
2016-11-09 22:28 ` Laszlo Ersek
2016-11-09 22:59 ` Paolo Bonzini
2016-11-09 23:27 ` Laszlo Ersek
2016-11-10 1:13 ` Yao, Jiewen
2016-11-10 6:30 ` Fan, Jeff
2016-11-10 0:49 ` Yao, Jiewen
2016-11-10 0:50 ` Yao, Jiewen
2016-11-10 1:02 ` Fan, Jeff
2016-11-09 20:46 ` Laszlo Ersek
2016-11-10 10:41 ` Yao, Jiewen
2016-11-10 12:01 ` Laszlo Ersek
2016-11-10 14:48 ` Yao, Jiewen
2016-11-10 14:53 ` Paolo Bonzini
2016-11-10 16:22 ` Laszlo Ersek
2016-11-10 16:39 ` Paolo Bonzini
2016-11-10 16:25 ` Laszlo Ersek
2016-11-10 12:27 ` Paolo Bonzini
2016-11-09 11:23 ` Paolo Bonzini
2016-11-09 15:16 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f72cde96-dcef-f99e-c5d9-4fd7c6d81dcd@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox