From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 9DD49803B0
 for <edk2-devel@ml01.01.org>; Fri, 10 Mar 2017 11:14:53 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com
 [10.5.11.28])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 2DABC85376;
 Fri, 10 Mar 2017 19:14:54 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-26.phx2.redhat.com
 [10.3.117.26])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 32195700;
 Fri, 10 Mar 2017 19:14:52 +0000 (UTC)
To: Jordan Justen <jordan.l.justen@intel.com>,
 edk2-devel-01 <edk2-devel@ml01.01.org>
References: <20170223014814.10937-1-lersek@redhat.com>
 <20170223014814.10937-8-lersek@redhat.com>
 <148913988336.26490.6901368604411039649@jljusten-skl>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <f743e007-a74f-1b58-5356-275de2abbf07@redhat.com>
Date: Fri, 10 Mar 2017 20:14:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <148913988336.26490.6901368604411039649@jljusten-skl>
X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.25]); Fri, 10 Mar 2017 19:14:54 +0000 (UTC)
Subject: Re: [PATCH 07/12] OvmfPkg/QemuFwCfgS3Lib: add boot script opcode generation APIs to libclass
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Mar 2017 19:14:53 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 03/10/17 10:58, Jordan Justen wrote:
> On 2017-02-22 17:48:09, Laszlo Ersek wrote:
>> +EFIAPI
>> +RETURN_STATUS
>> +QemuFwCfgS3TransferOwnership (
>> +  IN     FW_CFG_BOOT_SCRIPT_APPEND_FUNCTION *Append,
>> +  IN OUT VOID                               *Context,          OPTIONAL
>> +  IN     UINTN                              ScratchBufferSize
>> +  );
> 
> I think this might be better named something like
> QemuFwCfgS3CallWhenBootScriptReady. (Wow, that is verbose. Maybe you
> have a better idea.)

No, I like your suggestion.

Thanks
Laszlo