From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5FD5B780091 for ; Mon, 19 Feb 2024 20:06:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cKR272TwumlyIhFkDMOmi9Bqj+M57p2+2ysZ8w4Nito=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708373209; v=1; b=f+wvm50g025+pqSVdg+D18xONsh5hHym1ppASYQBsGA2dQNbAw2yGQdC3G2QTaDjyG6jfa+O Hy2oPa2kj+1MQSQbxZkEV37Hk9B66fqXTQQE4RXhOCGifk7RIxvAC8T4OvRfJJoMm8fGGHnF9Jw IwhNRYtQ0VBKPebZWuJhovMM= X-Received: by 127.0.0.2 with SMTP id 0948YY7687511xdRmqk7yHe3; Mon, 19 Feb 2024 12:06:49 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.4035.1708373208262912783 for ; Mon, 19 Feb 2024 12:06:48 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-194-x3v_z8iUNd2YUiD_DHwkLA-1; Mon, 19 Feb 2024 15:06:43 -0500 X-MC-Unique: x3v_z8iUNd2YUiD_DHwkLA-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B40A5381CB67; Mon, 19 Feb 2024 20:06:42 +0000 (UTC) X-Received: from [10.39.194.20] (unknown [10.39.194.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74AE140C95AD; Mon, 19 Feb 2024 20:06:41 +0000 (UTC) Message-ID: Date: Mon, 19 Feb 2024 21:06:40 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 12/12] OvmfPkg: only add shell to FV in case secure boot is disabled To: Gerd Hoffmann Cc: devel@edk2.groups.io, Jiewen Yao , Min Xu , Tom Lendacky , Oliver Steffen , Erdem Aktas , Ard Biesheuvel , Michael Roth References: <20240215102503.273275-1-kraxel@redhat.com> <20240215102503.273275-13-kraxel@redhat.com> <781606c6-b15e-525b-7deb-364af8c1fc9c@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mUjQq6DtOXqjvyZUp0xLypA7x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=f+wvm50g; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/19/24 11:21, Gerd Hoffmann wrote: >>> -!if $(BUILD_SHELL) =3D=3D TRUE >>> +!if $(BUILD_SHELL) =3D=3D TRUE && $(SECURE_BOOT_ENABLE) =3D=3D FALSE >>> >>> !if $(TOOL_CHAIN_TAG) !=3D "XCODE5" >>> !if $(NETWORK_ENABLE) =3D=3D TRUE >> >> This does the job: >> >> Reviewed-by: Laszlo Ersek >> >> An alternative could be (perhaps informing the user better): >> >> !if $(BUILD_SHELL) =3D=3D TRUE >> !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE >> !error BUILD_SHELL and SECURE_BOOT_ENABLE conflict >> !endif >> ... >> !endif >=20 > That would break CI. >=20 > Patch 11/12 depends on the shell being built even if not included in the > firmware image, so it can be copied to the virtual drive used by the > qemu test. Ah, understood. We don't conditionalize in the DSC files, only in the FDFs. Laszlo >=20 >> A repost might be worth your while either way, because some of the >> patches are identical to their first versions, and Jiewen's v1 Acked-by, >> from [1], is missing from the unchanged (or trivially rebased) patches >> in v2. >=20 > Oops, right, went over all individual patches updating them, then forgot > the Jiewen's ack for the whole series. >=20 > take care, > Gerd >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115597): https://edk2.groups.io/g/devel/message/115597 Mute This Topic: https://groups.io/mt/104370218/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-