From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.65; helo=mail-wr1-f65.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8931A21197374 for ; Mon, 14 Jan 2019 05:36:24 -0800 (PST) Received: by mail-wr1-f65.google.com with SMTP id t27so22869141wra.6 for ; Mon, 14 Jan 2019 05:36:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bRP9o9kSc5RK2LFv7vDhCzdD+mQqshs/JwsOQRGoFxA=; b=nPu8ZdooXbsgWHA/18TLZtEAIzLs44xZfMX4p2N9yLZE06PWbmoOIrz0mH7ocrObMy ii4rGE2g+mqHSDydGWDAP+xZDwX9TJCzVqeOi4Yjd0rehu/hr7Z8A7evk/CbuZ8m9M4a 75j2rVEPQEfU5lzZ6GOXvcFdog2HT1+dfvvNP5UGKXozc8uNg/fIJuXO9Sobc2rv/NEc ZS8LkEF16XLoGb5niSbNKcxZkmkM5YQ0IDk0HV22+YxKZ+wzDp48T+oqgxDdL4ANzUER K/HOffYt3QMmcoxNA9tCnVMsGgEwYqnADuPoe+g/NcgMvVnIEb5s4oJUHL3jgQbsQPZL fHFg== X-Gm-Message-State: AJcUukfdanKKIYtsaycizD3udIoIrpE9aprIcJ6XndNqZFHbS3DbvTKa KC+8uPdSritdMPrHwRHQ9qM3rbIna3A= X-Google-Smtp-Source: ALg8bN4SqbRmWJqESoouamXYrFhCFW42OhliDdEGj8FHT+7ZMFvKfD9V8/hb6dOoTGNtUWlI7wNG2Q== X-Received: by 2002:adf:ea81:: with SMTP id s1mr23626108wrm.309.1547472982413; Mon, 14 Jan 2019 05:36:22 -0800 (PST) Received: from [192.168.1.33] (110.red-83-51-161.dynamicip.rima-tde.net. [83.51.161.110]) by smtp.gmail.com with ESMTPSA id a12sm67088611wrm.45.2019.01.14.05.36.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Jan 2019 05:36:21 -0800 (PST) To: "Gao, Liming" , Leif Lindholm , Ard Biesheuvel Cc: "edk2-devel@lists.01.org" References: <20190107065541.1854-1-ard.biesheuvel@linaro.org> <20190114114138.ttqlr5mfzh465pic@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B156E@SHSMSX152.ccr.corp.intel.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Mon, 14 Jan 2019 14:36:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B156E@SHSMSX152.ccr.corp.intel.com> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 13:36:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 1/14/19 2:18 PM, Gao, Liming wrote: > Ard: > Could you consider the suggestion from https://lists.01.org/pipermail/edk2-devel/2019-January/034698.html? There might be a special case for Aarch64, but I'm not seeing it. > > Thanks > Liming >> -----Original Message----- >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >> Sent: Monday, January 14, 2019 7:42 PM >> To: Ard Biesheuvel >> Cc: edk2-devel@lists.01.org; Gao, Liming ; Feng, Bob C >> Subject: Re: [PATCH] BaseTools/tools_def ARM GCC5: disable LTO for ASLC invocations >> >> On Mon, Jan 07, 2019 at 07:55:41AM +0100, Ard Biesheuvel wrote: >>> GCC for 32-bit ARM chokes on .aslc files when running with LTO >>> enabled. Since LTO has no benefit whatsoever here, just disable >>> it. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >> >> Looks sensible. >> Reviewed-by: Leif Lindholm >> >>> --- >>> BaseTools/Conf/tools_def.template | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template >>> index f7eb87af14c2..e68cfd9a4997 100755 >>> --- a/BaseTools/Conf/tools_def.template >>> +++ b/BaseTools/Conf/tools_def.template >>> @@ -5145,7 +5145,7 @@ RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS) -flto -Os >>> *_GCC5_ARM_RC_PATH = ENV(GCC5_ARM_PREFIX)objcopy >>> >>> *_GCC5_ARM_ARCHCC_FLAGS = -mthumb >>> -*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) >>> +*_GCC5_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -fno-lto >>> *_GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC5_ARM_ASLDLINK_FLAGS) >>> *_GCC5_ARM_ASM_FLAGS = DEF(GCC5_ARM_ASM_FLAGS) >>> *_GCC5_ARM_DLINK2_FLAGS = DEF(GCC5_ARM_DLINK2_FLAGS) >>> -- >>> 2.20.1 >>> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >