From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4B8B674003B for ; Fri, 2 Feb 2024 14:56:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5tGIme3lojY7uOm1Prw/aa+uG9qyIdtRD2s5FbaNsaI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706885774; v=1; b=t8VUGpqtJe50cfxryXXSekGWvHfZ4TqqDrNekrL80+DV2pr2yJ9GSBBPjNZGKJzgddOKwF40 QJKm3XDXrYoJesc4kOvva+OOSL6Y3eCxuZG+xFl85iDPeWzlCNT73KDsGzZbcqVRwYCfe5W61IH fuVYkZoPDaj/sG9ez1zD0hm0= X-Received: by 127.0.0.2 with SMTP id MhhpYY7687511xVToHhsnMOA; Fri, 02 Feb 2024 06:56:14 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.24529.1706885774161289351 for ; Fri, 02 Feb 2024 06:56:14 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-iErKoH-IOuWXn-BUknGfew-1; Fri, 02 Feb 2024 09:56:10 -0500 X-MC-Unique: iErKoH-IOuWXn-BUknGfew-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4FF65185A782; Fri, 2 Feb 2024 14:56:09 +0000 (UTC) X-Received: from [10.39.192.34] (unknown [10.39.192.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 25BA71C060AF; Fri, 2 Feb 2024 14:56:06 +0000 (UTC) Message-ID: Date: Fri, 2 Feb 2024 15:56:00 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v1 00/19] Add LoongArch helper functions and defines To: devel@edk2.groups.io, lichao@loongson.cn Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Leif Lindholm , Ard Biesheuvel , Abner Chang , Sami Mujawar , Gerd Hoffmann , Ray Ni , Rahul Kumar , Jiewen Yao , Sunil V L , Andrei Warkentin , Dongyan Qian References: <20240202022637.2444159-1-lichao@loongson.cn> From: "Laszlo Ersek" In-Reply-To: <20240202022637.2444159-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: znA1SRxnDcvMLrG8WQ0HFtJJx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=t8VUGpqt; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/2/24 03:26, Chao Li wrote: > This series is part 1 of enabling LoongArch64 virtual machine. >=20 > Added LoongArch helper functions and defines in MdePkg, added LoongArch > CPU IO width in EmbeddedPkg, moved some libraries and PCDs from > ArmVirtPkg to OvmfPkg for easiser use by other ARCHs, added a new CPU IO2 > driver named CpuMmio2Dxe in UefiCpuPkg, for non-IO port implement CPUs. I think this series is good to go; fully reviewed, so we can merge it during (not just before) the soft feature freeze period. Ray, can you confirm you are OK with this version? You made some comments under v8 that make me a bit uncertain. Laszlo >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Dongyan Qian >=20 > Chao Li (19): > MdePkg: Add the header file named Csr.h for LoongArch64 > MdePkg: Add LoongArch64 FPU function set into BaseCpuLib > MdePkg: Add LoongArch64 exception function set into BaseLib > MdePkg: Add LoongArch64 local interrupt function set into BaseLib > MdePkg: Add LoongArch Cpucfg function > MdePkg: Add read stable counter operation for LoongArch > MdePkg: Add CSR operation for LoongArch > MdePkg: Add IOCSR operation for LoongArch > MdePkg: Add a new library named PeiServicesTablePointerLibKs0 > MdePkg: Add some comments for LoongArch exceptions > EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64 > ArmVirtPkg: Move PCD of FDT base address and FDT padding to OvmfPkg > UefiCpuPkg: Add a new CPU IO 2 driver named CpuMmio2Dxe > ArmVirtPkg: Enable CpuMmio2Dxe > OvmfPkg/RiscVVirt: Enable CpuMmio2Dxe > OvmfPkg/RiscVVirt: Remove PciCpuIo2Dxe from RiscVVirt > ArmVirtPkg: Move the FdtSerialPortAddressLib to OvmfPkg > ArmVirtPkg: Move two PCD variables into OvmfPkg > ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg >=20 > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > ArmVirtPkg/ArmVirtCloudHv.dsc | 4 +- > ArmVirtPkg/ArmVirtCloudHv.fdf | 2 +- > ArmVirtPkg/ArmVirtKvmTool.dsc | 4 +- > ArmVirtPkg/ArmVirtKvmTool.fdf | 2 +- > ArmVirtPkg/ArmVirtPkg.ci.yaml | 1 - > ArmVirtPkg/ArmVirtPkg.dec | 28 - > ArmVirtPkg/ArmVirtQemu.dsc | 8 +- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 2 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 8 +- > ArmVirtPkg/ArmVirtXen.dsc | 2 +- > .../ArmVirtPsciResetSystemPeiLib.inf | 3 +- > .../CloudHvVirtMemInfoPeiLib.inf | 3 +- > .../DebugLibFdtPL011UartFlash.inf | 3 +- > .../EarlyFdt16550SerialPortHookLib.inf | 3 +- > .../EarlyFdtPL011SerialPortLib.inf | 3 +- > .../KvmtoolPlatformPeiLib.inf | 5 +- > .../Library/PlatformPeiLib/PlatformPeiLib.inf | 10 +- > .../QemuVirtMemInfoPeiLib.inf | 3 +- > .../PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 3 +- > EmbeddedPkg/EmbeddedPkg.dec | 3 + > MdePkg/Include/Library/BaseLib.h | 221 +++++++ > MdePkg/Include/Library/CpuLib.h | 43 +- > .../Library/PeiServicesTablePointerLib.h | 9 +- > MdePkg/Include/Protocol/DebugSupport.h | 14 + > MdePkg/Include/Register/LoongArch64/Cpucfg.h | 565 ++++++++++++++++++ > MdePkg/Include/Register/LoongArch64/Csr.h | 263 ++++++++ > MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 7 +- > .../Library/BaseCpuLib/LoongArch/DisableFpu.S | 17 + > .../Library/BaseCpuLib/LoongArch/EnableFpu.S | 17 + > .../BaseCpuLib/LoongArch/InitializeFpu.S | 51 ++ > MdePkg/Library/BaseLib/BaseLib.inf | 6 + > MdePkg/Library/BaseLib/LoongArch64/AsmCsr.S | 422 +++++++++++++ > MdePkg/Library/BaseLib/LoongArch64/Cpucfg.S | 26 + > MdePkg/Library/BaseLib/LoongArch64/Csr.c | 81 +++ > .../BaseLib/LoongArch64/DisableInterrupts.S | 22 +- > .../BaseLib/LoongArch64/EnableInterrupts.S | 22 +- > .../BaseLib/LoongArch64/ExceptionBase.S | 41 ++ > MdePkg/Library/BaseLib/LoongArch64/IoCsr.S | 120 ++++ > .../BaseLib/LoongArch64/ReadStableCounter.S | 24 + > .../PeiServicesTablePointer.c | 87 +++ > .../PeiServicesTablePointerLibKs0.inf | 37 ++ > .../PeiServicesTablePointerLibKs0.uni | 20 + > MdePkg/MdePkg.ci.yaml | 3 +- > MdePkg/MdePkg.dsc | 3 + > .../Include/Library/FdtSerialPortAddressLib.h | 0 > .../FdtSerialPortAddressLib.c | 0 > .../FdtSerialPortAddressLib.inf | 2 +- > .../PlatformBootManagerLibLight}/PlatformBm.c | 0 > .../PlatformBootManagerLibLight}/PlatformBm.h | 0 > .../PlatformBootManagerLib.inf | 5 +- > .../PlatformBootManagerLibLight}/QemuKernel.c | 0 > OvmfPkg/OvmfPkg.dec | 32 + > OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 2 +- > OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 2 +- > .../CpuMmio2Dxe/CpuMmio2Dxe.c | 8 +- > .../CpuMmio2Dxe/CpuMmio2Dxe.inf | 16 +- > UefiCpuPkg/CpuMmio2Dxe/CpuMmio2Dxe.uni | 18 + > UefiCpuPkg/UefiCpuPkg.dsc | 1 + > 59 files changed, 2209 insertions(+), 100 deletions(-) > create mode 100644 MdePkg/Include/Register/LoongArch64/Cpucfg.h > create mode 100644 MdePkg/Include/Register/LoongArch64/Csr.h > create mode 100644 MdePkg/Library/BaseCpuLib/LoongArch/DisableFpu.S > create mode 100644 MdePkg/Library/BaseCpuLib/LoongArch/EnableFpu.S > create mode 100644 MdePkg/Library/BaseCpuLib/LoongArch/InitializeFpu.S > create mode 100644 MdePkg/Library/BaseLib/LoongArch64/AsmCsr.S > create mode 100644 MdePkg/Library/BaseLib/LoongArch64/Cpucfg.S > create mode 100644 MdePkg/Library/BaseLib/LoongArch64/Csr.c > create mode 100644 MdePkg/Library/BaseLib/LoongArch64/ExceptionBase.S > create mode 100644 MdePkg/Library/BaseLib/LoongArch64/IoCsr.S > create mode 100644 MdePkg/Library/BaseLib/LoongArch64/ReadStableCounter.= S > create mode 100644 MdePkg/Library/PeiServicesTablePointerLibKs0/PeiServi= cesTablePointer.c > create mode 100644 MdePkg/Library/PeiServicesTablePointerLibKs0/PeiServi= cesTablePointerLibKs0.inf > create mode 100644 MdePkg/Library/PeiServicesTablePointerLibKs0/PeiServi= cesTablePointerLibKs0.uni > rename {ArmVirtPkg =3D> OvmfPkg}/Include/Library/FdtSerialPortAddressLib= .h (100%) > rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSeri= alPortAddressLib.c (100%) > rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSeri= alPortAddressLib.inf (90%) > rename {ArmVirtPkg/Library/PlatformBootManagerLib =3D> OvmfPkg/Library/P= latformBootManagerLibLight}/PlatformBm.c (100%) > rename {ArmVirtPkg/Library/PlatformBootManagerLib =3D> OvmfPkg/Library/P= latformBootManagerLibLight}/PlatformBm.h (100%) > rename {ArmVirtPkg/Library/PlatformBootManagerLib =3D> OvmfPkg/Library/P= latformBootManagerLibLight}/PlatformBootManagerLib.inf (89%) > rename {ArmVirtPkg/Library/PlatformBootManagerLib =3D> OvmfPkg/Library/P= latformBootManagerLibLight}/QemuKernel.c (100%) > rename OvmfPkg/RiscVVirt/PciCpuIo2Dxe/PciCpuIo2Dxe.c =3D> UefiCpuPkg/Cpu= Mmio2Dxe/CpuMmio2Dxe.c (96%) > rename OvmfPkg/RiscVVirt/PciCpuIo2Dxe/PciCpuIo2Dxe.inf =3D> UefiCpuPkg/C= puMmio2Dxe/CpuMmio2Dxe.inf (61%) > create mode 100644 UefiCpuPkg/CpuMmio2Dxe/CpuMmio2Dxe.uni >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115058): https://edk2.groups.io/g/devel/message/115058 Mute This Topic: https://groups.io/mt/104112112/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-