From: "Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>
To: devel@edk2.groups.io, quic_llindhol@quicinc.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Graeme Gregory <graeme@xora.org.uk>
Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 3/3] Platform/SbsaQemu: handle systems without GIC ITS
Date: Mon, 21 Aug 2023 22:18:54 +0200 [thread overview]
Message-ID: <f7951320-85b4-7c63-a72c-399a5936df3b@linaro.org> (raw)
In-Reply-To: <ZOOsiVxatyZbBJZZ@qc-i7.hemma.eciton.net>
W dniu 21.08.2023 o 20:27, Leif Lindholm pisze:
> Hmm, wait. Patch 1/3 adds Iort.aslc and patch 3/3 deletes it. I know
> 1/3 is Shashi's original implementation and 3/3 is heavily based on
> that (if rewritten), but there's no point in merging the churn.
I kind of wanted to get review of both parts. First one (written by
Shashi long time ago) and rest (written by me in last months). Whole
testing was "does Linux boots and shows me complex PCIe structure".
Can squash into one, no problem.
> What does this set look like as a single squashed patch? (I think
> doing that would also address all previous comments I made.)
22:16 marcin@applejack:edk2-platforms$ git diff --stat origin/master
Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 4 +
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 4 +
Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 +
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 2 +
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf | 1 +
Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 11 ++
Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuSmc.h | 1 +
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 208 +++++++++++++++++++-
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 10 +
9 files changed, 241 insertions(+), 1 deletion(-)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107936): https://edk2.groups.io/g/devel/message/107936
Mute This Topic: https://groups.io/mt/100874755/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-08-21 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 15:07 [edk2-devel] [PATCH edk2-platforms v4 0/3] Platform/QemuSbsa: add GIC ITS Marcin Juszkiewicz
2023-08-21 15:07 ` [edk2-devel] [PATCH edk2-platforms v4 1/3] Platform/SbsaQemu: add GIC ITS support Marcin Juszkiewicz
2023-08-21 17:59 ` Leif Lindholm
2023-08-21 15:07 ` [edk2-devel] [PATCH edk2-platforms v4 2/3] Platform/QemuSbsa: add dynamic PcdSmmuBase Marcin Juszkiewicz
2023-08-21 18:06 ` Leif Lindholm
2023-08-21 15:07 ` [edk2-devel] [PATCH edk2-platforms v4 3/3] Platform/SbsaQemu: handle systems without GIC ITS Marcin Juszkiewicz
2023-08-21 18:27 ` Leif Lindholm
2023-08-21 20:18 ` Marcin Juszkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7951320-85b4-7c63-a72c-399a5936df3b@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox