From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A78BF74003C for ; Mon, 21 Aug 2023 20:19:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fkaUWLs7Y6YTwhz/AFxP0171HfH+W6xUDSf2lcGX2K8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692649139; v=1; b=S3W42IpzAiCxqEX4+l+x6tojHjh0RSeV4qfUl0PlzwaRN/XdR+ZBjjwLqjOQqAgFuFBPZO/j gysKk+oluSH4CagjfRzSE6+6s5UHdkUpDKP76x9/LhV6wGu32arpCbdpcs28nDkucx0fW5y8WIt MElwjCI0URhviN3Yr2c9YXAI= X-Received: by 127.0.0.2 with SMTP id Q74PYY7687511x98HBaPub6E; Mon, 21 Aug 2023 13:18:59 -0700 X-Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mx.groups.io with SMTP id smtpd.web11.1241.1692649138228791954 for ; Mon, 21 Aug 2023 13:18:58 -0700 X-Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-50043cf2e29so3185419e87.2 for ; Mon, 21 Aug 2023 13:18:57 -0700 (PDT) X-Gm-Message-State: gM0VuKB2oH943GGHtxYsnDDCx7686176AA= X-Google-Smtp-Source: AGHT+IF4JWnRrHAhzxjHZDmG6DFS+W9eEUi08kPCgW5+OLJ7kppJ7OzMyYBObBRM6as3Rw687VHYcA== X-Received: by 2002:a05:6512:318d:b0:4ff:706c:f4dc with SMTP id i13-20020a056512318d00b004ff706cf4dcmr6690746lfe.52.1692649136104; Mon, 21 Aug 2023 13:18:56 -0700 (PDT) X-Received: from [192.168.200.206] (83.11.188.80.ipv4.supernova.orange.pl. [83.11.188.80]) by smtp.gmail.com with ESMTPSA id t6-20020a19ad06000000b004fbad09317csm1895434lfc.189.2023.08.21.13.18.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 13:18:55 -0700 (PDT) Message-ID: Date: Mon, 21 Aug 2023 22:18:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 3/3] Platform/SbsaQemu: handle systems without GIC ITS To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: Ard Biesheuvel , Graeme Gregory References: <20230821150757.128280-1-marcin.juszkiewicz@linaro.org> <20230821150757.128280-4-marcin.juszkiewicz@linaro.org> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=S3W42Ipz; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 21.08.2023 o 20:27, Leif Lindholm pisze: > Hmm, wait. Patch 1/3 adds Iort.aslc and patch 3/3 deletes it. I know > 1/3 is Shashi's original implementation and 3/3 is heavily based on > that (if rewritten), but there's no point in merging the churn. I kind of wanted to get review of both parts. First one (written by Shashi long time ago) and rest (written by me in last months). Whole testing was "does Linux boots and shows me complex PCIe structure". Can squash into one, no problem. > What does this set look like as a single squashed patch? (I think > doing that would also address all previous comments I made.) 22:16 marcin@applejack:edk2-platforms$ git diff --stat origin/master Silicon/Qemu/SbsaQemu/SbsaQemu.dec = | 4 + Platform/Qemu/SbsaQemu/SbsaQemu.dsc = | 4 + Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf = | 1 + Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf = | 2 + Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf= | 1 + Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h = | 11 ++ Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuSmc.h = | 1 + Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c = | 208 +++++++++++++++++++- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c = | 10 + 9 files changed, 241 insertions(+), 1 deletion(-) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107936): https://edk2.groups.io/g/devel/message/107936 Mute This Topic: https://groups.io/mt/100874755/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-