From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, leif@nuviainc.com, "Gao,
Liming" <liming.gao@intel.com>
Cc: Andrew Fish <afish@apple.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: convert diff.order to LF-only
Date: Thu, 30 Apr 2020 16:46:15 +0200 [thread overview]
Message-ID: <f7b8cd5d-b20c-8272-2e24-0c1b9874f5d4@redhat.com> (raw)
In-Reply-To: <20200427165326.GU14075@vanye>
On 04/27/20 18:53, Leif Lindholm wrote:
> Hi Liming,
>
> Thanks!
> I'm sorry but I don't know what "PatchCheck CI pipe line can support
> the exception." means. I did ask before if there was a way to
> bypass that particular test.
>
> Anyway, I created
> https://github.com/tianocore/edk2/pull/549
> Grateful for any help.
Probably not the "help" you're looking for, but can we (re)consider this
a git bug?
For example, git copes with CRLFs in ".gitignore" just fine. If we
remove the CRs from "BaseTools/Conf/diff.order", Windows-based
contributors will have difficulty editing it.
NB I'm still OK with this patch, if we can get it merged, somehow.
Thanks
Laszlo
prev parent reply other threads:[~2020-04-30 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:46 [PATCH 1/1] BaseTools: convert diff.order to LF-only Leif Lindholm
2020-04-22 16:05 ` Michael D Kinney
2020-04-22 16:09 ` [edk2-devel] " Leif Lindholm
2020-04-23 11:01 ` Philippe Mathieu-Daudé
2020-04-23 12:10 ` Leif Lindholm
2020-04-24 13:30 ` Laszlo Ersek
2020-04-27 15:44 ` [edk2-devel] " Liming Gao
2020-04-27 16:22 ` Michael D Kinney
2020-04-27 17:06 ` Leif Lindholm
2020-04-27 16:53 ` Leif Lindholm
2020-04-30 14:46 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7b8cd5d-b20c-8272-2e24-0c1b9874f5d4@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox