From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web11.8613.1588257983635464999
 for <devel@edk2.groups.io>;
 Thu, 30 Apr 2020 07:46:23 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JySxvqE1;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1588257982;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nS3+2uIjgoH6dD9bakZSocp0DMAOgStGphzh2qGkQ48=;
	b=JySxvqE1Y5iONdVAl+xayYk9pQVcVxrIAiwX/suWvPZZ1m7fY2389EYCyVgfRfUWoNqbvn
	6GMp5lI/5CF25cqZnwTNsSYPm7r3Z6+HZyPztlyX0lNEde+mnAMQgqUKCqht1Ap9I3p85C
	Sef3y1jhwDDwFYo4xhMSMhs8kHAgbSM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-40-HTx5cau6MZK-lPsVGXQMhg-1; Thu, 30 Apr 2020 10:46:19 -0400
X-MC-Unique: HTx5cau6MZK-lPsVGXQMhg-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C41621899520;
	Thu, 30 Apr 2020 14:46:17 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-57.ams2.redhat.com [10.36.115.57])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 3500D6606F;
	Thu, 30 Apr 2020 14:46:16 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: convert diff.order to LF-only
To: devel@edk2.groups.io, leif@nuviainc.com,
 "Gao, Liming" <liming.gao@intel.com>
Cc: Andrew Fish <afish@apple.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>,
 "Feng, Bob C" <bob.c.feng@intel.com>, Sean Brogan <sean.brogan@microsoft.com>
References: <20200422154652.3853-1-leif@nuviainc.com>
 <3f075d5f-7dde-e676-e299-d7a408fe45f8@redhat.com>
 <BN6PR11MB3972582615649D88A87BAAEF80AF0@BN6PR11MB3972.namprd11.prod.outlook.com>
 <20200427165326.GU14075@vanye>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <f7b8cd5d-b20c-8272-2e24-0c1b9874f5d4@redhat.com>
Date: Thu, 30 Apr 2020 16:46:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200427165326.GU14075@vanye>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 04/27/20 18:53, Leif Lindholm wrote:
> Hi Liming,
> 
> Thanks!
> I'm sorry but I don't know what "PatchCheck CI pipe line can support
> the exception." means. I did ask before if there was a way to
> bypass that particular test.
> 
> Anyway, I created
> https://github.com/tianocore/edk2/pull/549
> Grateful for any help.

Probably not the "help" you're looking for, but can we (re)consider this
a git bug?

For example, git copes with CRLFs in ".gitignore" just fine. If we
remove the CRs from "BaseTools/Conf/diff.order", Windows-based
contributors will have difficulty editing it.

NB I'm still OK with this patch, if we can get it merged, somehow.

Thanks
Laszlo