From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.7386.1605105197613613866 for ; Wed, 11 Nov 2020 06:33:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ewZEVcfh; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605105196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FQvkFnx664IQTahcCfc4eun7dTuxsENahWTYqUSuCVo=; b=ewZEVcfhzcM7KhK2YYjZ+HCHwHU7k3OuRhAHQb3Gxjqbzv8wvVDGIDxUSY5irkLUFf0u61 5z6D5H/gW6AssrZNwB2Sz/0c11FNo4ty5eY9ALCk6+9guVb7QqZFtf/4lRlYhKPBnEwP60 8+I7nA15YWZ7mcLBdbAPDPSM4MRsL9c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-PMk2E7sBOS6ezk-IWHRdbA-1; Wed, 11 Nov 2020 09:33:10 -0500 X-MC-Unique: PMk2E7sBOS6ezk-IWHRdbA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B25606D585; Wed, 11 Nov 2020 14:33:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-0.ams2.redhat.com [10.36.113.0]) by smtp.corp.redhat.com (Postfix) with ESMTP id B111B6115F; Wed, 11 Nov 2020 14:33:06 +0000 (UTC) Subject: Re: [PATCH v2 0/4] Add extra pci roots support for Arm To: Jiahui Cen , devel@edk2.groups.io Cc: jordan.l.justen@intel.com, ard.biesheuvel@arm.com, leif@nuviainc.com, xieyingtai@huawei.com, miaoyubo@huawei.com References: <20201109130511.5946-1-cenjiahui@huawei.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 11 Nov 2020 15:33:05 +0100 MIME-Version: 1.0 In-Reply-To: <20201109130511.5946-1-cenjiahui@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/09/20 14:05, Jiahui Cen wrote: > Changes with v1 > v1->v2: > Separated into four patches. > Factor the same logic parts into a new library. > > v1: https://edk2.groups.io/g/devel/topic/72723351#56901 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 (1) Each commit message in the series should reference this bugzilla. But, in itself, that's no reason for a repost; such an update can be made by maintainers when they merge the series. (2) This is a feature addition, so it's merge material for the next development cycle . (Also it depends on the QEMU work being merged first.) I'm going to proceed with the review now. Thanks, Laszlo > QEMU: https://lore.kernel.org/qemu-devel/20201103120157.2286-1-cenjiahui@huawei.com/ > > This patch series adds support for extra pci roots for ARM. > > In order to avoid duplicated codes, we introduce a new library > PciHostBridgeUtilityLib which extracts common interfaces from > OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci > roots scanning. Using the utility lib, the uefi could scan for extra > root buses and recognize multiple roots for ARM. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Yubo Miao > Signed-off-by: Jiahui Cen > > Yubo Miao (4): > OvmfPkg: Extract functions form PciHostBridgeLib > ArmVirtPkg: Use extracted PciHostBridgeUtilityLib > OvmfPkg: Extract functions of extra pci roots > ArmVirtPkg: Support extra pci roots > > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfXen.dsc | 1 + > ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf | 5 + > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf | 51 ++++ > OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h | 98 +++++++ > ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 221 ++++++++------- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 234 +--------------- > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c | 283 ++++++++++++++++++++ > 12 files changed, 563 insertions(+), 335 deletions(-) > create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf > create mode 100644 OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h > create mode 100644 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c >