From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by mx.groups.io with SMTP id smtpd.web10.17286.1636192226683236456 for ; Sat, 06 Nov 2021 02:50:27 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@posteo.de header.s=2017 header.b=ov30HpdI; spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 39D0D240026 for ; Sat, 6 Nov 2021 10:50:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1636192224; bh=2wfOHlzqBAU0PK5GmIsFTrgzZLm/hnvswvFLSznSzRg=; h=Date:From:Subject:To:Cc:From; b=ov30HpdI2FGlgM/VnXwpxG7SwO/EwrXgS0DOIiKx/Ar266wiF5g/16+TiSqOWilZm w8uS4gyrZuTwF9PPnw33e7JeKsrtDD7bM05UzgEIIB4Li3DHUOdmn/lT3e+veBczoS e0upJJBf/1LUxt1QsUoAE6oML+fqrts+SsEyiAXfGhC/QFK9vUvp70mqk0VPktpESy qP8g2AQWIkfk9NnHQy572aa9GwAg8jbEgOvsdBlD5pT1bBs+EatheIJDsErdrLSFpb o8zFyFkm2IFq9MOCIaYDaBCB2c1tiA+VJ6Ov0X84KG0H6d9dtil2DeM26dOfEBL1as EmWVUDbcMZnmQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HmXg26nzfz9rxF; Sat, 6 Nov 2021 10:50:22 +0100 (CET) Message-ID: Date: Sat, 6 Nov 2021 09:50:22 +0000 MIME-Version: 1.0 From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= Subject: Re: [edk2-devel] [PATCH v2 16/16] ArmPlatformPkg: Resolve build errors resulting from package moves To: devel@edk2.groups.io, bret@corthon.com Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Sean Brogan References: <20211102201748.1963-1-brbarkel@microsoft.com> <20211102201748.1963-17-brbarkel@microsoft.com> In-Reply-To: <20211102201748.1963-17-brbarkel@microsoft.com> Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hey Bret, If I understood this correctly, this fixes build issues introduced with=20 the move patch of the same series? In that case, is there no edk2 rule=20 that every commit must compile for the whole tree? We have such a rule=20 downstream that overrides any colliding rules (e.g. "mod only one=20 package at a time") to not break bisectioning. We actually have=20 per-commit builds readily available in a database for some projects to=20 ease it further. No big deal for us as we don't do that with edk2 (yet),=20 but maybe worth considering for the future? :) I'll just ask about another patch here because it doesn't matter for=20 review, but why move the ARM entry point to ArmPkg? I guess because=20 abstracting the ARM-specific things would more or less just make the=20 StandaloneMm library a trivial wrapper? My "issue" with this is that ARM=20 kind of has its own ecosystem in edk2 and without keeping up, it's hard=20 to tell whether to look for ARM implementations of modules and libraries=20 in the "generic" or the ARM packages. Thanks a lot for the series! Best regards, Marvin 02.11.2021 21:21:59 Bret Barkelew : > From: Bret Barkelew >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3652 >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sean Brogan > Signed-off-by: Bret Barkelew > --- > ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatfo= rmPkg.dsc > index 661a4cea220d..3ed0bae87c41 100644 > --- a/ArmPlatformPkg/ArmPlatformPkg.dsc > +++ b/ArmPlatformPkg/ArmPlatformPkg.dsc > @@ -79,6 +79,8 @@ [LibraryClasses.common] > =C2=A0=C2=A0 NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsics= Lib.inf > =C2=A0=C2=A0 NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >=20 > +=C2=A0 ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf > + > [LibraryClasses.common.PEIM] > =C2=A0=C2=A0 HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > =C2=A0=C2=A0 MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/Pe= iMemoryAllocationLib.inf > @@ -92,7 +94,7 @@ [LibraryClasses.common.SEC] > =C2=A0=C2=A0 MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocatio= nLib/PrePiMemoryAllocationLib.inf > =C2=A0=C2=A0 PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPo= interLib/PrePiHobListPointerLib.inf >=20 > -[LibraryClasses.AARCH64.MM_STANDALONE] > +[LibraryClasses.common.MM_STANDALONE] > =C2=A0=C2=A0 HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/Standalone= MmHobLib.inf > =C2=A0=C2=A0 MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemo= ryAllocationLib/StandaloneMmMemoryAllocationLib.inf > =C2=A0=C2=A0 MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableL= ib/StandaloneMmServicesTableLib.inf > --=20 > 2.31.1.windows.1 >=20 >=20 >=20 >=20