public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Siyuan, Fu" <siyuan.fu@intel.com>
To: devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header file.
Date: Tue, 11 Feb 2020 21:36:36 +0800	[thread overview]
Message-ID: <f821552f22fc6675d68db2670f2c42bd2b4e7a37.1581428040.git.siyuan.fu@intel.com> (raw)
In-Reply-To: <cover.1581428040.git.siyuan.fu@intel.com>

Commit c7c964b and dd01704 add header file for FIT table and update
MpInitLib to support FIT based microcode shadow operation. There are
comments that FIT is Intel specific specification instead of industry
standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg.
This patch removes the header file added by c7c964b.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
---
 .../IndustryStandard/FirmwareInterfaceTable.h | 76 -------------------
 1 file changed, 76 deletions(-)
 delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h

diff --git a/MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h b/MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
deleted file mode 100644
index be3e34ae1b..0000000000
--- a/MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h
+++ /dev/null
@@ -1,76 +0,0 @@
-/** @file
-  Industry Standard Definitions of Firmware Interface Table BIOS Specification 1.0.
-
-  Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.<BR>
-  SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-#ifndef __FIRMWARE_INTERFACE_TABLE_H__
-#define __FIRMWARE_INTERFACE_TABLE_H__
-
-//
-// FIT Entry type definitions
-//
-#define FIT_TYPE_00_HEADER                  0x00
-#define FIT_TYPE_01_MICROCODE               0x01
-#define FIT_TYPE_02_STARTUP_ACM             0x02
-#define FIT_TYPE_07_BIOS_STARTUP_MODULE     0x07
-#define FIT_TYPE_08_TPM_POLICY              0x08
-#define FIT_TYPE_09_BIOS_POLICY             0x09
-#define FIT_TYPE_0A_TXT_POLICY              0x0A
-#define FIT_TYPE_0B_KEY_MANIFEST            0x0B
-#define FIT_TYPE_0C_BOOT_POLICY_MANIFEST    0x0C
-#define FIT_TYPE_10_CSE_SECURE_BOOT         0x10
-#define FIT_TYPE_2D_TXTSX_POLICY            0x2D
-#define FIT_TYPE_2F_JMP_DEBUG_POLICY        0x2F
-#define FIT_TYPE_7F_SKIP                    0x7F
-
-#define FIT_POINTER_ADDRESS                 0xFFFFFFC0 ///< Fixed address at 4G - 40h
-
-#define FIT_TYPE_VERSION                    0x0100
-
-#define FIT_TYPE_00_SIGNATURE  SIGNATURE_64 ('_', 'F', 'I', 'T', '_', ' ', ' ', ' ')
-
-#pragma pack(1)
-
-typedef struct {
-  //
-  // Address is the base address of the firmware component
-  // must be aligned on 16 byte boundary
-  //
-  UINT64 Address;
-  //
-  // Size is the span of the component in multiple of 16 bytes
-  //
-  UINT8  Size[3];
-  //
-  // Reserved must be set to 0
-  //
-  UINT8  Reserved;
-  //
-  // Component's version number in binary coded decimal (BCD) format.
-  // For the FIT header entry, the value in this field will indicate the revision
-  // number of the FIT data structure. The upper byte of the revision field
-  // indicates the major revision and the lower byte indicates the minor revision.
-  //
-  UINT16 Version;
-  //
-  // FIT types 0x00 to 0x7F
-  //
-  UINT8  Type : 7;
-  //
-  // Checksum Valid indicates whether component has valid checksum.
-  //
-  UINT8  C_V  : 1;
-  //
-  // Component's checksum. The modulo sum of all the bytes in the component and
-  // the value in this field (Chksum) must add up to zero. This field is only
-  // valid if the C_V flag is non-zero.
-  //
-  UINT8  Chksum;
-} FIRMWARE_INTERFACE_TABLE_ENTRY;
-
-#pragma pack()
-
-#endif
-- 
2.19.1.windows.1


  parent reply	other threads:[~2020-02-11 13:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 13:36 [PATCH v2 0/2] Move FIT based microcode shadow to platform PEIM Siyuan, Fu
2020-02-11 13:36 ` [PATCH v2 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib Siyuan, Fu
2020-02-12  2:52   ` Ni, Ray
2020-02-12  9:39     ` Laszlo Ersek
2020-02-11 13:36 ` Siyuan, Fu [this message]
2020-02-11 13:41   ` [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header file Liming Gao
2020-02-13  1:16   ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f821552f22fc6675d68db2670f2c42bd2b4e7a37.1581428040.git.siyuan.fu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox