From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68A11740038 for ; Wed, 24 Apr 2024 13:58:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=meKdD4E4eN1rw6+dj+cSRwTWiFVe42GNVXo7npM1in0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1713967136; v=1; b=MgqbU8n3q6lKEZK2bxXIEiy5R3aP/6vA5hunX6dAlBBaVOHvsNxNAyvpW9s/atwY76pkOU0f D4frmKFRd64iTJXJHqISTYekuDo5nheo2WLd9hNc2Xa4SdzidHD/kfASEcD4e0nMKrT9blGnnQk 98k6B4MprOvVMwpoQCAEBEqVw/+4bhSkkIMDY8Y/Z5r/nFXhAICgcAzZXdaWl1NFGQK4awK19Oa 25IS8JjN6OhBxPI/K1Sfj2Tx7f24mnSlsQv9BSmYKK/zsSCJTrdbFIcjRBq4rmO1GZFcDaiKiQW UyCFWLodD3lKJhq4OBLpC9iVBLazCb3vUfTFpIlRTpE7g== X-Received: by 127.0.0.2 with SMTP id 6EFMYY7687511xDy6fuW3QrN; Wed, 24 Apr 2024 06:58:56 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.17066.1713967134781738946 for ; Wed, 24 Apr 2024 06:58:54 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A69A42F; Wed, 24 Apr 2024 06:59:21 -0700 (PDT) X-Received: from [10.119.32.11] (unknown [10.119.32.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C50DF3F64C; Wed, 24 Apr 2024 06:58:53 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 08:58:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 1/4] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct To: devel@edk2.groups.io, edhaya.chandran@arm.com References: <6441.1713958371139673072@groups.io> <6441.1713958590295719380@groups.io> From: "Stuart Yoder" In-Reply-To: <6441.1713958590295719380@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 24 Apr 2024 06:58:54 -0700 Resent-From: stuart.yoder@arm.com Reply-To: devel@edk2.groups.io,stuart.yoder@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FfEpWe49W1x4kZpgSCbDce4wx7686176AA= Content-Type: multipart/alternative; boundary="------------sHdgSlAGDiHq3MXfiQMZMOnq" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=MgqbU8n3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --------------sHdgSlAGDiHq3MXfiQMZMOnq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Edhaya, Yes, we could get rid of the TPM 2.0 definitions and include the MdePkg=20 definition, but it will require rework of TCG2.h to remove duplicate=20 definitions. But, what is the general of philosophy of what source code edk2-test=20 should include from edk2?=C2=A0 Since the purpose of edk2-test is to test t= he=20 firmware, for some things it seems better for edk2-test to have it's own=20 private=C2=A0 definitions.=C2=A0 Otherwise, if there was an edk2 bug in som= ething=20 like a protocol definition, and if edk2-test included the same .h file,=20 then the bug may never be discovered.=C2=A0 It's better if edk2-test define= s=20 it's own structs based on the specifications.=C2=A0 That way it is=20 independent of the firmware and it's a better test. In the case of Tpm20.h, that is probably not the case as those are TPM=20 definitions, not protocol definitions. Do you want me to try to get rid of the TPM definitions and use Tpm20.h=20 for this patch series?=C2=A0 Or, as a separate patch? Thanks, Stuart On 4/24/24 6:36 AM, G Edhaya Chandran via groups.io wrote: > Update: We have the struct itself define here: > https://github.com/tianocore/edk2/blob/master/MdePkg/Include/IndustryStan= dard/Tpm20.h#L904=20 > >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118214): https://edk2.groups.io/g/devel/message/118214 Mute This Topic: https://groups.io/mt/105558006/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------sHdgSlAGDiHq3MXfiQMZMOnq Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Edhaya,

Yes, we could get rid of the TPM 2.0 definitions and include the MdePkg definition, but it will require rework of TCG2.h to remove duplicate definitions.

But, what is the general of philosophy of what source code edk2-test should include from edk2?=C2=A0 Since the purpose of edk2-test is to test the firmware, for some things it seems better for edk2-test to have it's own private=C2=A0 definitions.=C2=A0 Other= wise, if there was an edk2 bug in something like a protocol definition, and if edk2-test included the same .h file, then the bug may never be discovered.=C2=A0 It's better if edk2-test defines it's own struct= s based on the specifications.=C2=A0 That way it is independent of the firmware and it's a better test.

In the case of Tpm20.h, that is probably not the case as those are TPM definitions, not protocol definitions.

Do you want me to try to get rid of the TPM definitions and use Tpm20.h for this patch series?=C2=A0 Or, as a separate patch?

Thanks,

Stuart

On 4/24/24 6:36 AM, G Edhaya Chandran via groups.io wrote:
Update: We have the struct itself define here:
https://github.= com/tianocore/edk2/blob/master/MdePkg/Include/IndustryStandard/Tpm20.h#L904= =20
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118214) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------sHdgSlAGDiHq3MXfiQMZMOnq--