From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9923CAC0EFF for ; Tue, 17 Oct 2023 14:32:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yJGmDjlPeqS60ANqQvYCTeoYgWCadVrpU7Nm0hCwK6g=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697553155; v=1; b=wpOQvAUVF8BsrJSkqhJXHt49Tz9WDnYwSo+0WGdrmKa0gqBxFdpxtoFzEi5qxZmOhTQbHEtl N2q5+Bhmnvkx0svOwQ+4c7jNLk85dHC8yoI5VpsKp7dGgZDSqWFTrQCAgUdxf8OQ9uYqUJEAHRJ iuqetKnyDDEL/fpaSINyD67s= X-Received: by 127.0.0.2 with SMTP id iAPfYY7687511xAeZM7blIoC; Tue, 17 Oct 2023 07:32:35 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.218466.1697553154621232537 for ; Tue, 17 Oct 2023 07:32:34 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-620-qX9kWL4ENmi7EhshH1waGQ-1; Tue, 17 Oct 2023 10:32:27 -0400 X-MC-Unique: qX9kWL4ENmi7EhshH1waGQ-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD57D2932493; Tue, 17 Oct 2023 14:32:26 +0000 (UTC) X-Received: from [10.39.193.132] (unknown [10.39.193.132]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D5152166B26; Tue, 17 Oct 2023 14:32:24 +0000 (UTC) Message-ID: Date: Tue, 17 Oct 2023 16:32:23 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v5 1/2] MdePkg:Implement RISCV CMO From: "Laszlo Ersek" To: devel@edk2.groups.io, dhaval@rivosinc.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Sunil V L , Andrei Warkentin References: <20231017121755.190285-1-dhaval@rivosinc.com> <20231017121755.190285-2-dhaval@rivosinc.com> In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LvAg0peO2VfVrHZjAVkqbxXhx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wpOQvAUV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/17/23 16:22, Laszlo Ersek wrote: > On 10/17/23 14:17, Dhaval Sharma wrote: >> Implementing code to support Cache Management Operations >> (CMO) defined by RV spec https://github.com/riscv/riscv-CMOs (28) Please do not abbreviate RISC-V as "RV". It's incredibly confusing. (29) Inconsistent spelling in the patch subject: "RISCV CMO". Should be RISC-V cache management operations >> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >> index ac54338089e8..2d06cf46b1ca 100644 >> --- a/MdePkg/MdePkg.dec >> +++ b/MdePkg/MdePkg.dec >> @@ -2399,6 +2399,13 @@ [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.= AARCH64] >> # @Prompt CPU Rng algorithm's GUID. >> gEfiMdePkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm|{0x00,0x00,0x00,= 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00}|VOID*|0x0= 0000037 >> >> +[PcdsFixedAtBuild.RISCV64, PcdsPatchableInModule.RISCV64] >> + # >> + # Configurability to override RV CPU Features (30) ditto; should be RISC-V >> + # BIT 0 =3D CMO >> + # >> + gEfiMdePkgTokenSpaceGuid.PcdRVFeatureOverride|0x1|UINT64|0x69 (31) ditto, should be PcdRiscVFeatureOverride >> +#define RV64_CACHE_BLOCK_SIZE 64 >> +#define RV_CPU_FEATURE_CMO_BITMASK 0x1 (32) Total inconsistency, RV64_ versus RV_. Edk2 only supports RISCV64, so "64" in the prefix is meaningless. Both prefixes should be RISCV_. >> +RiscvIsCMOEnabled ( (33) Should be RiscVIsCMOEnabled (upper case V). Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109688): https://edk2.groups.io/g/devel/message/109688 Mute This Topic: https://groups.io/mt/102016148/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-