public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: "Ard Biesheuvel" <ard.biesheuvel@arm.com>,
	"Jordan Justen" <jordan.l.justen@intel.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level
Date: Wed, 10 Jun 2020 10:00:50 +0200	[thread overview]
Message-ID: <f8627c64-855e-1b16-e0ce-3925ab43bb32@redhat.com> (raw)
In-Reply-To: <20200609105414.12474-1-lersek@redhat.com>

On 06/09/20 12:54, Laszlo Ersek wrote:
> gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it
> means that QEMU wasn't started with "-kernel". Log this status code as
> INFO rather than ERROR.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     Repo:   https://pagure.io/lersek/edk2.git
>     Branch: gqlil_not_found
> 
>  OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> index 14c8417d43e7..114db7e8441f 100644
> --- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> +++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> @@ -106,7 +106,8 @@ QemuLoadKernelImage (
>      goto UnloadImage;
>  
>    default:
> -    DEBUG ((DEBUG_ERROR, "%a: LoadImage(): %r\n", __FUNCTION__, Status));
> +    DEBUG ((Status == EFI_NOT_FOUND ? DEBUG_INFO : DEBUG_ERROR,
> +      "%a: LoadImage(): %r\n", __FUNCTION__, Status));
>      return Status;
>    }
>  
> 

Merged as commit 14c7ed8b51f6 via
<https://github.com/tianocore/edk2/pull/678>.

Thanks
Laszlo


  parent reply	other threads:[~2020-06-10  8:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 10:54 [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level Laszlo Ersek
2020-06-09 10:58 ` [edk2-devel] " Ard Biesheuvel
2020-06-10  8:00 ` Laszlo Ersek [this message]
2020-06-11  7:25   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8627c64-855e-1b16-e0ce-3925ab43bb32@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox