From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.5875.1591776073009293374 for ; Wed, 10 Jun 2020 01:01:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FcKZkCa4; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591776072; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5VyK+cVtYUyOFSj1/sZPu67zmrVJxYjhmVNT61II9zU=; b=FcKZkCa4VIowvsyZ2PvNSXhizakTuwvETPBbd07Y073yJTznYLFX1BFkmCx3cMMvd6oRjD VyFo0ROSNGc9nZW3XUXEl4KsbUag56Hp6XCwy/IoSszSxSw8jlx0rw4lQl+sWS/DJpA5RQ U8FySd/aGdMNWVkPSit4yfwgiDc6soU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-LrJAyFZyO8mnqyZtHQi_6A-1; Wed, 10 Jun 2020 04:00:54 -0400 X-MC-Unique: LrJAyFZyO8mnqyZtHQi_6A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C92E2A0BD8; Wed, 10 Jun 2020 08:00:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-233.ams2.redhat.com [10.36.112.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADC8461984; Wed, 10 Jun 2020 08:00:51 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Jordan Justen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20200609105414.12474-1-lersek@redhat.com> Message-ID: Date: Wed, 10 Jun 2020 10:00:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200609105414.12474-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 06/09/20 12:54, Laszlo Ersek wrote: > gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it > means that QEMU wasn't started with "-kernel". Log this status code as > INFO rather than ERROR. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Signed-off-by: Laszlo Ersek > --- > > Notes: > Repo: https://pagure.io/lersek/edk2.git > Branch: gqlil_not_found > > OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c > index 14c8417d43e7..114db7e8441f 100644 > --- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c > +++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c > @@ -106,7 +106,8 @@ QemuLoadKernelImage ( > goto UnloadImage; > > default: > - DEBUG ((DEBUG_ERROR, "%a: LoadImage(): %r\n", __FUNCTION__, Status)); > + DEBUG ((Status == EFI_NOT_FOUND ? DEBUG_INFO : DEBUG_ERROR, > + "%a: LoadImage(): %r\n", __FUNCTION__, Status)); > return Status; > } > > Merged as commit 14c7ed8b51f6 via . Thanks Laszlo