From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web12.9331.1619183395781499388
 for <devel@edk2.groups.io>;
 Fri, 23 Apr 2021 06:09:55 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XY3jN4vP;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1619183395;
	h=from:from:reply-to:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8ZTRPNEIloAOjFU9i4gklhrTMfHbcNa9Go8noI2AoPg=;
	b=XY3jN4vPvAQYreBo7Cyw61UzV5bbR2dApf9EjtqQ3jmJPojwNuOgZJ91y0LzWua8slZhqk
	ZdrkskTX3B48cnXAwBJC2amsTxy/hUZkZ8pU9Pt7JrVFUZwDWfNjWbqwHgmiCnKMRBmMPT
	wU3NNHc9HnZ5mXTwDC3RNNEKAFxh8Zs=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-15-hDs5w5x8PaSOmoUFtsnshw-1; Fri, 23 Apr 2021 09:09:51 -0400
X-MC-Unique: hDs5w5x8PaSOmoUFtsnshw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 771651006C94;
	Fri, 23 Apr 2021 13:09:49 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-2.ams2.redhat.com [10.36.115.2])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 0C25E60BE5;
	Fri, 23 Apr 2021 13:09:46 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 3/3] OvmfPkg/PlatformPei: Mark TPM MMIO range as unencrypted for SEV
From: "Laszlo Ersek" <lersek@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io, Joerg Roedel <joro@8bytes.org>,
 Borislav Petkov <bp@alien8.de>, Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Brijesh Singh <brijesh.singh@amd.com>, James Bottomley <jejb@linux.ibm.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>
Reply-To: devel@edk2.groups.io, lersek@redhat.com
References: <cover.1618959281.git.thomas.lendacky@amd.com>
 <1f64ca5689ec86c427e4db8c41da598896dca4ba.1618959281.git.thomas.lendacky@amd.com>
 <8417023b-b3d6-5268-e92a-0c6f5ebfff6b@redhat.com>
 <4261e15a-84a0-11a7-2981-9eeb538f6da9@redhat.com>
Message-ID: <f8740d26-f2e0-18ce-6cad-7c885faa46d5@redhat.com>
Date: Fri, 23 Apr 2021 15:09:45 +0200
MIME-Version: 1.0
In-Reply-To: <4261e15a-84a0-11a7-2981-9eeb538f6da9@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 04/23/21 15:04, Laszlo Ersek wrote:

> There are several advantages to such a separate PEIM:
> 
> - For Bhyve, the update is minimal. Just include one line in each of the
> FDF and the DSC files. No need to customize an existent
> platform-specific PEIM, no code duplication between two PlatformPei modules.

OTOH, you'd have to update OvmfPkg/AmdSev/AmdSevX64.* too.

Thanks
Laszlo