Re: [edk2-devel] [PATCH v5][edk2-platforms 00/17] Platform/Arm/Sgi: Add platform support for RD-Daniel

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 5/5/20 3:01 PM, Aditya Angadi via groups.io wrote:
> Changes since v4:
> - Addressed all the comments from Ard.
>    - Split the patches into multiple smaller patches where applicable.
>    - Reworded the commit messages to be more accurate about the change
>      being introduced.
> - Picked up Ard's review tags
> 
> Changes since v3:
> - Addressed all the comments from Ard.
>    - Each platform with SgiPkg would be built independently of the other.
>    - Removed all references to ACPI tables of platforms that are not part
>      of the build of a platform.
> - Added support for multi-chip NUMA memory nodes.
> - Added SRAT table for RdN1EdgeX2 platform.
> - Did not pickup the review tags from Ard because the code change from
>    last version.
> 
> This patch series adds support for Arm's RD-Daniel platform. There are two
> configurations of this platform being added in this series - Config-M and
> Config-XLR. RD-Daniel is the next Arm's reference design subsystem.
> Config XLR is a multi chip platform.
> 
> The first five patches rework the SgiPkg code to move away from being
> able to build a single binary for all the supported platforms to
> independent binary for each platform. This was requried as the first
> step to add newer RD platform support in SgiPkg as these newer platforms
> have differences in the programming interface.
> 
> Patches 6 to 11 in the series refactor and consolidate the code in
> SgiPkg in preparation for adding support for numa memory nodes and the
> RD-Daniel platform.
> 
> Patches 12 and 13 in the series add SRAT table for RD-N1-Edge platform
> and removes the hard-code chip count on the platform.
> 
> The next four patches add support for the RD-Daniel platforms. There are
> two configuration of RD-Daniel platform.
>    - RD-Daniel Config-M: This is single chip platform that includes
>      16 Neoverse cores.
>    - RD-Daniel Config-XLR: This is multi-chip platform that includes
>      four identical chip connected over a coherent link with all the
>      four chips put together into a single package. Each chip includes
>      four Neoverse cores and it attached to 8GB of RAM.
> 
> 
> Aditya Angadi (15):
>    Platform/ARM/SgiPkg: Create platform specific dsc files
>    Platform/ARM/SgiPkg: Let platforms define core and cluster count
>    Platform/ARM/SgiPkg: Let platforms define GIC related PCD values
>    Platform/ARM/SgiPkg: Create platform specific fd include file
>    Platform/ARM/SgiPkg: Let platform specify the ACPI tables to include
>    Platform/ARM/SgiPkg: Obtain rd-e1-edge platform core count from PCD
>    Platform/ARM/SgiPkg: Refactor GIC related ACPI helper macros
>    Platform/ARM/SgiPkg: Update SGI-575 MADT table to ACPI 6.2
>    Platform/ARM/SgiPkg: Move common platform description to SSDT
>    Platform/ARM/SgiPkg: Add helper macros for SRAT table
>    Platform/ARM/SgiPkg: Use chip count constant on rdn1edgex2 platform
>    Platform/ARM/SgiPkg: Add ACPI tables for Rd-Daniel Config-M
>    Platform/ARM/SgiPkg: Add initial support for RD-Daniel Config-M
>      platform
>    Platform/ARM/SgiPkg: Add ACPI tables for RD-Daniel Config-XLR
>    Platform/ARM/SgiPkg: Add initial support for RD-Daniel Config-XLR
>      platform
> 
> Vijayenthiran Subramaniam (2):
>    Platform/ARM/SgiPkg: Add support for remote numa memory nodes
>    Platform/ARM/SgiPkg: Add SRAT table for RdN1Edge dual-chip platform
> 

For the series,

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 03fb86be4146..ca1a7187861c

Thanks!