From: Laszlo Ersek <lersek@redhat.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: (spawning off more style discussion)
Date: Wed, 18 Apr 2018 10:51:08 +0200 [thread overview]
Message-ID: <f892532a-abc4-4251-4194-2af05be4b85a@redhat.com> (raw)
In-Reply-To: <20180417135538.4a26k4atmyvcotkj@bivouac.eciton.net>
On 04/17/18 15:55, Leif Lindholm wrote:
> On Mon, Apr 16, 2018 at 09:32:44PM +0200, Laszlo Ersek wrote:
>> (4) Please consider adopting
>>
>> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-10
>> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
>>
>> so that patches roughly advance from "abstract" to "concrete".
>
> I have been reluctant to adopt this aspect of the guidance since it
> means project-specific syntax to generic commands (whereas
> --stat-graph-width and --stat are generic and not always needed).
>
> However, at least newer versions of git seem to support a
> diff.orderFile config option. So you should see this improved in
> future patches from me.
Indeed, when I wrote the wiki article, there was only -O, and no
diff.orderFile. This annoyed me to no end, and when diff.orderFile was
brought about by a new git release (I don't know which one), I was happy
to set it. Obviously, I never updated the wiki article. That's the bad
thing about documentation, it unavoidably rots, and creates a
never-ending obligation for updates.
>
>> (6) Please don't use "__" and "_C" prefixes for identifiers (see
>> __CONCATENATE and _CONCATENATE); according to the C standard, "All
>> identifiers that begin with an underscore and either an uppercase
>> letter or another underscore are always reserved for any use".
>>
>> I know Linux uses "__" prefixes liberally; that doesn't make them
>> any less wrong :)
>
> I stole those internal names from MdePkg/Include/Base.h
Ouch! :)
> While that makes me a double-baddie - should we have some global
> macros for this particularly awkward bit of CPP-ness?
Yes. I think turning them into the public CONCAT_WORKER() and CONCAT()
macros should be fine. There's no reason not to use ## wherever it makes
sense, so Base.h should support it. (The same argument worked for
ARRAY_SIZE() as well.)
>> ... Obviously I don't insist on these patches being implemented "my
>> way"; I'm stating my opinion because you CC'd me :) (Thanks for that!)
>
> And your input is always appreciated.
Thanks!
Laszlo
next prev parent reply other threads:[~2018-04-18 8:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 17:42 [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib Leif Lindholm
2018-04-13 19:24 ` Kinney, Michael D
2018-04-13 19:31 ` Leif Lindholm
2018-04-13 23:32 ` Kinney, Michael D
2018-04-16 10:07 ` Leif Lindholm
2018-04-16 14:10 ` Kinney, Michael D
2018-04-16 14:34 ` Michael Brown
2018-04-16 20:42 ` Laszlo Ersek
2018-04-16 22:14 ` Michael Brown
2018-04-17 8:01 ` Laszlo Ersek
2018-04-17 8:24 ` Michael Brown
2018-04-17 9:57 ` Laszlo Ersek
2018-04-17 13:26 ` Leif Lindholm
2018-04-17 15:20 ` Kinney, Michael D
2018-04-17 6:57 ` Udit Kumar
2018-04-16 19:32 ` Laszlo Ersek
2018-04-17 8:15 ` Udit Kumar
2018-04-17 9:42 ` Laszlo Ersek
2018-04-17 10:32 ` Udit Kumar
2018-04-17 13:55 ` (spawning off more style discussion) Leif Lindholm
2018-04-18 8:51 ` Laszlo Ersek [this message]
2018-04-16 4:39 ` [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib Udit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f892532a-abc4-4251-4194-2af05be4b85a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox