From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 76B4E22683916 for ; Wed, 18 Apr 2018 01:51:10 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CDC8DEBFE9; Wed, 18 Apr 2018 08:51:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-150.rdu2.redhat.com [10.10.120.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6278E2023227; Wed, 18 Apr 2018 08:51:09 +0000 (UTC) To: Leif Lindholm Cc: "edk2-devel@lists.01.org" References: <20180413174211.858-1-leif.lindholm@linaro.org> <20180413193143.t45tua3yi7sopk4d@bivouac.eciton.net> <20180416100712.6v642ycksvmoffvt@bivouac.eciton.net> <20180417135538.4a26k4atmyvcotkj@bivouac.eciton.net> From: Laszlo Ersek Message-ID: Date: Wed, 18 Apr 2018 10:51:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180417135538.4a26k4atmyvcotkj@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 18 Apr 2018 08:51:09 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 18 Apr 2018 08:51:09 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: (spawning off more style discussion) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 08:51:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/17/18 15:55, Leif Lindholm wrote: > On Mon, Apr 16, 2018 at 09:32:44PM +0200, Laszlo Ersek wrote: >> (4) Please consider adopting >> >> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-10 >> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 >> >> so that patches roughly advance from "abstract" to "concrete". > > I have been reluctant to adopt this aspect of the guidance since it > means project-specific syntax to generic commands (whereas > --stat-graph-width and --stat are generic and not always needed). > > However, at least newer versions of git seem to support a > diff.orderFile config option. So you should see this improved in > future patches from me. Indeed, when I wrote the wiki article, there was only -O, and no diff.orderFile. This annoyed me to no end, and when diff.orderFile was brought about by a new git release (I don't know which one), I was happy to set it. Obviously, I never updated the wiki article. That's the bad thing about documentation, it unavoidably rots, and creates a never-ending obligation for updates. > >> (6) Please don't use "__" and "_C" prefixes for identifiers (see >> __CONCATENATE and _CONCATENATE); according to the C standard, "All >> identifiers that begin with an underscore and either an uppercase >> letter or another underscore are always reserved for any use". >> >> I know Linux uses "__" prefixes liberally; that doesn't make them >> any less wrong :) > > I stole those internal names from MdePkg/Include/Base.h Ouch! :) > While that makes me a double-baddie - should we have some global > macros for this particularly awkward bit of CPP-ness? Yes. I think turning them into the public CONCAT_WORKER() and CONCAT() macros should be fine. There's no reason not to use ## wherever it makes sense, so Base.h should support it. (The same argument worked for ARRAY_SIZE() as well.) >> ... Obviously I don't insist on these patches being implemented "my >> way"; I'm stating my opinion because you CC'd me :) (Thanks for that!) > > And your input is always appreciated. Thanks! Laszlo