From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22b; helo=mail-wm0-x22b.google.com; envelope-from=paolo.bonzini@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 39EBD202E6144 for ; Mon, 16 Oct 2017 10:10:19 -0700 (PDT) Received: by mail-wm0-x22b.google.com with SMTP id q124so5459725wmb.0 for ; Mon, 16 Oct 2017 10:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QjWtOknfQPmuKHuVaJtyM0D/SSG0wH3mYBa9C/2L0xg=; b=sakxQReXMSqyuJ95illxwS0Jr4HXYfDJpKtRO2q7pSBTTJz6QK6LrYj4LBiLS4Odj4 LllfVzI2HHl8l/k69v8ILacpDIj5xdEH8wrUlexHT7DXX/78kI7bd6+MwWG3dRctP7Lz Q1JvNkZAFaRwJCHwy0OnccaNERN0bI1C4gz4z4Lm3NjXxI2b+cccX8TXTkpauygJis6C qKs+psGKRCF/UalmFxI5lS2Vt9RxNAhStMfG28PpF1pESHAnO0WGL4jy4SE9qEfqbeqP kzvp8qtgH4KEJdX4G3i/0DitSLk1b7CW65rUJvAmntUl5+4HmCfXY/q9Se/CDDURC+sQ QcrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QjWtOknfQPmuKHuVaJtyM0D/SSG0wH3mYBa9C/2L0xg=; b=pbCopK5On7yR5kt5PBjanGK7mEpxW8NLseUgHzSYOyI6a8TtWwMMks51IK3xN2JQDN 0kGZ3Xn8tHOnAlXidd6auKd3G8rw43PwwugB9MQxDsnDZigkjoVUA51khqAP/LSFn1ut ijzUga9wSfi4MDn4dubnb8RIwWUXf+HrHgbCiXjMish5RSszFisbpBDY1WeBtxM2FHxT iTM9/Pjso/fqydyoWVqOI0h4ltgVgXYwOFQPnbR8H1n9lTyRcPoM7Mh86thHNC5lLG7C cEflT1lINyxq4xdHQdglLQMomRyh/dWNOmV5VhyzWAQLWV0yPFr9/LTE5mZ2u31tmi9k euFQ== X-Gm-Message-State: AMCzsaVtS4Sgk3Qo69orWKz0NPuF6Gj7KJySkDmB79yjrY7SLNtzL2QQ LwGyqJf2/qjJD4mKwI0HcVEDtoaz X-Google-Smtp-Source: ABhQp+Qzpf1RcDBm7uq94OdLIjj47TfjIoDUAJ/eN4kqyp9iJ0PyBfCtz/GkhBO/XsivU/SNcHC+hw== X-Received: by 10.28.23.76 with SMTP id 73mr1635015wmx.70.1508174032638; Mon, 16 Oct 2017 10:13:52 -0700 (PDT) Received: from [192.168.10.165] (94-39-155-245.adsl-ull.clienti.tiscali.it. [94.39.155.245]) by smtp.googlemail.com with ESMTPSA id h201sm10396068wmd.27.2017.10.16.10.13.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 10:13:51 -0700 (PDT) Sender: Paolo Bonzini To: "Yao, Jiewen" , Leo Duran , "edk2-devel@lists.01.org" References: <1507751131-32404-1-git-send-email-leo.duran@amd.com> <74D8A39837DF1E4DA445A8C0B3885C503A9E505E@SHSMSX104.ccr.corp.intel.com> From: Paolo Bonzini Message-ID: Date: Mon, 16 Oct 2017 19:13:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A9E505E@SHSMSX104.ccr.corp.intel.com> Subject: Re: [PATCH v5 0/2] Enhanced SMM support for AMD-based x86 systems. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 17:10:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 13/10/2017 03:52, Yao, Jiewen wrote: > I recommend we move AMD_SMRAM_SAVE_STATE_MAP_OFFSET to UefiCpuPkg\Include\Register\Amd\SmramSaveStateMap.h, because it is standard. > +// > +// Definitions for AMD systems are based on contents of the > +// AMD64 Architecture Programmer's Manual > +// Volume 2: System Programming, Section 10 System-Management Mode > +// > +#define AMD_SMRAM_SAVE_STATE_MAP_OFFSET 0xfe00 If I understand correctly, I think AMD can keep on using 0xfc00 and just adjust the offsets up by 0x200 bytes. For example, QEMU_SMRAM_SAVE_STATE_MAP in OvmfPkg/Include/Register/QemuSmramStateSaveMap.h is essentially the AMD format and it starts with: UINT8 Reserved0[0x200]; // 7c00h UINT8 Reserved1[0xf8]; // 7e00h See also the comment in SMRAM_SAVE_STATE_MAP32: UINT8 Reserved[0x200]; // 7c00h // Padded an extra 0x200 bytes so 32-bit and 64-bit // SMRAM Save State Maps are the same size UINT8 Reserved1[0xf8]; // 7e00h Thanks, Paolo