From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A8ABE7803D0 for ; Fri, 16 Feb 2024 17:29:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=J/hXBAjMNi/TUcrsZX03HygLyAQ/QlHWfmJhOhKkWeE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708104589; v=1; b=FlndsAGlPUAI0rLmJT4GPACs6H+3wDg7Ju3Sizn2iMeF6dD3LXjPQzR/k8nvdM6t6LBJKIYZ f8vlh3MJDhBxUTT0xQ1OtiSrScmkJ/0C4srvVQCLL6V/MR7jAb+8kV/V/MhAbIMkHuTkbY2mcrW WdsNiwaDSErYQDvCoI1NjJDE= X-Received: by 127.0.0.2 with SMTP id b1MqYY7687511x4YC14DvwSU; Fri, 16 Feb 2024 09:29:49 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.2862.1708104588713135348 for ; Fri, 16 Feb 2024 09:29:48 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-SGBBCFc2OumyK5sUqBL0gg-1; Fri, 16 Feb 2024 12:29:45 -0500 X-MC-Unique: SGBBCFc2OumyK5sUqBL0gg-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 755551005055; Fri, 16 Feb 2024 17:29:45 +0000 (UTC) X-Received: from [10.39.194.129] (unknown [10.39.194.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9A6A2026D06; Fri, 16 Feb 2024 17:29:43 +0000 (UTC) Message-ID: Date: Fri, 16 Feb 2024 18:29:42 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 02/12] OvmfPkg: add ShellLibs.dsc.inc To: devel@edk2.groups.io, kraxel@redhat.com Cc: Jiewen Yao , Min Xu , Tom Lendacky , Oliver Steffen , Erdem Aktas , Ard Biesheuvel , Michael Roth References: <20240215102503.273275-1-kraxel@redhat.com> <20240215102503.273275-3-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20240215102503.273275-3-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8RnxE23DMdDYoBauJI9HRcJwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FlndsAGl; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/15/24 11:24, Gerd Hoffmann wrote: > Move EFI Shell libraries from OvmfPkgX64.dsc to > the new ShellComponents.dsc.inc include file. >=20 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Include/Dsc/ShellLibs.dsc.inc | 10 ++++++++++ > OvmfPkg/OvmfPkgX64.dsc | 4 +--- > 2 files changed, 11 insertions(+), 3 deletions(-) > create mode 100644 OvmfPkg/Include/Dsc/ShellLibs.dsc.inc Reviewed-by: Laszlo Ersek >=20 > diff --git a/OvmfPkg/Include/Dsc/ShellLibs.dsc.inc b/OvmfPkg/Include/Dsc/= ShellLibs.dsc.inc > new file mode 100644 > index 000000000000..f4551ec84aeb > --- /dev/null > +++ b/OvmfPkg/Include/Dsc/ShellLibs.dsc.inc > @@ -0,0 +1,10 @@ > +## > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +!if $(BUILD_SHELL) =3D=3D TRUE > + > +[LibraryClasses] > + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > + > +!endif > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 043b0a7a67e0..56c920168d25 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -258,9 +258,6 @@ [LibraryClasses] > TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf > !endif > =20 > -!if $(BUILD_SHELL) =3D=3D TRUE > - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > -!endif > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.= inf > =20 > S3BootScriptLib|MdeModulePkg/Library/PiDxeS3BootScriptLib/DxeS3BootScr= iptLib.inf > @@ -268,6 +265,7 @@ [LibraryClasses] > OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL= ib/BaseOrderedCollectionRedBlackTreeLib.inf > =20 > !include OvmfPkg/Include/Dsc/OvmfTpmLibs.dsc.inc > +!include OvmfPkg/Include/Dsc/ShellLibs.dsc.inc > =20 > [LibraryClasses.common] > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115546): https://edk2.groups.io/g/devel/message/115546 Mute This Topic: https://groups.io/mt/104370208/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-