[PATCH v1 1/1] OvmfPkg: Disable EccCheck CI until EccCheck issues are fixed

[PATCH v1 1/1] OvmfPkg: Disable EccCheck CI until EccCheck issues are fixed

[mikuback]

From: Sean Brogan <sean.brogan@microsoft.com>

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 OvmfPkg/OvmfPkg.ci.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml
index 3128aefe9ed1..0d6a78ff5b30 100644
--- a/OvmfPkg/OvmfPkg.ci.yaml
+++ b/OvmfPkg/OvmfPkg.ci.yaml
@@ -22,7 +22,8 @@
         ],
         ## Both file path and directory path are accepted.
         "IgnoreFiles": [
-        ]
+        ],
+        "skip": True
     },
     ## options defined .pytool/Plugin/CompilerPlugin
     "CompilerPlugin": {
-- 
2.28.0.windows.1

Re: [PATCH v1 1/1] OvmfPkg: Disable EccCheck CI until EccCheck issues are fixed

[Laszlo Ersek]

On 12/10/20 22:56, mikuback@linux.microsoft.com wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  OvmfPkg/OvmfPkg.ci.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml
> index 3128aefe9ed1..0d6a78ff5b30 100644
> --- a/OvmfPkg/OvmfPkg.ci.yaml
> +++ b/OvmfPkg/OvmfPkg.ci.yaml
> @@ -22,7 +22,8 @@
>          ],
>          ## Both file path and directory path are accepted.
>          "IgnoreFiles": [
> -        ]
> +        ],
> +        "skip": True
>      },
>      ## options defined .pytool/Plugin/CompilerPlugin
>      "CompilerPlugin": {
> 

Thank you guys very much!

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

... I've submitted a PR at
<https://github.com/tianocore/edk2/pull/1224>, but it seems stuck; I've
commented in the

  EDK II CI failing - Do not submit PRs with "push" label set

thread.

Thanks
Laszlo

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg: Disable EccCheck CI until EccCheck issues are fixed

[Laszlo Ersek]

On 12/14/20 15:55, Laszlo Ersek wrote:
> On 12/10/20 22:56, mikuback@linux.microsoft.com wrote:
>> From: Sean Brogan <sean.brogan@microsoft.com>
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>>  OvmfPkg/OvmfPkg.ci.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml
>> index 3128aefe9ed1..0d6a78ff5b30 100644
>> --- a/OvmfPkg/OvmfPkg.ci.yaml
>> +++ b/OvmfPkg/OvmfPkg.ci.yaml
>> @@ -22,7 +22,8 @@
>>          ],
>>          ## Both file path and directory path are accepted.
>>          "IgnoreFiles": [
>> -        ]
>> +        ],
>> +        "skip": True
>>      },
>>      ## options defined .pytool/Plugin/CompilerPlugin
>>      "CompilerPlugin": {
>>
> 
> Thank you guys very much!
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> ... I've submitted a PR at
> <https://github.com/tianocore/edk2/pull/1224>, but it seems stuck; I've
> commented in the
> 
>   EDK II CI failing - Do not submit PRs with "push" label set
> 
> thread.

Merged as commit ef3e73c6a0c0.

Thanks to Mike Kinney for the help with mergifybot!

Laszlo