From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web12.152.1662928835102099989 for ; Sun, 11 Sep 2022 13:40:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=LQj7aYJc; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 430FB5C0134; Sun, 11 Sep 2022 16:40:34 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute5.internal (MEProxy); Sun, 11 Sep 2022 16:40:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1662928834; x= 1663015234; bh=yodors2W5YXQTu79vuBXUtQfb9Wc7V3jrSxk3vLIphE=; b=L Qj7aYJcVZeZoe0RXf+uDmguleXzwr9z6OJWZEhVkCzP66SCVtxbS4AFUhimhtZhn 2ddycJklE6lFbQdoKDo56zgXOXMG0wJYy0//OVOPvx3FM/1JKF++WYxRBC5Fx+7A 4nQrRlgl51W9gVctopi1tsBb2BWOBmwG3DHuRjMjEa7w/qtfXiSE6Tph7edEpetu iPsDySgRRVMMkXYQoEAUSGh/XNwrOK0wgB/I36N1w50KW/BkQ0NsYHtGu9L2La+H /vUIDhUeO2EaWO6pund1gKYW3iZGg8b6d7r9vnbSD1OjmZxzJUGRAFL1OvoOd6Xv k/t2uhJQ1qHUFeRfBwwrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1662928834; x=1663015234; bh=y odors2W5YXQTu79vuBXUtQfb9Wc7V3jrSxk3vLIphE=; b=W4xfHKGM75249cyt3 RucGU4yGSoPxTiJI7yjh53uDErkl/9ejTMKCe7Q/zJto+Gxrbp/tEFiVT/CBxari RADEbxtlg33fpzl/S8WAcrq+16vC5+2tkvQIKSUJM0Ux+E+xPg7W6IJXTuaeKR7F 7btSiW0Z8dcDPM/CJcAmoJZ9wuLpHtFUOLd9rn1Hvf9kb6GrExxyIyYRZ0UIKSNA 7lj2OCT1pVwKWo8gqMM8sXCSm+96R/r53b3RzHVbira/1YmDpNyMHOnUwGXO+ee/ A7VVZlKlDsvvSfM1+mMS0pKN6NOeDQkHr27517cyzUhDA6bbp7ZkbycOsxMcahC8 9MI7A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedutddgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepfdft vggsvggttggrucevrhgrnhdfuceorhgvsggvtggtrgessghsughiohdrtghomheqnecugg ftrfgrthhtvghrnhepffevheeivddvffffhfekleehffegledtteetheeiueeivdelteeh hfduvdehiefhnecuffhomhgrihhnpehgrhhouhhpshdrihhonecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdr tghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E1A122D40071; Sun, 11 Sep 2022 16:40:33 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-927-gf4c98c8499-fm-20220826.002-gf4c98c84 Mime-Version: 1.0 Message-Id: In-Reply-To: <40a8842e-76a8-f5e2-dc42-1c28c70be83f@arm.com> References: <20220911191522.366209-1-rebecca@bsdio.com> <40a8842e-76a8-f5e2-dc42-1c28c70be83f@arm.com> Date: Sun, 11 Sep 2022 14:40:33 -0600 From: "Rebecca Cran" To: devel@edk2.groups.io, thomas.abraham@arm.com, "Ard Biesheuvel" , "Sami Mujawar" Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ARM: Update Morello and SgiPkg for ARM_CORE_INFO Mpidr change Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable This is more correct than it previously was, but is still wrong for platfor= ms where the cluster is in Aff2 and the core in Aff1. I haven=E2=80=99t che= cked which those are, but it=E2=80=99s at least the Neoverse N2. Rebecca On Sun, Sep 11, 2022, at 1:49 PM, Thomas Abraham wrote: > On 11/09/2022 20:15, Rebecca Cran wrote: >> The ARM_CORE_INFO struct now has a single Mpidr field instead of >> separate ClusterId and CoreId fields. Update mCoreInfoTable in >> PlatformLib.c in Morello and SgiPkg to match. >>=20 >> Signed-off-by: Rebecca Cran >> --- >> Platform/ARM/Morello/Library/PlatformLib/PlatformLib.c | 8 ++++---- >> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 2 +- >> 2 files changed, 5 insertions(+), 5 deletions(-) >>=20 >> diff --git a/Platform/ARM/Morello/Library/PlatformLib/PlatformLib.c b/Pl= atform/ARM/Morello/Library/PlatformLib/PlatformLib.c >> index 52318a62911a..894a53c9ca01 100644 >> --- a/Platform/ARM/Morello/Library/PlatformLib/PlatformLib.c >> +++ b/Platform/ARM/Morello/Library/PlatformLib/PlatformLib.c >> @@ -10,10 +10,10 @@ >> #include >> =20 >> STATIC ARM_CORE_INFO mCoreInfoTable[] =3D { >> - { 0x0, 0x0 }, // Cluster 0, Core 0 >> - { 0x0, 0x1 }, // Cluster 0, Core 1 >> - { 0x1, 0x0 }, // Cluster 1, Core 0 >> - { 0x1, 0x1 } // Cluster 1, Core 1 >> + { 0x000 }, // Cluster 0, Core 0 >> + { 0x001 }, // Cluster 0, Core 1 >> + { 0x100 }, // Cluster 1, Core 0 >> + { 0x101 } // Cluster 1, Core 1 >> }; >> =20 >> /** >> diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c b/Pla= tform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c >> index fa006320025b..b9ec998d8ef4 100644 >> --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c >> +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c >> @@ -20,7 +20,7 @@ STATIC SGI_NT_FW_CONFIG_INFO_PPI mNtFwConfigDtInfoPpi; >> STATIC ARM_CORE_INFO mCoreInfoTable[] =3D { >> { >> // Cluster 0, Core 0 >> - 0x0, 0x0, >> + 0x000, >> }, >> }; >> =20 > > Reviewed-by: Thomas Abraham > > >=20