From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E68309413C9 for ; Wed, 31 Jul 2024 08:21:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+dJZ4h7TvCgV9Uikt07dKhv/SDvY4c5qoD4sliuuBPQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1722414111; v=1; b=xiqaJPLshrZx6UxtdAGhTuvi71Nbh39epWWVaqXBuspehFhnThQP1dQPgYwYzG66Pa/9/UOS /ktWYhf+yEm6KbDxQWbgyXjaeHfF18ClaGI5wqaWhhnIQTzAeLeBqX3KIut45X5j1UCa8RxR34Q 8f//OACO92HfkLH0XxDg652cNOutizls4iD2yaHxD3Rr9UX7IYHvy9dyE7BW4sw772lyeZJ6aXk um7B32EdloLsmp+EngCFbMlCfQAcQoI3To/2my4ld/RQQGWlT0by1D7z7E2qPhMT8Net8ltakPc muyPX66pYND6bThIAYyJ6mdq+36Uuw47v5WnxPe3K/WTg== X-Received: by 127.0.0.2 with SMTP id r78vYY7687511xU7CatzrHNN; Wed, 31 Jul 2024 01:21:50 -0700 X-Received: from DM5PR21CU001.outbound.protection.outlook.com (DM5PR21CU001.outbound.protection.outlook.com [52.101.62.129]) by mx.groups.io with SMTP id smtpd.web10.38137.1722414104529138728 for ; Wed, 31 Jul 2024 01:21:44 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB6151.prod.exchangelabs.com (2603:10b6:510:18::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19; Wed, 31 Jul 2024 08:21:41 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%3]) with mapi id 15.20.7807.026; Wed, 31 Jul 2024 08:21:41 +0000 Message-ID: Date: Wed, 31 Jul 2024 15:21:31 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH RFC edk2-platforms 3/5] Platform/Ampere: Switch to unicore SEC implementation To: Ard Biesheuvel , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Rebecca Cran , Chuong Tran , Wenyi Xie , Peng Xie , Ling Jia , Yiqi Shu References: <20240729122215.400402-1-ardb+git@google.com> <20240729122215.400402-4-ardb+git@google.com> From: "Nhi Pham via groups.io" In-Reply-To: <20240729122215.400402-4-ardb+git@google.com> X-ClientProxiedBy: SG2P153CA0042.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::11) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|PH0PR01MB6151:EE_ X-MS-Office365-Filtering-Correlation-Id: 596819ed-0b64-468c-7143-08dcb139ce26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?VGRYeGdEeVE1eEI0S2FuOHU2WVNnR1FSOFNxZFBBdWIwUXAyVXJWdk05MWR2?= =?utf-8?B?VW9PdEJjVTJ2N252WVpCMEFYbEo3SWFuRUxiMUZQc09Mbzg5cXlKdDJCYVZi?= =?utf-8?B?aDU5OTQ0NGo5YTdFNnJ5K0NUeVN4S3p5dmZLZXhkUWNLMTY1bXZsM2hQdlFK?= =?utf-8?B?SEtTV2VYdzBGWkVDUXpvT3pkdVVoR3F5K0REMGN2RzZTeFdUYUZIKzBxU2lh?= =?utf-8?B?c0w4bHhYaUlqL3puWUhlazNHUkViRk5PTDM0OTdlejdjRFI0TlVCQlkzY1M5?= =?utf-8?B?dC9TZndSMldMb0NIYk5lbVhBMEdDS1RkMnk5VjZzdzJ6WVJMMTUrTVpDblBo?= =?utf-8?B?YTloWllRZUNpaThwaW1PQVdmOEtoZWRac1daSHE4eHBkcVBLV0dpaElmSE52?= =?utf-8?B?cXhRWHhuVHRNbE05N2Qva0NzM3RGZDJwRVdrM1NMc1dMQmxtV0haLzQ3dDJB?= =?utf-8?B?R0JFUHpyMVpnOHpObjAyTkVXZTlNQlBVTmVPWnRiYkxlczErYi93ZWpDZUF6?= =?utf-8?B?N25ZNEMrSUxoNXZveVY1RVVwQTBLdjhEZ3U0VEMrZFZGcEk2aVdCOUhNT3ps?= =?utf-8?B?NnJlZXhEY3g3R1FOeXN5WHlEWVFnMXd4MTlUb01tWERJWWMvWkFtSnozMkNL?= =?utf-8?B?MWZHRDg0QzZWRzN3bCtOZzJWa2lVNjhOa2dLNDE0YUFHT254QkZYZHhabSt1?= =?utf-8?B?NEFHNnBxdEozS0QyaVAzKzJnOW96SVYyOWF0N3o4aDNWd1k2SUtIeDFxZzJ5?= =?utf-8?B?cW1LaURwMUdPVWZzejkwSnJKNWZ5aFBCRTV3MlZrNjV2TXhGYTQ0OEUwQlBq?= =?utf-8?B?bXBOWXlKTkxqUjNTTWV4RmVtYk1KNFByNWhPcyswRmZZZjVvTC9hRmMrT2Fk?= =?utf-8?B?YjUrUHE1VWNrWlBMRVdGNVpQSXEzbXBRTmQyempBR3JyOEkrRGdBbXdRelU2?= =?utf-8?B?QUo2c3dYWEJBeHNJK1N2U1piV3BiQXFUWENKckRlT01WMm44aGtWVDQrRVRx?= =?utf-8?B?c2FjYThJWlBSTXYyWUxzN0R3ZFkzZWQrTjA5MWVzZjYrRFNyOTVoQzM0amFr?= =?utf-8?B?dS9jYVhqRWFoV2lwWUhHbWs3aEVYL0pGR1FHbHBUU2t2UFd4TzRGZ1F5SllD?= =?utf-8?B?MXNwTUJuLzllK29mQ3dsTTYrN05CaUhrZkFTVHl5WnRUT09vVlBaU3paL0d6?= =?utf-8?B?OWxRenAvVUFlSEdMWjlpbldpK09rY2VqWC9Na1hidjNLVDZiTUhnQ3hyeXE2?= =?utf-8?B?UTlLT25FRDNkUnRxZzBacjY3T1VkQWZiRk5qejR6ODA3b0xoYWh2N2ZxU1po?= =?utf-8?B?TGg5MHRhZlAyOUp5QjczbWVWR3pJSTBtNDlKUjFrVU5UTWVNOEtQT3ZYMWFi?= =?utf-8?B?RWVoY3EvejZWakhuYjBBc1I4dFhLNmpoNkZpWE9VVHcwR2kwU1hQQWxGL0JB?= =?utf-8?B?UEIrRE1jVnh0NlRGL1IwVlZUYjhWczZxUlhjTzZNTWxBd0w0NDVmL2J2dW0y?= =?utf-8?B?NUs5UlBja3F3dVdBUXBvT3V5QVluNExrd2VpeUMyU2FmY3ozY2lZZk5JUW1M?= =?utf-8?B?bTZpK0xQQU1ZaGFyVnR4bkxRUFRsK1k5ZzZTdXNKSXpJNFBXU25HS01NekxT?= =?utf-8?B?T1FYWk41YzR5cFlTa2JRTjNzd2JkWXBXc0RRcEk4a082T3A0cGlTdGNiQklS?= =?utf-8?B?Ti9iTGhidkJQdGNRTlBFT1hDSjI0YmhWbkVJWkgrS2xKMjBTUkJlWW81bkow?= =?utf-8?B?VmN6UDhrWFlXWmE4NDhqdVVJUjZVU1lQdHlpd0ZqckhSZHNURjl3aUxVNzY5?= =?utf-8?B?ZUxGR2hyOHhYeXZhYVFnZz09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjFYbkdVWFRLTjhWa1IzZlgzSGNscFdnVmhvMmR0MklHSEc1NHVyTnVqQ1hx?= =?utf-8?B?TWNsRWU0aVdXeWEva3JmUCtobTBIVDh5b1N5NDJ2R2pVL1NiRU9icmNjQXFD?= =?utf-8?B?MERHRlN1a0RjRUdTNng5ckU1azErY2Jzam5NWFVleDVCWUFDRlpVVlVNRGVH?= =?utf-8?B?eFpKQ1d2VUVWb0lXZjRMWGg0c3ZwWmpXaHkzQkgrdXBSeFNwSU5GZVVRTjQw?= =?utf-8?B?TDFpanZ4aHlSa1FVNldsQTZyeitXVUFsS1dUY3g4RFd3WG9WdlZIc3dQcWh3?= =?utf-8?B?SXYvcVNSUXROM1REMy94aFdYeUtJVzk5V1VILzlBMFpSWVdyM0tGdFFNMjdl?= =?utf-8?B?emY1SnZkSGtsQjVSQVR1bEZPNzRLRXovVXoyR0MzdDBzSFR3UkdRQWV0eVJk?= =?utf-8?B?dk1uVnRpd0NrUng0NVRQcEVCY2J1ZWRqS3R5OUlpbklYd2hXdG1DTXBRMnhE?= =?utf-8?B?Y2loTHFDL3M1VFltZDBHZ0VVbDNGcktRdEZCOGFOTkRrNnBEbkg3cHZJNWFi?= =?utf-8?B?YUFERDd3MzFtc3AxdThadE5iUzd3OUh3dUJiWkdnS3p0eGRhWXQwSUxDMlR6?= =?utf-8?B?UExDeXl1WUZ2UGViV09Td2krdHRRMjFVNitBakw5MUUzZHRjZlpJME9ianFo?= =?utf-8?B?UnMvT2RSQzh4Vm5sVmJ6STNJSkNxdzZtN3BwWDhOTkZ0OVNKcjlTYUFxanNK?= =?utf-8?B?RmJqUG14T0FSNXo0ckp0dyszS2RmNjhPb09FTnliNEZoVEJhSXVxbkwrTDVF?= =?utf-8?B?bkZjcjZ5angraG5aOXVZRzNvdk92dVRjckd4Y3hKUThoNThSb3pmZ1VydDdD?= =?utf-8?B?bS9rVDdxeHV6dkdnMmtaczFJQ0FyV3NreWZDeXM1VVRRVHlGZmErTWxDYkpQ?= =?utf-8?B?ZStqaTJZWVhqcEpyeWlPdURlcFZsS3dqNVVtdnZkK3pRdGM3SjlvYWwraHZL?= =?utf-8?B?L1ZEOVV2c0hnYlEyNGllUk9NYlBGWVpMYU50Yy9lUXY4dnVqREdWVjV3elkw?= =?utf-8?B?WXdJR0M4a3M1MzU3YzhLaU5JRGQyeTJKL0tLUjBBTGtRT3E0WFVxUmtYVEZM?= =?utf-8?B?N3RxNm16QnJwalk2NjZlcWJaOHErN3ZMejhnVUVXK0d2U1NheXVPazRqMGdW?= =?utf-8?B?ZWhKejFFQkNoWTU4ZUNMNVkwbXZ2Mk50M3ArYk1iR0wzT1Q1cXBtQ3V1S3E2?= =?utf-8?B?OTRwWjl6bUVqNGZrVDhQYTZOeE41blAwTXZpTmdrZnVuV2I5V1E0cWpTczQx?= =?utf-8?B?Q1ZVU1UzZ3BWd0RaRjVEcDVCT3dCNUVKckIwYVZzS3Q1Rll4OFJHRk02cHlw?= =?utf-8?B?ZHYrb0V2R2JsOWFvRlEyWWRxMGltcWRCOFFpd0lmUWJ0TVZ3MlVqN21kQ1hq?= =?utf-8?B?aEpGSUZ3SDJRaFkxaTNBeDUwbW41eHJkRDB2ZGs1OTRCRGNoNzV1L1FOVUYv?= =?utf-8?B?WC9pTUlqL2IvcmF2dzN5V3VXc3lGQUFSTHZOaXJIQ2QxR3g5QUhBYkFFM0w3?= =?utf-8?B?ZDZjMlVZYjVvY3FESnRoMTZ2TEhvcVp4d3NkeG9ZMFRQMm1OM0Zhc2FlTTNw?= =?utf-8?B?WVoxNWhLdFJvQld4bTZlSWVrTlJLNkNtQ3dqMVkybnVuSXpsZ2pCc0JpNjNI?= =?utf-8?B?M01zVjV3Q2NwZTI2eWFUbWlUcUFiRVdqdmE3eTZ0Q0JZY1AxTmR2YzNuU1pH?= =?utf-8?B?Z1FIeSt3YzRMcTVsSWxLOTdRRXBTbjRvWmtaNExmQ3VkdWwrczA4b1BoWGNO?= =?utf-8?B?TE9zMWVRWEFYSEt4ZlZXNzdSR2I4eUFhOURHSFJXalF5dkJLTWxmNndzdkpZ?= =?utf-8?B?ZjBPVE1LMjI0K0xwZm11d3JmeWliODRzb3MweGRlVTNDSFJ5ZGN4T2Nnazg4?= =?utf-8?B?cmFmRUtrS21XU0dqb29kOEJMWlRpTnA2czNaWDNCTG43c0cvcWpyVzY2VHJO?= =?utf-8?B?amNreTZFckhVWDNrYkowaGthcUMzYzJuU3BVMXF2d21nLy8rd2diM2lDa004?= =?utf-8?B?eWQrV1FoaENnUE5PaHFjSjVKRXRoQ3ZJeG9xQ2V1cHVKUnZOSk5ieThBWFFV?= =?utf-8?B?ZTlkczNrVjMvd1FSR1JHdkhnY1dMSkpBc0Z5RTJhVU1ucTltd0o5dlJya29Q?= =?utf-8?B?akNxZkh0a1hVVWJ3SG14MUVPUDJjLzV1bHNkbDJXWjhGYnVKc3luMHVsSXhu?= =?utf-8?B?V2c9PQ==?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 596819ed-0b64-468c-7143-08dcb139ce26 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2024 08:21:41.1915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NFdj5RaT1i6tKezocGRuE+J9Wbfhn8zv++aGUYJGvfobqP8mH95pK04JRHrFv8YBE4V9AqbMqYxDH5SZvJsD90mLV193fTZ4BtE9PL2QKL4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6151 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 31 Jul 2024 01:21:44 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tQzmulVl5tOpytmNkJw3senFx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=xiqaJPLs; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Ard for the clean up and maintaining the platforms's updates. Reviewed-by: Nhi Pham Tested-by: Nhi Pham Regards, Nhi On 7/29/2024 7:22 PM, Ard Biesheuvel wrote: > From: Ard Biesheuvel >=20 > Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and > only enter the execution level where UEFI and the OS live using a single > CPU. >=20 > This means using a SEC implementation of the MPCore variety is never > needed, and in practice, those drivers don't work correctly unless an > older version of the GIC is used (v2), which only supports up to 8 CPUs > and is therefore rare on server silicon. >=20 > So switch to the UniCore flavor, which should be functionally equivalent > if only a single CPU runs the UEFI firmware. >=20 > Signed-off-by: Ard Biesheuvel > --- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +----- > Platform/Ampere/JadePkg/Jade.fdf | 2 +- > 2 files changed, 2 insertions(+), 6 deletions(-) >=20 > diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silic= on/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > index 977e4c4c238d..bec743e2c453 100644 > --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > @@ -390,12 +390,8 @@ [PcdsFixedAtBuild.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 > =20 > - # > - # Stacks for MPCores in Normal World > - # > gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x91100000 > gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x20000 > - gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x1000 > =20 > # > # Maximum memory region that fits into the 32bit address space > @@ -525,7 +521,7 @@ [Components.common] > # > # PEI Phase modules > # > - ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf > + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf > MdeModulePkg/Core/Pei/PeiMain.inf > MdeModulePkg/Universal/PCD/Pei/Pcd.inf { > > diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/J= ade.fdf > index 127e4401f69b..6d1af3570287 100644 > --- a/Platform/Ampere/JadePkg/Jade.fdf > +++ b/Platform/Ampere/JadePkg/Jade.fdf > @@ -148,7 +148,7 @@ [FV.FVMAIN_COMPACT] > INF MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei= .inf > } > =20 > - INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf > + INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf > INF MdeModulePkg/Core/Pei/PeiMain.inf > INF UefiCpuPkg/CpuIoPei/CpuIoPei.inf > INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120136): https://edk2.groups.io/g/devel/message/120136 Mute This Topic: https://groups.io/mt/107628986/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-