public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Leif Lindholm <leif@nuviainc.com>, devel@edk2.groups.io
Cc: macarl@microsoft.com
Subject: Re: [RFC 0/5] EmbeddedPkg/PrePiLib: rework FfsProcessSection
Date: Thu, 2 Jul 2020 08:22:42 +0200	[thread overview]
Message-ID: <f94a77f1-1480-8bcf-c79c-937c45521352@arm.com> (raw)
In-Reply-To: <20200701200118.3972-1-leif@nuviainc.com>

On 7/1/20 10:01 PM, Leif Lindholm wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2820 describes a build
> failure caused by misanalysis by the compiler, but the problematic code
> was pretty grotty, so here's an attempt at cleaning it up.
> 
> This set can also be accessed at:
> https://github.com/leiflindholm/edk2/tree/embedded-fwvol-cleanup
> 
> Note: this code is only build tested.
> 
> Leif Lindholm (5):
>    EmbeddedPkg/PrePiLib: style cleanup in FwVol.c
>    EmbeddedPkg/PrePiLib: drop else if after return
>    EmbeddedPkg/PrePiLib: refactor IS_SECTION2() handling
>    EmbeddedPkg/PrePiLib: drop spurious re-init of CompressedData
>    EmbeddedPkg/PrePiLib: break section extraction info into helper
>      function
> 

For the series:

Tested-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>


>   EmbeddedPkg/Library/PrePiLib/FwVol.c | 214 ++++++++++++++++-----------
>   1 file changed, 125 insertions(+), 89 deletions(-)
> 


      parent reply	other threads:[~2020-07-02  6:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 20:01 [RFC 0/5] EmbeddedPkg/PrePiLib: rework FfsProcessSection Leif Lindholm
2020-07-01 20:01 ` [RFC 1/5] EmbeddedPkg/PrePiLib: style cleanup in FwVol.c Leif Lindholm
2020-07-01 20:01 ` [RFC 2/5] EmbeddedPkg/PrePiLib: drop else if after return Leif Lindholm
2020-07-01 20:01 ` [RFC 3/5] EmbeddedPkg/PrePiLib: refactor IS_SECTION2() handling Leif Lindholm
2020-07-01 20:01 ` [RFC 4/5] EmbeddedPkg/PrePiLib: drop spurious re-init of CompressedData Leif Lindholm
2020-07-01 20:01 ` [RFC 5/5] EmbeddedPkg/PrePiLib: break section extraction info into helper function Leif Lindholm
2020-07-02  6:22 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f94a77f1-1480-8bcf-c79c-937c45521352@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox