From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.1085.1593671948342846525 for ; Wed, 01 Jul 2020 23:39:08 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F297A1FB; Wed, 1 Jul 2020 23:39:06 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 428273F73C; Wed, 1 Jul 2020 23:39:06 -0700 (PDT) Subject: Re: [RFC 0/5] EmbeddedPkg/PrePiLib: rework FfsProcessSection To: Leif Lindholm , devel@edk2.groups.io Cc: macarl@microsoft.com References: <20200701200118.3972-1-leif@nuviainc.com> From: "Ard Biesheuvel" Message-ID: Date: Thu, 2 Jul 2020 08:22:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200701200118.3972-1-leif@nuviainc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/1/20 10:01 PM, Leif Lindholm wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=2820 describes a build > failure caused by misanalysis by the compiler, but the problematic code > was pretty grotty, so here's an attempt at cleaning it up. > > This set can also be accessed at: > https://github.com/leiflindholm/edk2/tree/embedded-fwvol-cleanup > > Note: this code is only build tested. > > Leif Lindholm (5): > EmbeddedPkg/PrePiLib: style cleanup in FwVol.c > EmbeddedPkg/PrePiLib: drop else if after return > EmbeddedPkg/PrePiLib: refactor IS_SECTION2() handling > EmbeddedPkg/PrePiLib: drop spurious re-init of CompressedData > EmbeddedPkg/PrePiLib: break section extraction info into helper > function > For the series: Tested-by: Ard Biesheuvel Reviewed-by: Ard Biesheuvel > EmbeddedPkg/Library/PrePiLib/FwVol.c | 214 ++++++++++++++++----------- > 1 file changed, 125 insertions(+), 89 deletions(-) >