From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web12.30292.1601885883876010367 for ; Mon, 05 Oct 2020 01:18:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EJdeZTUF; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601885883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EJ51u2wfTt1syTLtQVy1H/emZ6lgugIPMb5mml0myhs=; b=EJdeZTUFLWIaaQyVRvsGy1CCrQMPQrWzMI7s4F0iDmV3ZcwimoA3xHid3fyC9IZcCfADI/ oW0lSFMQ2QVD4/KgtLuxVWkoGo2knc9L+Rmjw+VEX8vR6XbVBLoVSgzMxEP1VuUOyF1ZQP clHk7oBsBVQjMwRqesisL77kF/i35ys= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-522-PYvDMvWcMiqSv8hWTAZqcw-1; Mon, 05 Oct 2020 04:18:01 -0400 X-MC-Unique: PYvDMvWcMiqSv8hWTAZqcw-1 Received: by mail-wm1-f71.google.com with SMTP id c204so2153447wmd.5 for ; Mon, 05 Oct 2020 01:17:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=EJ51u2wfTt1syTLtQVy1H/emZ6lgugIPMb5mml0myhs=; b=Cv1SzD2qDw0490r3aOqwNGSUMocYJCs0sBoTaMN4LWIVUKb26pNRthqunRFmbLAr5A 6NjBgQBX+hrnOLnAygseadGo07L6VRKOMlojF7BwzLhZYP1CPAcM2jj1lzzj0BYfI5AN 71VFZbwsJjyXzBRs7kl6/7spEQ3h7sdhVZvq+hKlB/XzJXvxqeM8JFMcRvszvrl9gZXR TlYxvg3sgaHknoNLGoChCarWGuEXHHEUkoMAj4YzhJLEqU/ultlJ8yf894kRMbfP0P9g Uqbp+5V0Leoac+3DV4eEgZKmgZpW/GE+h7dSW0OcTeppIg5boC15Cy5Mquhg37BC/8GC 6pLg== X-Gm-Message-State: AOAM532IrbQ6HUQk3pPDsYIG0Yb0VhllZDi7ve4Du0saf7TFum0u7Ohf t6Gx9bzEGvgWaeIwvlmX6GGwymtPKlpUluN5A94LTi3RaaWvJ8U5XFrxHi8BuCdNKjpG8Nfom2B JCkg/wJ/KIfchbw== X-Received: by 2002:adf:c3c2:: with SMTP id d2mr1781174wrg.191.1601885877805; Mon, 05 Oct 2020 01:17:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9AIuS1nmDt/Uz3BWECKWb8xxmfTkqv/LH79mHPTP+dA6DzRmAgnBcKT7enAtZ7/2z6Rw67w== X-Received: by 2002:adf:c3c2:: with SMTP id d2mr1781154wrg.191.1601885877611; Mon, 05 Oct 2020 01:17:57 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id t6sm13204815wre.30.2020.10.05.01.17.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2020 01:17:56 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations To: devel@edk2.groups.io, leif@nuviainc.com Cc: Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu References: <20201001183712.1738-1-leif@nuviainc.com> <20201001183712.1738-4-leif@nuviainc.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Mon, 5 Oct 2020 10:17:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201001183712.1738-4-leif@nuviainc.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/1/20 8:37 PM, Leif Lindholm wrote: > There may be architectures on which there are benefits to > eor r0, r0(, r0) > but ARM was never one of them. =) Reviewed-by: Philippe Mathieu-Daude > Change to more readable > mov r0, #0 > instead. > > Signed-off-by: Leif Lindholm > --- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 +- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)