From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by mx.groups.io with SMTP id smtpd.web10.3107.1622061706493274143 for ; Wed, 26 May 2021 13:41:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=xmission header.b=Qv8GEo+l; spf=none, err=SPF record not found (domain: bsdio.com, ip: 166.70.13.231, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=9X7gcEpuf1Cpfw8USIn4BknR47oIjNMSUUXF8jweOj8=; b=Qv8GEo+lcLOSJf6nCqmkuQnsDN nHKgrsuSIX1S4R13zJY1DVG8fRPThcOZZYg0by4QK+difOBpoWEKpQ89Z1LptSmwnF68BuaYm9/Lz mWJuFJmfllLwo6eabkzqFes61Hdlxs4cNRFp0+DQckAOyI9COtTMqnbO6quLWsWn6Tmw=; Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lm0LT-00BU48-FD; Wed, 26 May 2021 14:41:39 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]) by in02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lm0LR-00ANhc-QI; Wed, 26 May 2021 14:41:38 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id 8A7A312808A1; Wed, 26 May 2021 14:41:37 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NjVcNqTdUtld; Wed, 26 May 2021 14:41:37 -0600 (MDT) Received: from photon.int.bsdio.com (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 4AB031281728; Wed, 26 May 2021 14:41:37 -0600 (MDT) To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen , Peter Grehan , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-25-lersek@redhat.com> From: "Rebecca Cran" Message-ID: Date: Wed, 26 May 2021 14:41:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-25-lersek@redhat.com> X-XM-SPF: eid=1lm0LR-00ANhc-QI;;;mid=;;;hst=in02.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=none X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa02.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,NICE_REPLY_A,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, TooManyTo_001,XMNoVowels,XMSubLong,XM_B_Unicode,XM_B_Unicode3 autolearn=disabled version=3.4.2 X-Spam-Virus: No X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.0 XM_B_Unicode BODY: Testing for specific types of unicode * 0.0 XM_B_Unicode3 BODY: Testing for specific types of unicode * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; IP=ok Body=1 Fuz1=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * -0.0 NICE_REPLY_A Looks like a legit reply (A) X-Spam-DCC: XMission; sa02 1397; IP=ok Body=1 Fuz1=1 X-Spam-Combo: **;Laszlo Ersek , devel@edk2.groups.io X-Spam-Relay-Country: X-Spam-Timing: total 492 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 3.7 (0.7%), b_tie_ro: 2.5 (0.5%), parse: 0.92 (0.2%), extract_message_metadata: 15 (3.1%), get_uri_detail_list: 2.0 (0.4%), tests_pri_-1000: 9 (1.8%), tests_pri_-950: 1.01 (0.2%), tests_pri_-900: 0.80 (0.2%), tests_pri_-90: 71 (14.4%), check_bayes: 70 (14.2%), b_tokenize: 8 (1.6%), b_tok_get_all: 8 (1.5%), b_comp_prob: 1.64 (0.3%), b_tok_touch_all: 49 (10.0%), b_finish: 0.79 (0.2%), tests_pri_0: 379 (77.0%), check_dkim_signature: 0.49 (0.1%), check_dkim_adsp: 35 (7.1%), poll_dns_idle: 34 (6.8%), tests_pri_10: 2.7 (0.5%), tests_pri_500: 7 (1.5%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 24/43] OvmfPkg/Bhyve: make "PcdPciDisableBusEnumeration" Fixed-at-Build X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 5/26/21 2:14 PM, Laszlo Ersek wrote: > The Bhyve platform specifies the dynamic access method for > "PcdPciDisableBusEnumeration" needlessly. > > After the DSC file sets the PCD to TRUE by default, the PCD is never > written again. In particular, the > "OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf" file references the PCD > superfluously. > > Make the PCD Fixed-At-Build, and remove the PCD reference from the INF > file. > > (Note that further simplifications are possible in > "OvmfPkg/Bhyve/AcpiPlatformDxe", but those are out of scope for this patch > series.) > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index 7d9e88040000..896b62881bdb 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -428,12 +428,13 @@ [PcdsFeatureFlag] > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > > [PcdsFixedAtBuild] > + gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE > gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10 > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0 > @@ -526,13 +527,12 @@ [PcdsDynamicDefault] > # ($(SMM_REQUIRE) == FALSE) > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0 > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|800 > gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600 > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0 > gUefiOvmfPkgTokenSpaceGuid.PcdPciIoBase|0x0 > gUefiOvmfPkgTokenSpaceGuid.PcdPciIoSize|0x0 > diff --git a/OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf b/OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf > index 12203e9f804d..739d63098b1e 100644 > --- a/OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf > +++ b/OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf > @@ -83,13 +83,12 @@ [Pcd] > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDecompressionScratchEnd > gUefiOvmfPkgTokenSpaceGuid.PcdQ35TsegMbytes > gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved > - gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode > gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable > gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable > gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrMask > gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy Reviewed-by: Rebecca Cran