From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 827B121103974 for ; Thu, 23 Aug 2018 02:51:48 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id k19-v6so2450040pfi.1 for ; Thu, 23 Aug 2018 02:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Plqa5m5e0RZkZxW9RmbQa8R1JHwmL8W3WJHPmHNXswg=; b=NgnLWkS1+FJpZBhHH24WklRsMITkifNGvexNCMlsJm/5Rq9ikEgEJinA1BXpg+JVff jCCERsNsBKUhb9BPdjnN031IbEPi0glmRJ1/JB3qAdgvLp7dmvWEVLDVt93anrUyGj7N orI4BfxEK3E8213DpfgeC7zyYW7NtcffbNVFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Plqa5m5e0RZkZxW9RmbQa8R1JHwmL8W3WJHPmHNXswg=; b=s7kOzYBH1rnH5IBWm2EAiZuFtU3SOPlZnWpQPAsC+Owrz3L7s6SB7U9ftGnVIcl6dp HzDkhVG4NU7j2ofy8CD0tmtQiG4dupejrfcH9bRshD1Yg6TSixtRwA5hy+foY15cxcMB 2wcr7nd0EnyTld2Sbof+NS+V4hgRCb7mM2BeOAP4JxPX41aizMuZKHqG0mJCDhEMryqG Ml/IPEPCACGhLU4RFMDr+/HgxKL8fBmjOAYRfqqU8Y/kwD+J+568C/KP/FaaXAkdu+N5 YzjwxhJ8kK4edVhL5VUQ0tGLRBNizbKGzFJc2IrnRhNv3AZ5XHohX2N5aP8/3CVamFp7 TRYw== X-Gm-Message-State: AOUpUlF24gLYKOkoUVBxpAaYWq1tFPby6Lsc2kgCDu7dRZ+4SK23hCxC hCTZvellb4OZAQ4YG8ttzit1Eg== X-Google-Smtp-Source: AA+uWPxokLhT9szM24KsJKyHe0EeRzEahVImLEhlxsod5q4Wa6RQjmPJFIek2C85iLY/uwwr29DqSg== X-Received: by 2002:a62:c288:: with SMTP id w8-v6mr61698421pfk.92.1535017907994; Thu, 23 Aug 2018 02:51:47 -0700 (PDT) Received: from [10.84.0.214] ([64.64.108.140]) by smtp.gmail.com with ESMTPSA id r81-v6sm5781690pfa.18.2018.08.23.02.51.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Aug 2018 02:51:47 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org References: <20180814080903.50466-1-ming.huang@linaro.org> <20180814080903.50466-36-ming.huang@linaro.org> <20180822153336.mllu5y6fr72surxn@bivouac.eciton.net> <20180823094448.il72wdbebxh2lcuu@bivouac.eciton.net> From: Ming Message-ID: Date: Thu, 23 Aug 2018 17:51:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180823094448.il72wdbebxh2lcuu@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v2 35/43] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 09:51:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/23/2018 5:44 PM, Leif Lindholm wrote: > On Thu, Aug 23, 2018 at 03:39:57PM +0800, Ming wrote: >> >> >> On 8/22/2018 11:33 PM, Leif Lindholm wrote: >>> On Tue, Aug 14, 2018 at 04:08:55PM +0800, Ming Huang wrote: >>>> Add some Lpc macro to LpcLib.h for D06. >>>> >>> >>> Unaddressed feedback from v1: >>> >>> I have no issue with this patch, but can you explain when these macros >>> are intended to be used? And if in this set, move this patch >>> immediately before the patch than needs it? >> >> These macros are not used in edk2-platforms, used in HwPkg/LpcLib. > > Then why are they not in HwPkg? I will drop this patch and move those macros to HwPkg. > > / > Leif >