From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.66; helo=mail-wr1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D31A12119620A for ; Wed, 28 Nov 2018 07:02:30 -0800 (PST) Received: by mail-wr1-f66.google.com with SMTP id v13so23168344wrw.5 for ; Wed, 28 Nov 2018 07:02:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XsjzvXXrlXbD/vhg2EHncN9Y164VEhOi9rFXLvPVzbk=; b=Jj7/ARlpH/IOA+N4cNbLAG8eF01dLxZzjyjuAPiaQtswbp4BfHI4Ce0h2ivEMGPPdi u4lMO6cIoj/CNJMI7syBEBMKZzkmzCGfextcJY1WdtJ7LAby6Fh+3Ux1AePJZ8TaVtng bbfXPqfKeLPB2EvOC+OW6izUxj4ZCyE1oQAq352UK4MiHEJcQpR03CMuqFv/DRF1i/FK f3pzdk+2aJOVB3zumaJSUdH0RtIvkXORINXHA5pPpFn97X02wQcI7wTWqEi47FdBI7yq njXU8YxAEm0wt+hosyxmuF1SsTbJGhWT0YgEwJ/dG2l2JpsHNJT/oGOOoEDDhtqdxhh8 5ZPw== X-Gm-Message-State: AA+aEWZCtz5J7Ki90k9hldfkv8W5Xcwz10mk94ydWSRnyfBVISePryCb QYqR73a1MGJEXIhs5+16JtKSaxicp0HhGQ== X-Google-Smtp-Source: AFSGD/UfPUdj7wOuLxq64FrNld/21w821YMMIlCsKhU5vRfI4OBLuYPqbye7YPnFAzfCIahT/m/A2A== X-Received: by 2002:a05:6000:12c4:: with SMTP id l4mr30263698wrx.134.1543417349500; Wed, 28 Nov 2018 07:02:29 -0800 (PST) Received: from ?IPv6:2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9? ([2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9]) by smtp.gmail.com with ESMTPSA id k15sm7400457wru.8.2018.11.28.07.02.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 07:02:28 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Laszlo Ersek , Leif Lindholm , Eric Auger , Andrew Jones , Julien Grall References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-13-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Wed, 28 Nov 2018 16:02:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181128143357.991-13-ard.biesheuvel@linaro.org> Subject: Re: [PATCH v3 12/16] BeagleBoardPkg/PrePi: base GCD memory space size on CPU's PA range X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 15:02:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 28/11/18 15:33, Ard Biesheuvel wrote: > Derive the size of the GCD memory space map directly from the CPU's > information registers rather than from the PcdPrePiCpuMemorySize PCD, > which will be removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- > BeagleBoardPkg/PrePi/PeiUniCore.inf | 1 - > BeagleBoardPkg/PrePi/PrePi.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/BeagleBoardPkg/PrePi/PeiUniCore.inf b/BeagleBoardPkg/PrePi/PeiUniCore.inf > index 3d72bc5b46e1..53c71d8eafc2 100644 > --- a/BeagleBoardPkg/PrePi/PeiUniCore.inf > +++ b/BeagleBoardPkg/PrePi/PeiUniCore.inf > @@ -86,7 +86,6 @@ [FixedPcd] > > gArmPlatformTokenSpaceGuid.PcdCoreCount > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > diff --git a/BeagleBoardPkg/PrePi/PrePi.c b/BeagleBoardPkg/PrePi/PrePi.c > index 46f63f40c46e..bc9b0c80b84c 100644 > --- a/BeagleBoardPkg/PrePi/PrePi.c > +++ b/BeagleBoardPkg/PrePi/PrePi.c > @@ -110,7 +110,7 @@ PrePiMain ( > BuildStackHob (StacksBase, StacksSize); > > //TODO: Call CpuPei as a library > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > + BuildCpuHob (ArmGetPhysicalAddressBits (), PcdGet8 (PcdPrePiCpuIoSize)); > > // Store timer value logged at the beginning of firmware image execution > Performance.ResetEnd = GetTimeInNanoSecond (StartTimeStamp); >