From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.4117.1662525297621064799 for ; Tue, 06 Sep 2022 21:34:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=YGyG1hpk; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 5FF09204A580; Tue, 6 Sep 2022 21:34:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5FF09204A580 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1662525297; bh=o+5N9DIRvtA8OsDbM7obkuaB16RhuC8px1+e5ny75VQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YGyG1hpkEeiE1BQ/jhQG/xphGa2T3hpo5CGLK9xjndGXWQacw7IUy3YaVY0n3Lz+k 921Rc6iJOjHskTW/h7iazoxys0WECuQ3s+1Fqe01aVH8/q89iPbJN94V9u974SZNAA VFs8uT2IAGGxOR1Rx7Nja36Vi1F5cWM6niP71gx0= Message-ID: Date: Wed, 7 Sep 2022 00:34:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry To: "Chiu, Chasel" , "devel@edk2.groups.io" Cc: "Desimone, Nathaniel L" , "Zeng, Star" References: <20220907031914.397-1-mikuback@linux.microsoft.com> <20220907031914.397-6-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit If that's your intention, yes the CI can allow that. I've pushed a v2 candidate branch of this series here with your review tags provided so far. https://github.com/makubacki/edk2/tree/add_missing_ci_yaml_intel_fsp_pkgs_v2 This patch (v1 5/7) is removed from that branch and the change to explicitly allow this is in the following commit on that branch: https://github.com/makubacki/edk2/commit/b11dd1a4f59a62b90ed401b6b7cad889dd1e013f#diff-ba7b110a0ec2f7f8fabc973b327ddb98a7d65b6a00b544a609a56593e6b87be3R80-R86 If that looks good, let me know and I can send the v2 series on the list after leaving v1 open for a bit longer to collect other feedback and reviews. Thanks, Michael On 9/6/2022 11:49 PM, Chiu, Chasel wrote: > > Hi Michael, > > In this case we intended to provide a single-small function in separate library for platform customization so platforms do not have to override the whole main library instance, and I think it is not valuable to create another H file to hold this single small library function. Is it possible to support such scenario in CI? > > Thanks, > Chasel > > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Michael >> Kubacki >> Sent: Tuesday, September 6, 2022 8:19 PM >> To: devel@edk2.groups.io >> Cc: Chiu, Chasel ; Desimone, Nathaniel L >> ; Zeng, Star >> Subject: [edk2-devel] [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove >> duplicate LibraryClasses entry >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 >> >> The last [LibraryClasses] entry for FspWrapperPlatformMultiPhaseLib points to >> the same entry as FspWrapperMultiPhaseProcessLib. >> >> FspWrapperPlatformMultiPhaseHandler() is the only function implemented in >> FspWrapperPlatformMultiPhaseLibNull.c and it is only called (not implemented) >> in PeiFspWrapperMultiPhaseProcessLib.c, >> so I'd assume: >> >> - Producing library: FspWrapperPlatformMultiPhaseLib >> - Consuming library: FspWrapperMultiPhaseProcessLib >> >> But, the API descriptions do not provide any descriptive information: >> >> FspWrapperPlatformMultiPhaseHandler(): >> >> ``` >> /** >> FSP Wrapper Platform MultiPhase Handler >> >> @param[in] FspHobListPtr - Pointer to FSP HobList (valid >> after FSP-M completed) >> @param[in] ComponentIndex - FSP Component which executing >> MultiPhase initialization. >> @param[in] PhaseIndex - Indicates current execution phase >> of FSP MultiPhase initialization. >> >> @retval EFI_STATUS Always return EFI_SUCCESS >> >> **/ >> ``` >> >> In any case, this removes the redundant header file entry so the Library Class >> Check CI test can pass on the package. >> >> Cc: Chasel Chiu >> Cc: Nate DeSimone >> Cc: Star Zeng >> Signed-off-by: Michael Kubacki >> --- >> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec >> b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec >> index 95ada0f7a151..c3bbc5c45517 100644 >> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec >> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec >> @@ -32,10 +32,6 @@ [LibraryClasses] >> ## @libraryclass Provide MultiPhase handling related functions. >> >> FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProce >> ssLib.h >> >> - ## @libraryclass Provide MultiPhase platform actions related functions. >> - >> FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProc >> essLib.h >> - >> - >> [Guids] >> # >> # GUID defined in package >> -- >> 2.28.0.windows.1 >> >> >> >> -=-=-=-=-=-= >> Groups.io Links: You receive all messages sent to this group. >> View/Reply Online (#93319): https://edk2.groups.io/g/devel/message/93319 >> Mute This Topic: https://groups.io/mt/93518040/1777047 >> Group Owner: devel+owner@edk2.groups.io >> Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] >> -=-=-=-=-=-= >>