From: Daniil Egranov <daniil.egranov@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 1/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Remove calls to ArmDmaLib
Date: Fri, 23 Sep 2016 11:20:10 -0500 [thread overview]
Message-ID: <f9f76849-4a12-f043-338b-7a89995ab868@arm.com> (raw)
In-Reply-To: <CAKv+Gu9TsGU7mCsnqD07MK=J3EYmf5q66iAv=bm-x7X=dt2qcA@mail.gmail.com>
Hi Ard,
On 09/23/2016 02:57 AM, Ard Biesheuvel wrote:
> Hi Daniil,
>
> On 22 September 2016 at 23:33, Daniil Egranov <daniil.egranov@arm.com> wrote:
>> The PCI on Juno is DMA coherent, which means it should not be
>> using ArmDmaLib for PCI DMA.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Daniil Egranov <daniil.egranov@arm.com>
>> ---
>> ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf
>> index de28c80..597154c 100644
>> --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf
>> +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf
>> @@ -36,7 +36,7 @@
>> MemoryAllocationLib
>> DxeServicesTableLib
>> CacheMaintenanceLib
>> - DmaLib
>> + NullDmaLib
>>
> This is wrong. The module .inf lists library *classes* and the
> platform .dsc decides how each class maps onto an implementation (aka
> library resolution)
Agree. However, this is platform specific module and as i understand,
the behavior of it will not change so, I think, having NullDmaLib here
will be appropriate as well. We can move it to .dsc file, if it fits
better to the platform description/module dependencies structure.
> IOW, the other patch you sent that updates ARM Juno's .dsc is sufficient.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-09-23 16:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 22:32 [PATCH 0/2] Juno PCI fixes Daniil Egranov
2016-09-22 22:33 ` [PATCH 1/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Remove calls to ArmDmaLib Daniil Egranov
2016-09-23 7:57 ` Ard Biesheuvel
2016-09-23 16:20 ` Daniil Egranov [this message]
2016-09-23 16:21 ` Ard Biesheuvel
2016-09-23 21:47 ` Daniil Egranov
2016-09-24 12:05 ` Ard Biesheuvel
2016-09-22 22:33 ` [PATCH 2/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle Daniil Egranov
2016-09-23 7:58 ` Ard Biesheuvel
2016-10-12 8:37 ` Ryan Harkin
2016-10-12 8:41 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9f76849-4a12-f043-338b-7a89995ab868@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox