From: "Rebecca Cran" <rebecca@bsdio.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Abner Chang <abner.chang@hpe.com>,
Gilbert Chen <gilbert.chen@hpe.com>
Subject: Re: [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc.
Date: Sun, 9 Feb 2020 17:11:06 -0700 [thread overview]
Message-ID: <fa2d01ee-6757-cc57-7f84-49ca936f3cc4@bsdio.com> (raw)
In-Reply-To: <28f9f325-3106-1f3a-096d-d3aebc6fcc85@bsdio.com>
On 2020-02-09 12:07, Rebecca Cran wrote:
> I recently got a HiFive Unleashed board, and am interested in trying out
> RISCV EDK2 firmware either on it or in Qemu.
>
> It looks like the opensbi submodule in
> edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi needs updated
> though: the commit currently used -
> be92da280d87c38a2e0adc5d3f43bab7b5468f09 - is missing files such as
> sbi_hfence.S mentioned in
> RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf .
After updating the opensbi submodule to master, I now get a compile error:
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:
In function 'sbi_ecall_find_extension':
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:11:
error: implicit declaration of function 'container_of'
[-Werror=implicit-function-declaration]
sbi_list_for_each_entry(t, &ecall_exts_list, head) {
^~~~~~~~~~~~
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:50:
error: expected expression before 'typeof'
sbi_list_for_each_entry(t, &ecall_exts_list, head) {
^~~~
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:132:
error: expected expression before 'typeof'
sbi_list_for_each_entry(t, &ecall_exts_list, head) {
^
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:
In function 'sbi_ecall_unregister_extension':
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:64:50:
error: expected expression before 'typeof'
sbi_list_for_each_entry(t, &ecall_exts_list, head) {
^~~~
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:64:132:
error: expected expression before 'typeof'
sbi_list_for_each_entry(t, &ecall_exts_list, head) {
^
cc1: all warnings being treated as errors
--
Rebecca Cran
next prev parent reply other threads:[~2020-02-10 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 19:07 [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc Rebecca Cran
2020-02-10 0:11 ` Rebecca Cran [this message]
2020-02-10 1:53 ` Abner Chang
2020-02-10 15:13 ` [edk2-devel] " daniel.schaefer
2020-02-10 16:24 ` Rebecca Cran
2020-02-10 16:39 ` Abner Chang
2020-02-13 1:39 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa2d01ee-6757-cc57-7f84-49ca936f3cc4@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox