From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.88]) by mx.groups.io with SMTP id smtpd.web11.45531.1669906041336742958 for ; Thu, 01 Dec 2022 06:47:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=rbdo9ORs; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.88, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aoP+wcpfDSfW5YnhB+jEVuP7IXSzkpuTbuFzhdXOjPPLlrF9xS25hxU8uGngzKfZXy7mCpFM+XHbh1xjpl6FWlIhnr94QjoFQeq4LfNGEYcSqDP5qwlqd85yXalDG5RLxk1JP/zCa0oNPwKhdoyrGP0E6ZvucVYqC2aNh/qpvSZhGsiuQVibV8Dp8pSJji7Fj1jtlDUSlOpaawCnLIOV/tRUGUafhdr27hEZkEhXq7koGLHs4tXTxKqrwEgTEsi5sGLVJwVwBD5KcQZSa2oQFC4c53nrP7hawXRd675/jVzNuVqpEOoEZvi9Miv+OTm6gagOXne2w95l4EM2oW8dDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GhIL1mOtrYgv0DZhpbostLbngqBmzARxRxm/iadiPXo=; b=XJi50O1xmFt3rUh3Syjpy4dliJ+UQD+6+QNfWtUWa0vK7yzrR404P38i59EVETrANEhR2qJTJaC7Fx2T0R5IWkwUDbSnWLNaE0k4AgqIzK0+3Pt3gPXsNwaYOwQJEHd9jssX0Ospg27dA/LV+B+C2ISknzivxblrgssU1KPeu7qkK+7owb6ttTbGMr57VvQtNgT+/8WBvodTznf3cwepWTjtKaihNSppkTIgkc9yuVLrLUpERQZa9bZFX1UhuseZHpDyFdt5LSMuZQls9A7udJWe5cdy0WOaX+MLh0e9/pU/H0KfQc8uxxJAefejFXJXqo4FYlzv6t8RJdirQi+4Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GhIL1mOtrYgv0DZhpbostLbngqBmzARxRxm/iadiPXo=; b=rbdo9ORsrnin3lfeCQP7A+UlYq79vlq0HJ4ii4CX3vwJTJGCzD0JAPl3FkXfOOFOR5x4mn2El4Sh9wxXpQw31y1B5ptEw4A72QVDJkKlQkRPps+2mpXG08bN6lpX+8ESbU+6X1QQJu9wnaRS4KtMGTOi0xQBNjrZ2YrhsVHjE8U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by SA0PR12MB7090.namprd12.prod.outlook.com (2603:10b6:806:2d5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 14:47:13 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::d2d2:c91a:5927:104b]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::d2d2:c91a:5927:104b%5]) with mapi id 15.20.5880.008; Thu, 1 Dec 2022 14:47:13 +0000 Message-ID: Date: Thu, 1 Dec 2022 08:47:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Subject: [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to PcdConfidentialComputingGuestAttr To: Alexey Kardashevskiy , devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Brijesh Singh , Erdem Aktas , James Bottomley , Min Xu References: <20221201023521.10028-1-aik@amd.com> <20221201023521.10028-3-aik@amd.com> From: "Lendacky, Thomas" In-Reply-To: <20221201023521.10028-3-aik@amd.com> X-ClientProxiedBy: CH2PR19CA0006.namprd19.prod.outlook.com (2603:10b6:610:4d::16) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|SA0PR12MB7090:EE_ X-MS-Office365-Filtering-Correlation-Id: b6b0bdcd-c997-4e5e-0e49-08dad3aaeeb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d2dAYQJNguvAv2Kj9p+7mVq16h/QzP+y+bGbkMLtyQ0J/GA92OyFT80idDaOPRe0OzyISfsYkz8aZX1UkOyCfmmBNt7a0XKGmiTODxXtpAqYI/IghLlS1+Hzf7FyKsa9Jz94Af0NKBcE415G5pUsbuYHxlxujVHgRkNRGdrjuo9J9TVNTQd6sVW3z/0/n5cnqC2cuXr9DBDwB384Eyi4ujBESUkrayhG2q8BolqnF+i2rgRnLkxWOWTQbuW97VbNLg9Mt1mdgXkwKR5Ty+uQT9hLlDPVZn4NKO8bQLcPEGMN119RcqR7XbCs3WzXMLM1LvZLRxnj948oVL174VYJ9/wfce1mZD/B9SS6cyO6Z81SEOziLJP881q+QYiVx2Y/HuA7/ANPWhC/11iQ12YqtDl6CJs1nqmcpC87nPvMGRA38LIiUeUHt0g3Oa3Z7b4q504kUyLU6zSBRzEybgbAfqySgKnv2SFHCRCDurLCXq3VSvEYFgIjGBXv4B7eiS1qsbkjOnsbzYwSRn8GutJzcbEjJDvB9OgttQkRUz+1G8NonFOb25RhJTqHcbnkYl/V4bZLwJFGjQd2Zj52osl38XSDpr3YkiNn/t7pCd2NJ8+dtA3ynK2aRHaqvjOCLDNDHlCtkoe034WFY4sqLsikVwiMvbQ/r9DBx/BhHbOA8+GKBqvAx7VjaRHeX2aWNC+8XQd/dpidLHXTplKwh5vLWtre35hmQtvPuEONXrvFI1hl1NoUA4bAF9lpj1T4Szwk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(346002)(39860400002)(136003)(451199015)(83380400001)(31696002)(86362001)(53546011)(31686004)(478600001)(6506007)(6486002)(6512007)(41300700001)(36756003)(2616005)(186003)(8936002)(54906003)(66946007)(26005)(5660300002)(38100700002)(8676002)(2906002)(316002)(66476007)(66556008)(4326008)(213903007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3h0aC80cmNRSzluZ0x3WHZLMWxYdzlldGhxN1hoY3dzZ1U4YkZueE1DaHdR?= =?utf-8?B?U1Z6b0xiTklkUTE1RjJQNmJpb2FXNHJDbVNNWEZQT3V1QUJnczRmaFF1Qmh6?= =?utf-8?B?S2ZEbzNhS1hhbFFINUUvNUl4amx1MzFWb1FJUGpacmxwUnFyaThUYko0RzN4?= =?utf-8?B?c2dYa1ZSVUxzTHBHTlJCWktrMmJjbTlFUG1VOHovQmxDemdPWHc2ZjZhaVNL?= =?utf-8?B?UWgyVHRScWYrQUJCejlYaDdUNXlCaE1RbDJzWlBLSktkN0hhcWNyY3V2djI3?= =?utf-8?B?VXR3SFgvY0ZpZWtqMHA3V0tqcDQ0bmhDL3VyQ1VxYUpyOHNTUTV4Y21ZaVNZ?= =?utf-8?B?UHByVHFXcWpQdldDNDg2bEVoUUxUWStxYkpLVWozaFV3SmxGMHFibVJydlNr?= =?utf-8?B?WHpOeTAvQ0xCZStuUU41NS9sRHNwb2pXdVdpb0txeXFaZklBZC9xUlJDVStT?= =?utf-8?B?K3ZTeHdGOHRPcnJ1NzE0UmwzYzU0M2htN2I1Sm5LMHQrUFBnZVlBNEYzTTFj?= =?utf-8?B?eGpUV1ZtQVJJSXBiK2ZLR0ZTVzVua3VVY2hoYk5ZRFoyNUZvZ2tXc3Zqc1RN?= =?utf-8?B?STZiWW5KS2c5QXNZempGdVRDdEpjNE14NXN0RGg3dlFta2ZpTW1HMkVoRFFj?= =?utf-8?B?eEFiMmVzT05vWStTVEUrZTZocnhwYUNxZ0hBWmgxRlB3ZHZDTGtTV0dpNFE3?= =?utf-8?B?cGN3WEM5RnJlclhrRTcrallFbHlwQXVUTEVxT2pyMEV6SlNHRXNUejRqZFNL?= =?utf-8?B?aE1makFKdDlDaUhVN0twRWVLeUxVRVZCcFdBbjBZUkUrdnJYRUR5YVJKdVJr?= =?utf-8?B?aHlrWlNjOTBpY2tOVEFUeWVYR3VPSnBGUVNQZDNhWmpVUkRBYlRqTXNad3Mz?= =?utf-8?B?K2FURnFybWRQYjVYZGF1aWtkN1EvaXJybEQ1aHJYU2ZVcHkrUno3QVBXRmo3?= =?utf-8?B?RytYL1VTQXF4Q040YUpGL3lzdkFlSXIvMHJORytLOGdNd05NZENhYnp1ZFZH?= =?utf-8?B?akFKWEk1Y244RnBJMklVNFJFNkdFT1VGVEFjVHVNNmhwdVZ3Ulp4OEw4WS84?= =?utf-8?B?MmJjckcwMUhYZHlGWGE1MFl2QWp1Qk5TQi9xeDFxTmNSUytyZjhWNTN1Z0N4?= =?utf-8?B?endITkUwU0JxNmtJcm0rbEp2R3BrQzdTdElNWWk4Z0xmMHVwV2t1Z01UVm1r?= =?utf-8?B?VTNvK2s5QlE4MUYzYnBtd3ZBQmFQZjBFNjhYaEFSdlNBRm9ZRE1FRlB4WXVi?= =?utf-8?B?Zk82RW9DZFByN2ZpckdjQWU5TEdWemlWbUZ4SnJHOEY2Z1FtSGhieWFoSDlT?= =?utf-8?B?eW9VdWI1amFYait5Y3pNc1NSTCtwOURDSmpZZ0t4RC95U0RQWTN3cXVEYjJF?= =?utf-8?B?RmIxQWh6d01yVFBybDh6NzAyVlFLdTU0UE1YRmhNVnYxQ2xXY2xvNGt3dHU4?= =?utf-8?B?emlaYVNoWkE4M2lXL1lmN3QzWkFnK2xndFdLY2ZyNGNGV0ZySFB2blhoaC8w?= =?utf-8?B?MktOeUpGT0hYSnBLdkJpZzNPdkVXU3lDZlJYWERhaHE3Y0hPbmJ5L3VoUDg3?= =?utf-8?B?YVJIeHJZaXNML3JObERqMldhMWdqRFFDUk4rSExpSDl1aDlkVm4yZWVMSktS?= =?utf-8?B?dys4ZmFNVnNscStDOFpZeDZNVnNNQWpDM0pxQkhPNHZTdEJCcmo4Yk5USFBq?= =?utf-8?B?TTVpaFp2bEJTbC9BZTZMWGZ3M3U0WVpXSklKNTZvMGNDSml1U25RcEtHZ2Q1?= =?utf-8?B?SFpGWUpKRkFrSjRSSWNKOHhobSs0QVduNXk3bGE4eGhSNldhQlVNU0J6WC9T?= =?utf-8?B?d2NUL0xjV1plS2Q3SWVWaEdaazZWNjdPaGJWR0R1cTZabnQvbjZ4M2hZUHdh?= =?utf-8?B?VzFsa3kxZ1dNdkJid2tHWTZJRCs2eEZXUzUveHphUlBHYzVoemxtWkkrdWVO?= =?utf-8?B?MVllRWxSQmg4dzZpNzZwMFVEU3N3UTFxSmErU2xhSkNJcWxMZTB2MDA4ZDBa?= =?utf-8?B?cW8xcUtWT0RhdnFmRmdRK3FPajQ0TGJObTRIWUNFbyt4dDljd2M5bXE5bVdv?= =?utf-8?B?VDdkOThLanhSMnY5RDVXZlE4TDEzczJCSVNIWGRaY29NYWlTQ2VVeUJrMTJY?= =?utf-8?Q?c0bVBL3BY4WEt6Gy7k4jNv5hE?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6b0bdcd-c997-4e5e-0e49-08dad3aaeeb0 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 14:47:13.0168 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: afWb43i+bJRHhVBGZvdzVRyYxJtjONwAjc7Ri7JW78knRyz8QhWLMf3hZRCaUwBdCTlRVMnAcaMmXKBYpIAi9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7090 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Added the subject as somehow it didn't get set. On 11/30/22 20:35, Alexey Kardashevskiy wrote: > Date: Tue, 22 Nov 2022 16:12:55 +1100 > Subject: [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to > PcdConfidentialComputingGuestAttr > > PcdConfidentialComputingGuestAttr so far only contained an SEV mode bit > but there are more other features which do not translate to levels > such as DebugSwap or SecureTsc. > > This adds the features mask and the DebugSwap feature bit to a PCD. > > Signed-off-by: Alexey Kardashevskiy > --- > MdePkg/Include/ConfidentialComputingGuestAttr.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/ConfidentialComputingGuestAttr.h b/MdePkg/Include/ConfidentialComputingGuestAttr.h > index 44e6df800207..1fd09a51ea52 100644 > --- a/MdePkg/Include/ConfidentialComputingGuestAttr.h > +++ b/MdePkg/Include/ConfidentialComputingGuestAttr.h > @@ -26,12 +26,15 @@ typedef enum { > CCAttrAmdSev = 0x100, > CCAttrAmdSevEs = 0x101, > CCAttrAmdSevSnp = 0x102, > + CCAttrAmdSevFeatureMask = 0xffff0000, The PCD for this is 64-bits, should this be 0xffffffffffff0000? Thanks, Tom > + CCAttrAmdSevFeatureDebugSwap = 0x00010000, > > /* The guest is running with Intel TDX memory encryption enabled. */ > CCAttrIntelTdx = 0x200, > } CONFIDENTIAL_COMPUTING_GUEST_ATTR; > > #define CC_GUEST_IS_TDX(x) ((x) == CCAttrIntelTdx) > -#define CC_GUEST_IS_SEV(x) ((x) == CCAttrAmdSev || (x) == CCAttrAmdSevEs || (x) == CCAttrAmdSevSnp) > +#define _CC_GUEST_IS_SEV(x) ((x) == CCAttrAmdSev || (x) == CCAttrAmdSevEs || (x) == CCAttrAmdSevSnp) > +#define CC_GUEST_IS_SEV(x) _CC_GUEST_IS_SEV((x) & ~CCAttrAmdSevFeatureMask) > > #endif