From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mx.groups.io with SMTP id smtpd.web10.34870.1675058441918611999 for ; Sun, 29 Jan 2023 22:00:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=kv6HtJQC; spf=pass (domain: ventanamicro.com, ip: 209.85.210.178, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pf1-f178.google.com with SMTP id cr11so5255041pfb.1 for ; Sun, 29 Jan 2023 22:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:from:references:to:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=DozX0XfPajrxA4gZfUxjLj+aPA86yDjl3obgbu4ONB0=; b=kv6HtJQCvHhF8qTXiiaZqBQLDxUTzAKsyS6rjmbyfhYuTWldV0W8KtbvDDm1EvdSm3 veIoKOAk4+ylpceq5HuE7WYSVB5Dt6gqul8qRES8gqqjTMOgtcOnnX9yl4T+G+R5lvh/ 1Q4Q983WupmoT2VClqLe+FX38sB57DZfSp1a0f+txRh5iWUMefIpVO6dWRROkWLTU+Ws 7cTP4hTk6oVX98eHU8MGsO0t5Q6m5Vd71KcxfvNeuwrttU6+EEknmjDt+LPJh1EujAFS Oyz6IEprIcvDV5YYPJjSxq8dDjLJ4QzmnjrLwev7EKhwMYgP04Jo2ikYeTiKNG6/AUq7 IcFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:to:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DozX0XfPajrxA4gZfUxjLj+aPA86yDjl3obgbu4ONB0=; b=pG77hUWfTWbFWWiqK1UIdtbKWcU1LRITg8eq3lxnJB9EhJpxjrgKZKMMWBahnk1MHb Fcha5QkzqFsUFmc/HEeeUZjM+OdsRs6MBOtNqp6eTYTqq86+OLPJ7uRIwecYn+x1QzAa NeFZumrSrM6trYypNf3O6P4yy34qOHWvkdNVLjwpZBDemIHdlufXRz0VaTUKNJTMd+B3 xcdZ1qNFkWzfybMUCr1AgWfJ6TSS6V7mxeClDgDjrDQGT0hQ89xfHeuGE1cHOEBcue7h RxUKUI/e4QCfYzysGhQJwV7niizd9KLoT0OBrll4rqvUeeTi4E4/dTVu6lJy4RfovvvO MPbA== X-Gm-Message-State: AO0yUKUinF7ihm+r6dKA48hZ+NkrU7Zd1zsaua5XspEmP0LjRSHtOM1C toRpQhmXLiTvxMIP6lYmByF4rg== X-Google-Smtp-Source: AK7set+8zoXROrZOmB/NHT0upAXUMZqVItabG6nEB1BSE7xAhULElncNvCroYCh4Byx7SpAJeAoPag== X-Received: by 2002:a62:58c2:0:b0:593:c41e:480 with SMTP id m185-20020a6258c2000000b00593c41e0480mr2489465pfb.23.1675058441342; Sun, 29 Jan 2023 22:00:41 -0800 (PST) Return-Path: Received: from [192.168.100.177] ([49.206.11.246]) by smtp.gmail.com with ESMTPSA id v64-20020a626143000000b00574ebfdc721sm6753997pfb.16.2023.01.29.22.00.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jan 2023 22:00:41 -0800 (PST) Message-ID: Date: Mon, 30 Jan 2023 11:30:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 18/20] OvmfPkg/RiscVVirt: Add SEC module To: dhaval@rivosinc.com, devel@edk2.groups.io References: <20230128191807.2080547-19-sunilvl@ventanamicro.com> <1214.1675055850703338989@groups.io> From: "Sunil V L" In-Reply-To: <1214.1675055850703338989@groups.io> Content-Type: multipart/alternative; boundary="------------XvbwSFeOhfsshUjTJ5mkOpHr" Content-Language: en-US --------------XvbwSFeOhfsshUjTJ5mkOpHr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Dhaval, In general, I didn't not want to add many extra code/design  as part of this series to keep it simple  refactor and port from edk2-platforms patches. We are the first one to do this type of refactoring work and hence not easy to convince people. So, I am still keeping many things hardcoded as in edk2-platforms. Once this series gets merged, next set of patches will be mostly within RISC-V code which will be much easier to upstream. Irrespective of SATP (>= sv39), the physical address space is 56 bits as per the priv spec. We don't plan to support RV32 with edk2 anyway. Thanks Sunil On 30/01/23 10:47, dhaval@rivosinc.com wrote: > BuildCpuHob (56, 32); Can we find a better programmatic way of doing > this? SATP register could be on method, or PCD? Also would help if you > can clarify how we arrive at this value 56. --------------XvbwSFeOhfsshUjTJ5mkOpHr Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Dhaval,

In general, I didn't not want to add many extra code/design  as part of this series to keep it simple  refactor and port from edk2-platforms patches. We are the first one to do this type of refactoring work and hence not easy to convince people. So, I am still keeping many things hardcoded as in edk2-platforms. Once this series gets merged, next set of patches will be mostly within RISC-V code which will be much easier to upstream.

Irrespective of SATP (>= sv39), the physical address space is 56 bits as per the priv spec. We don't plan to support RV32 with edk2 anyway.

Thanks

Sunil

On 30/01/23 10:47, dhaval@rivosinc.com wrote:
BuildCpuHob (56, 32); Can we find a better programmatic way of doing this? SATP register could be on method, or PCD? Also would help if you can clarify how we arrive at this value 56.
--------------XvbwSFeOhfsshUjTJ5mkOpHr--