From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6A4E4209603D4 for ; Thu, 12 Jul 2018 02:49:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DE2F14B398; Thu, 12 Jul 2018 09:49:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-118.rdu2.redhat.com [10.10.120.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id E09D61C668; Thu, 12 Jul 2018 09:49:52 +0000 (UTC) To: Eric Dong , edk2-devel@lists.01.org Cc: Ruiyu Ni References: <20180711110729.12604-1-eric.dong@intel.com> <20180711110729.12604-4-eric.dong@intel.com> From: Laszlo Ersek Message-ID: Date: Thu, 12 Jul 2018 11:49:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180711110729.12604-4-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 12 Jul 2018 09:49:53 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 12 Jul 2018 09:49:53 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch 3/3] UefiCpuPkg/MpInitLib: Load uCode once for one core. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 09:49:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit I've got two comments: On 07/11/18 13:07, Eric Dong wrote: > SDM requires one core only needs to load uCode once. (1) This is a very confusing typo ("one core only"). I totally missed the point until I re-read the cover letter of the patch. In the cover letter, you say: > 3. Only apply uCode in one thread of a core when hyper threading is > enabled. So please fix the commit message to say, "The SDM requires only one *thread per core* to load the microcode", or something similar. (You don't need to add the emphasis, I'm only adding it here to make myself clear.) > Also load uCode once can save some time. > > This change enables this solution. > > Cc: Laszlo Ersek > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Library/MpInitLib/Microcode.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c b/UefiCpuPkg/Library/MpInitLib/Microcode.c > index 351975e2a2..4586e037d2 100644 > --- a/UefiCpuPkg/Library/MpInitLib/Microcode.c > +++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c > @@ -61,6 +61,7 @@ MicrocodeDetect ( > VOID *MicrocodeData; > MSR_IA32_PLATFORM_ID_REGISTER PlatformIdMsr; > UINT32 ProcessorFlags; > + UINT32 ThreadId; > > if (CpuMpData->MicrocodePatchRegionSize == 0) { > // > @@ -77,6 +78,14 @@ MicrocodeDetect ( > return; > } > > + GetProcessorLocationByApicId (GetInitialApicId(), NULL, NULL, &ThreadId); (2) A space character should be inserted after "GetInitialApicId". With those fixed: Acked-by: Laszlo Ersek Thanks Laszlo > + if (ThreadId != 0) { > + // > + // Skip loading microcode if it is not the first thread in one core. > + // > + return; > + } > + > ExtendedTableLength = 0; > // > // Here data of CPUID leafs have not been collected into context buffer, so >